Tolerate non-positive width/height during `media` parse

msg: The 'height' value must be positive: 0
     stack: com.atlassian.adf.model.ex.node.MediaException$HeightMustBePositive: The 'height' value must be positive: 0  (path: doc[4].mediaSingle[0].media)
    at com.atlassian.adf.model.node.Media$AbstractMedia.height(Media.java:615)
    at java.base/java.util.Optional.ifPresent(Optional.java:183)
    at com.atlassian.adf.model.node.Media$AbstractMedia.parseCommonAttrs(Media.java:702)
    at com.atlassian.adf.model.node.Media$AbstractMedia.parse(Media.java:710)
    at com.atlassian.adf.util.Factory.parse(Factory.java:65)
    at com.atlassian.adf.model.node.NodeParserSupport.lambda$getNodeOfType$0(NodeParserSupport.java:105)
    at com.atlassian.adf.model.ex.AdfException.frame(AdfException.java:70)
    at com.atlassian.adf.model.node.NodeParserSupport.getNodeOfType(NodeParserSupport.java:95)
    at com.atlassian.adf.model.node.MediaSingle.lambda$parse$0(MediaSingle.java:392)
    at com.atlassian.adf.model.ex.AdfException.frame(AdfException.java:70)
    at com.atlassian.adf.model.node.MediaSingle.parse(MediaSingle.java:391)
    at com.atlassian.adf.util.Factory.parse(Factory.java:65)

The library is slowly drifting towards tolerating invalid values while parsing ADF rather than throwing an exception for them. This is one of those cases where we have a reasonable alternative to throwing the exception (simply ignore the invalid value) so we should do that instead.

Comments (2)