The pending-pr job is broken when using Atlasboad 1.0.1
Issue #16
resolved
The breaking change was introduced here: https://bitbucket.org/atlassian/atlasboard/commits/588435d9f9612cdf9e873331242d0d4917db4149
The pending-pr job uses q.nbind
to "promisify" easyRequest.JSON
:
var getJSON = q.nbind(dependencies.easyRequest.JSON, dependencies.easyRequest);
and adding a new argument to the easyRequest.JSON
callback broke the object returned by getJSON
.
Comments (6)
-
reporter -
Another workaround is to change all of the data.values references in stash.js and bitbucket.js to data[0].values. It seems the new getJSON function is returning a list with a json blob inside it.
-
Is there any reason that
data = data[0]
isn't a correct fix here? I'm using that as a local hack; should I submit a PR? -
i-am-not-a-developer is basically the reason why I wasn't confident in making the fix more, uh, permanent... :)
-
reporter -
reporter - changed status to resolved
- Log in to comment
Workaround: use Atlasboard 1.0.0 instead until this issue is resolved