Added type memory as newly created sequelizeAdapter does not create an in memory and results in a URL undefined error db when development environment is used and sequalize is used

Branch: acalantog/fix-sequelize-url-issue-when-development-env-is-used

Branch: master

Merged

#52 · Created 2018-09-24 · Last updated 2019-06-17

Merged pull request

Merged in acalantog/fix-sequelize-url-issue-when-development-env-is-used (pull request #52)

9cb93ba·Author: Anne Calantog·Closed by: Anne Calantog·2018-09-24

Description

When trying to create a new ACE project:

atlas-connect new

and running via:

node app.js

An error is encountered:

url.js:103
    throw new TypeError('Parameter "url" must be a string, not ' + typeof url);
    ^

TypeError: Parameter "url" must be a string, not undefined
    at Url.parse (url.js:103:11)
    at Object.urlParse [as parse] (url.js:97:13)
    at new Sequelize (/Users/acalantog/Development/workspace-tutorial/test-ace/node_modules/sequelize/lib/sequelize.js:115:28)
    at new SequelizeAdapter (/Users/acalantog/Development/workspace-tutorial/test-ace/node_modules/atlassian-connect-express/lib/store/sequelize.js:49:31)
    at module.exports (/Users/acalantog/Development/workspace-tutorial/test-ace/node_modules/atlassian-connect-express/lib/store/sequelize.js:182:10)
    at Function.stores.create (/Users/acalantog/Development/workspace-tutorial/test-ace/node_modules/atlassian-connect-express/lib/store/index.js:18:10)
    at stores (/Users/acalantog/Development/workspace-tutorial/test-ace/node_modules/atlassian-connect-express/lib/store/index.js:12:17)
    at new Addon (/Users/acalantog/Development/workspace-tutorial/test-ace/node_modules/atlassian-connect-express/lib/index.js:35:38)
    at module.exports (/Users/acalantog/Development/workspace-tutorial/test-ace/node_modules/atlassian-connect-express/lib/index.js:210:12)
    at Object.<anonymous> (/Users/acalantog/Development/workspace-tutorial/test-ace/app.js:34:13)
    at Module._compile (module.js:643:30)
    at Object.Module._extensions..js (module.js:654:10)
    at Module.load (module.js:556:32)
    at tryModuleLoad (module.js:499:12)
    at Function.Module._load (module.js:491:3)
    at Function.Module.runMain (module.js:684:10)
    at startup (bootstrap_node.js:187:16)
    at bootstrap_node.js:608:3

Apparently, in store/sequelize.js, it checks for opts.type:

if(opts.type === "memory") {
        opts.dialect = 'sqlite';
        opts.storage = ':memory:';
    }

but initial config.json does not have this

Added type memory as newly created sequelizeAdapter does not create an in memory and results in a URL undefined error db when development environment is used and sequalize is used

Merged pull request

Description

0 attachments

0 comments

Loading commits...