1. Atlassian
  2. Atlassian Connect
  3. atlassian-connect-express-template

Pull requests

#8 Merged
Repository
Branch
master

AC-1119: a simple template for expired tokens

Author
  1. Eero Kaukonen
Reviewers
Description

A simple template for expired tokens. The two options I considered were a simple page like this, which looks OKish in web panels and such, and a more complex page (like the hello-world template). Does anybody have any strong preferences to either direction?

  • Learn about pull requests

Comments (4)

    1. Sam Day

      I tend to agree - IMO nuke the {{!< layout}}, vendors can do that themselves easily enough if they want to.

      I think it's better if the changes we're trying to make here keep things looking pretty much the same way they did before by default. We're just trying to extend the flexibility so that developers have the luxury of easily changing it if they want to.

      1. Eero Kaukonen author

        I tend to agree - IMO nuke the {{!< layout}}, vendors can do that themselves easily enough if they want to.

        If I understood correctly, we need to include at least the javascript on the page to avoid the infinite loading spinner. I think there is some value in having an example that kind of works, even though it is not necessarily minimal. Since the problem is not that easy to reproduce, it might be a surprise for some developers.

        Would you prefer I remove tha layout bit and add just the required JS?

        1. Sam Day

          Yeah, I personally think that'd be better. Basically just grab a cut-down version of the default layout and stick it in this template.