Make it work without esModuleInterop: true in tsconfig.json

Merged
#254 · Created  · Last updated

Merged pull request

Merged in without-tsconfig (pull request #254)

9d11f96·Author: ·Closed by: ·2021-06-02

Description

Libraries should not force users to enable esModuleInterop in tsconfig.json.

See this discussion: https://github.com/apollographql/apollo-server/issues/1977#issuecomment-683235089

I’ve fixed the d.ts file to work with and without esModuleInterop: true.

The existing TypeScript code would work without any changes.

The followings are the testing codes to ensure backward compatibility:

Current: https://github.com/umireon/atlassian-connect-express-esModuleInterop/tree/main

With esModuleInterop: true : https://github.com/umireon/atlassian-connect-express-esModuleInterop/tree/with-tsconfig

0 attachments

0 comments

Loading commits...