Michael Heemskerk avatar Michael Heemskerk committed b5748aa Merge

NONE: Merge

Comments (0)

Files changed (2)

src/test/java/com/atlassian/utils/process/ExternalProcessImplTest.java

 import java.util.Arrays;
 import java.util.concurrent.TimeUnit;
 
+import static org.hamcrest.CoreMatchers.instanceOf;
+import static org.hamcrest.CoreMatchers.is;
 import static org.junit.Assert.*;
 import static com.atlassian.utils.process.ExternalProcessTestUtils.*;
 
         process.execute();
 
         ProcessException exception = process.getHandler().getException();
-        assertTrue(exception instanceof ProcessTimeoutException);
+        assertThat(exception, is(instanceOf(ProcessTimeoutException.class)));
     }
 
     @Test(timeout = 10 * 1000) //Test timeout in case execution doesn't stop timeout like it should
         process.execute();
 
         ProcessException exception = process.getHandler().getException();
-        assertTrue(exception instanceof ProcessTimeoutException);
+        assertThat(exception, is(instanceOf(ProcessTimeoutException.class)));
     }
 
     private ExternalProcess buildProcessWithBlockingInputHandler() {

src/test/java/com/atlassian/utils/process/ExternalProcessMonitorTest.java

 import java.util.concurrent.TimeUnit;
 
 import static com.atlassian.utils.process.ExternalProcessTestUtils.*;
+import static org.hamcrest.CoreMatchers.instanceOf;
+import static org.hamcrest.CoreMatchers.is;
 import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertThat;
 import static org.junit.Assert.assertTrue;
 import static org.mockito.Matchers.same;
 import static org.mockito.Mockito.never;
 
         process.execute();
 
-        assertTrue(process.getHandler().getException() instanceof ProcessTimeoutException);
+        assertThat(process.getHandler().getException(), is(instanceOf(ProcessTimeoutException.class)));
         verify(monitor).onBeforeStart(same(process));
         verify(monitor).onAfterFinished(same(process));
     }
 
         process.execute();
 
-        assertTrue(process.getHandler().getException() instanceof ProcessTimeoutException);
+        assertThat(process.getHandler().getException(), is(instanceOf(ProcessTimeoutException.class)));
         verify(monitor).onBeforeStart(same(process));
         verify(monitor).onAfterFinished(same(process));
     }
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.