1. Atlassian
  2. Project: Atlassian
  3. atlassian-soy-templates
  4. Pull requests

Pull requests

#35 Merged
Repository
jwinters
Branch
master
Repository
atlassian
Branch
master

SOY-21: Use the provided sisu-guice rather than google guice

Author
  1. James Winters [Atlassian]
Reviewers
Description

Pull request 33 was declined because dependencies were not in correct pom - this should hopefully meet the correct project standards - have now removed scope as per request

  • Learn about pull requests

Comments (1)

  1. Jason Hinch

    The major issue that existed in #33 still stands. I'm not prepared to have the soy plugin have dependencies as provided if the dependency is not part of the platform. I'm happy for the dependencies to be bundled but the Import/Export entries remain in the manifest. This would mean that if the host application provides the dependencies the plugin would use them otherwise it would use its bundled one.