Npm task doesn't work on windows agents

[Scott Goodhew]

The resolution to #29 (ae7fbdfaf724) was to prefix all npm tasks with the node executable. This doesn't work on Windows agents because the npm executable isn't a javascript file it's a batch file.

This causes build failures like https://devtools-bamboo.internal.atlassian.com/browse/STASH-IT-TWX-958/log

[Drew Walker]

This is causing our linting and IE10 builds to fail too: https://collaboration-bamboo.internal.atlassian.com/browse/CONFUI-A4UICHECKS59-LINT-2/log

[Adam Ahmed]

If it helps, this is the contents of that batch file :

:: Created by npm, please don't edit manually.
@IF EXIST "%~dp0\node.exe" (
  "%~dp0\node.exe" "%~dp0\.\node_modules\npm\bin\npm-cli.js" %*
) ELSE (
  node "%~dp0\.\node_modules\npm\bin\npm-cli.js" %*
)

So you can just call npm-cli.js directly on Windows (and keep the node prefix if you want).

[Adam Ahmed]

Scott tells me the fix for this is already merged. Right on!

[Marcin Oles]

@samuel_tannous I'm closing this ticket, as the corresponding BDEV issue got resolved and I see commits with the fix.