Exception during lookup phase of 'skipping to delete active branch build dirs'

We recently enabled the setting 'Do not delete working directories from active branches'.

An agent had previously done some work with deployment projects. They ended up with directory names like "158138370-158269445", instead of regular plan builds with names like "PROJ-PLAN23-JOB3".

After running a plan on the same agent, we got the following error log:

26-Sep-2017 14:33:14    Running pre-build action: Run Predator
26-Sep-2017 14:33:14    [PredatorPreBuildAction] Starting predator plugin, pre build agent cleaner
26-Sep-2017 14:33:14    [PredatorPreBuildAction] Running these commands:
26-Sep-2017 14:33:14    [PredatorPreBuildAction] Skipping processes killing
26-Sep-2017 14:33:14    [PredatorPreBuildAction] Initial free space: 15.024975 GB
26-Sep-2017 14:33:14    [PredatorPreBuildAction] Skip deleting active branch in working directory RND-KEY-JOB1
26-Sep-2017 14:33:14    [PredatorPreBuildAction] Skip deleting active branch in working directory PR-C82M-TS
26-Sep-2017 14:33:14    [PredatorPreBuildAction] Exception when trying to remove old build working directories
26-Sep-2017 14:33:14    java.lang.IllegalArgumentException: String [158138370-158269445] is not a job key
26-Sep-2017 14:33:14            at com.google.common.base.Preconditions.checkArgument(Preconditions.java:145)
26-Sep-2017 14:33:14            at com.atlassian.bamboo.plan.PlanKeys.splitJobKey(PlanKeys.java:127)
26-Sep-2017 14:33:14            at com.atlassian.bamboo.plan.PlanKeys.lambda$static$0(PlanKeys.java:85)
26-Sep-2017 14:33:14            at com.atlassian.bamboo.plan.PlanKeys.getChainKeyFromJobKey(PlanKeys.java:239)
26-Sep-2017 14:33:14            at com.atlassian.bamboo.plugin.predator.executor.PredatorExecutor.isActiveBranch(PredatorExecutor.java:198)
26-Sep-2017 14:33:14            at com.atlassian.bamboo.plugin.predator.executor.PredatorExecutor.removeOldBuildWorkingDirectory(PredatorExecutor.java:186)
26-Sep-2017 14:33:14            at com.atlassian.bamboo.plugin.predator.executor.PredatorExecutor.removeOldBuildWorkingDirectory(PredatorExecutor.java:143)
26-Sep-2017 14:33:14            at com.atlassian.bamboo.plugin.predator.executor.PredatorPreBuildAction.call(PredatorPreBuildAction.java:138)
26-Sep-2017 14:33:14            at com.atlassian.bamboo.build.pipeline.tasks.PrepareBuildTask.runPreBuildActions(PrepareBuildTask.java:125)
26-Sep-2017 14:33:14            at com.atlassian.bamboo.build.pipeline.tasks.PrepareBuildTask.call(PrepareBuildTask.java:98)
26-Sep-2017 14:33:14            at com.atlassian.bamboo.v2.build.agent.DefaultBuildAgent.build(DefaultBuildAgent.java:185)
26-Sep-2017 14:33:14            at com.atlassian.bamboo.v2.build.agent.BuildAgentControllerImpl$1.call(BuildAgentControllerImpl.java:120)
26-Sep-2017 14:33:14            at com.atlassian.bamboo.v2.build.agent.BuildAgentControllerImpl$1.call(BuildAgentControllerImpl.java:113)
26-Sep-2017 14:33:14            at com.atlassian.bamboo.variable.CustomVariableContextImpl.withVariableSubstitutor(CustomVariableContextImpl.java:185)
26-Sep-2017 14:33:14            at com.atlassian.bamboo.v2.build.agent.BuildAgentControllerImpl.waitAndPerformBuild(BuildAgentControllerImpl.java:113)
26-Sep-2017 14:33:14            at com.atlassian.bamboo.v2.build.agent.DefaultBuildAgent$1.run(DefaultBuildAgent.java:126)
26-Sep-2017 14:33:14            at com.atlassian.bamboo.utils.BambooRunnables$1.run(BambooRunnables.java:47)
26-Sep-2017 14:33:14            at com.atlassian.bamboo.security.ImpersonationHelper.runWith(ImpersonationHelper.java:26)
26-Sep-2017 14:33:14            at com.atlassian.bamboo.security.ImpersonationHelper.runWithSystemAuthority(ImpersonationHelper.java:17)
26-Sep-2017 14:33:14            at com.atlassian.bamboo.security.ImpersonationHelper$1.run(ImpersonationHelper.java:41)
26-Sep-2017 14:33:14            at java.lang.Thread.run(Thread.java:745)

There seems to be a bug with the handling of deployment projects in PredatorExecutor.isActiveBranch(PredatorExecutor.java:198).

It causes the deletion of old dirs to stop and we don't clean stuff up as we want to.

Our workaround was to disable the setting once again.

Bamboo version: 6.1.1 build 60104

Bamboo Predator Plugin version: 2.0.10

Comments (6)