upcase on branch name fails

Issue #14 resolved
Former user created an issue

When I crate a pull request like

stash pull-request master @ user

I get an error like:

/var/lib/gems/1.8/gems/atlassian-stash-0.1.9/bin/../lib/atlassian/util/text_util.rb:27:in `to_sentence_case': undefined method `upcase' for 68:Fixnum (NoMethodError)
from /var/lib/gems/1.8/gems/atlassian-stash-0.1.9/bin/../lib/atlassian/util/text_util.rb:18:in `convert_branch_name_to_sentence'
from /var/lib/gems/1.8/gems/atlassian-stash-0.1.9/bin/../lib/atlassian/stash/pull_request.rb:115:in `title'
from /var/lib/gems/1.8/gems/atlassian-stash-0.1.9/bin/../lib/atlassian/stash/pull_request.rb:60:in `create_pull_request'
from /var/lib/gems/1.8/gems/atlassian-stash-0.1.9/bin/stash:84
from /var/lib/gems/1.8/gems/atlassian-stash-0.1.9/bin/../lib/atlassian/stash/git.rb:25:in `ensure_within_git!'
from /var/lib/gems/1.8/gems/atlassian-stash-0.1.9/bin/stash:82
from /var/lib/gems/1.8/gems/commander-4.1.6/lib/commander/command.rb:180:in `call'
from /var/lib/gems/1.8/gems/commander-4.1.6/lib/commander/command.rb:180:in `call'
from /var/lib/gems/1.8/gems/commander-4.1.6/lib/commander/command.rb:155:in `run'
from /var/lib/gems/1.8/gems/commander-4.1.6/lib/commander/runner.rb:422:in `run_active_command'
from /var/lib/gems/1.8/gems/commander-4.1.6/lib/commander/runner.rb:82:in `run!'
from /var/lib/gems/1.8/gems/commander-4.1.6/lib/commander/delegates.rb:8:in `run!'
from /var/lib/gems/1.8/gems/commander-4.1.6/lib/commander/import.rb:10
from /usr/local/bin/stash:23

By the looks of things, in text_util.rb , the index operator on line 68 is resulting in a number not a string.

I've changed this line to :

        str.slice(0,1).upcase + str.slice(1, str.length)

Comments (4)

  1. Jonas Bygdén

    I have the same problem, it points to another code-line though. Might be different version? My branch is named "test".

    /Users/jonasb/.rvm/gems/ruby-1.8.7-p374/gems/atlassian-stash-0.1.9/bin/../lib/atlassian/util/text_util.rb:27:in `to_sentence_case': undefined method `upcase' for 116:Fixnum (NoMethodError)
            from /Users/jonasb/.rvm/gems/ruby-1.8.7-p374/gems/atlassian-stash-0.1.9/bin/../lib/atlassian/util/text_util.rb:18:in `convert_branch_name_to_sentence'
            from /Users/jonasb/.rvm/gems/ruby-1.8.7-p374/gems/atlassian-stash-0.1.9/bin/../lib/atlassian/stash/pull_request.rb:115:in `title'
            from /Users/jonasb/.rvm/gems/ruby-1.8.7-p374/gems/atlassian-stash-0.1.9/bin/../lib/atlassian/stash/pull_request.rb:60:in `create_pull_request'
            from /Users/jonasb/.rvm/gems/ruby-1.8.7-p374/gems/atlassian-stash-0.1.9/bin/stash:84
            from /Users/jonasb/.rvm/gems/ruby-1.8.7-p374/gems/atlassian-stash-0.1.9/bin/../lib/atlassian/stash/git.rb:25:in `ensure_within_git!'
            from /Users/jonasb/.rvm/gems/ruby-1.8.7-p374/gems/atlassian-stash-0.1.9/bin/stash:82
            from /Users/jonasb/.rvm/gems/ruby-1.8.7-p374/gems/commander-4.1.6/lib/commander/command.rb:180:in `call'
            from /Users/jonasb/.rvm/gems/ruby-1.8.7-p374/gems/commander-4.1.6/lib/commander/command.rb:180:in `call'
            from /Users/jonasb/.rvm/gems/ruby-1.8.7-p374/gems/commander-4.1.6/lib/commander/command.rb:155:in `run'
            from /Users/jonasb/.rvm/gems/ruby-1.8.7-p374/gems/commander-4.1.6/lib/commander/runner.rb:422:in `run_active_command'
            from /Users/jonasb/.rvm/gems/ruby-1.8.7-p374/gems/commander-4.1.6/lib/commander/runner.rb:82:in `run!'
            from /Users/jonasb/.rvm/gems/ruby-1.8.7-p374/gems/commander-4.1.6/lib/commander/delegates.rb:8:in `run!'
            from /Users/jonasb/.rvm/gems/ruby-1.8.7-p374/gems/commander-4.1.6/lib/commander/import.rb:10
            from /Users/jonasb/.rvm/gems/ruby-1.8.7-p374/bin/ruby_executable_hooks:15
    
  2. Log in to comment