GitLab support for JIRA 6.3.x
Declined pull request
Reposting the declination message here. Hi Daniel, Thanks for your contribution but at this stage we do not plan on merging this PR. I'll give you some reasons below but first here is some context of where the DVCS connector plugin fits into JIRA. Originally the DVCS connector plugin exposed commits etc. through tabs that it created in JIRA, these are the tabs that you referred to in your 6.3 PR. Over the last few years we have been moving to a unified view of development information presented in JIRA with a plugin called 'Development Status'. This plugin presents the information from all the dev tools in one place and as we have expanded its functionality there have been corresponding changes to the functionality in the DVCS connector. I've spent some time trying to work out how to fit your changes in with the Development Status plugin as Atlassian would need to take ownership of the changes. Based on this review we would like to do this as a separate plugin. In addition to this you mentioned that you copied in the code from https://github.com/timols/java-gitlab-api for making the calls to gitlab. We would require that the dependency is instead brought in via maven, I see you asked about this in the 6.3 PR. This also requires some investigation of licensing, the code on that project is a Apache 2.0 license. The Bitbucket client in DVCS connector is one that we have written ourselves and the Github client uses egit (http://www.eclipse.org/egit/) to perform that communication. Separate from this there are some code level changes that we would require for this PR to be merged: * We require unit test coverage across this code * We also require integration tests either via REST calls or web driver tests (see current it. test package) that would run against a gitlab instance. This would be similar in structure to what we do with Bitbucket and Github already, although the accounts we use are not public. If you would like to take these changes further the project is open source so you could look at forking it and publishing it on Atlassian marketplace yourself. If you went down that path you would need to check that you abide by the terms of the license. This should be fine though, Gitlab is a BTF product so you should be able to change the plugin key. Kind regards Ben
This pull request adds initial support for self-hosted GitLab.
I'm running this for a couple of months now in our internal productive environment without any issues. Sync of repositories and all commits works without any problems.
At the time of writing I was only able to develop this for JIRA 6.3.x and it seems that there were quite some changes in the internal plugin structure in later versions.
I will test this now also on JIRA 6.4.x and try to make neccessary adaptations (and file another pull request). Unfortunately I have no idea how to test this against a JIRA 6.5.x as this is not public yet so I'm a little unsure if I will be able to create a good pull request against master in the future.
The plugin uses the Java API Wrapper (https://github.com/timols/java-gitlab-api) which I have included in source code. I don't know if this is the right way (or rather it should be added as a dependency), but it seems to have been done the same for BitBucket and/or GitHub.
See also https://answers.atlassian.com/questions/244555/answers/13411837/comments/15843663