Initial Gitlab support for JIRA 6.5.x (master)
Declined pull request
Hi Daniel, Thanks for your contribution but at this stage we do not plan on merging this PR. I'll give you some reasons below but first here is some context of where the DVCS connector plugin fits into JIRA. Originally the DVCS connector plugin exposed commits etc. through tabs that it created in JIRA, these are the tabs that you referred to in your 6.3 PR. Over the last few years we have been moving to a unified view of development information presented in JIRA with a plugin called 'Development Status'. This plugin presents the information from all the dev tools in one place and as we have expanded its functionality there have been corresponding changes to the functionality in the DVCS connector. I've spent some time trying to work out how to fit your changes in with the Development Status plugin as Atlassian would need to take ownership of the changes. Based on this review we would like to do this as a separate plugin. In addition to this you mentioned that you copied in the code from https://github.com/timols/java-gitlab-api for making the calls to gitlab. We would require that the dependency is instead brought in via maven, I see you asked about this in the 6.3 PR. This also requires some investigation of licensing, the code on that project is a Apache 2.0 license. The Bitbucket client in DVCS connector is one that we have written ourselves and the Github client uses egit (http://www.eclipse.org/egit/) to perform that communication. Separate from this there are some code level changes that we would require for this PR to be merged: * We require unit test coverage across this code * We also require integration tests either via REST calls or web driver tests (see current it. test package) that would run against a gitlab instance. This would be similar in structure to what we do with Bitbucket and Github already, although the accounts we use are not public. If you would like to take these changes further the project is open source so you could look at forking it and publishing it on Atlassian marketplace yourself. If you went down that path you would need to check that you abide by the terms of the license. This should be fine though, Gitlab is a BTF product so you should be able to change the plugin key. Kind regards Ben
Similar to pull request #100 this adds Gitlab support to the current master branch.
One serious limitation I'm aware of is that this only works if the Development Integration Plugin (which displays the development tools panel on the issue view) is disabled. If disabled, it shows the source tab and the related commits. I'm happy to update the pull request if anyone has a hint on how to remove this limitation.