Check if required parameters were added

Issue #9 open
Leandro de Oliveira created an issue

Hi, I’d like to implement a check for adding a required parameter to a spec because that’s a breaking change but I’m struggling to implement it, would you be so kind enough to finish it and incorporate it in your project? Here is the branch: https://bitbucket.org/lehphyro/openapi-diff/branch/required-query-param-check

Comments (10)

  1. Ben Sayers

    Hi @Leandro de Oliveira ,

    Thanks for making a start on this! I’ll add this to my teams backlog to review and finish. I can’t make any promises about how quickly we can get this into master but we’ll try to get it done as soon as we can.

  2. Leandro de Oliveira reporter

    Great! Please let me know if you need me to create a PR or give you access to my forked project.

  3. Ben Sayers

    @Leandro de Oliveira in order for us to include your contributions we will need a signed Contributor License Agreement. You can read more details and find links in our contributing docs. If you are happy to agree to this please follow the process to sign it and let me know when you are done. If you would prefer not to agree to this, we are happy to add this feature to the tool, but will need to implement it from scratch.

  4. Jean-François Côté

    @Ben Sayers Any update on this? This is preventing me from using this solution because changing an existing parameter to required or to add a required parameter is a breaking change that is not detected by this project.

  5. Log in to comment