Download button seems not to work correctly when I selected any branch or tag.

Create issue
Issue #5 resolved
Narichika Kajihara created an issue

Download button seems not to work correctly when I selected any branch or tag.

Steps to Reproduce

  1. Open this URL. This is an example page to explain this bug. https://StashURL/projects/HTML5/repos/rtc2013/browse?at=refs%2Ftags%2Frelease20130821
  2. Click the Download button. Following url is generated. https://StashURL/plugins/servlet/archive/projects/HTML5/repos/rtc2013?at=refs%252Ftags%252Frelease20130821
  3. A 404 page is shown. The Download button should be linked to like this: https://StashURL/plugins/servlet/archive/projects/HTML5/repos/rtc2013?at=release20130821

Expected Results

  • The zip file(source code) should download.

Actual Results

  • A 404 page is shown.

Workaround

  • deleting an argument which is encoded by tag name. in this case, "refs%252Ftags%252F"

Comments (5)

  1. Bryan Turner

    When version 2.1 is released to Marketplace, two different issues with the "Download" button have been resolved:

    • "Download" URLs are no longer double-encoded, eliminating %252F issues
    • The "Download" URL is correctly updated when the branch or tag in the selector is changed
  2. Bryan Turner

    I'm actioning some feedback from review at the moment, @bewster, and considering another test or two. I'm hoping to get everything merged and released tomorrow (U.S. Pacific Time).

  3. Log in to comment