Analyzing rescopes using git diff/git patch-id shouldn't happen directly on event threads

Issue #18 resolved
Bryan Turner created an issue

It may be desirable to move all of the event listeners to a background ExecutorService but, at a minimum, AutoUnapproveListener.onPullRequestRescoped should delegate to an executor because the git diff and git patch-ids commands it runs may be slow. That can lead to event threads backing up and events being dropped, which can result in difficult to diagnose runtime issues across the system.

Comments (3)

  1. Log in to comment