Option to Unapprove On Any New Commit, Regardless of the RescopeAnalyzer's Analysis

Issue #19 new
Jason Kemp created an issue

Our teams would prefer to have a choice between the old behavior (unapprove on any change) and the new (unapprove only for meaningful changes) behavior. We had this, fairly standard situation, occur:

resync-merge.png

According to our processes, that should have triggered the approver to re-check the pull request. The re-check in this case likely would have been quick, but a re-check should have been done regardless.

Perhaps the unapprove setting could be changed to a dropdown list of:

  • Do not unapprove on change
  • Unapprove on meaningful changes
  • Unapprove on any change

Comments (3)

  1. Julius Davies [bit-booster.com]

    The paid PR-Booster add-on supports this.

    PR-Booster supports the following 3 choices for approval resetting behaviour:

    1. No - Disabled (default)
    2. Yes - For significant pushes (recommended)
    3. Yes - For all pushes

    Screenshot attached.

    pr-booster-config.png

  2. Kristy Hughes

    There is now (as of 4.2.1) the option to turn off patch-id behaviour globally (i.e. for the entire Bitbucket Server instance).

    This issue will remain open though since there is still no option to turn off this setting at a project/repo level.

  3. Jeff Horton

    This bug allows a developer the ability to update the source branch of a pull request with whitespace and the unapproved plugin will not trigger. Please fix this!

  4. Log in to comment