Improve messaging when pull request is unapproved
Some feedback from our team has come in after starting to use this plugin. The general theme is that it is unclear why it was unapproved. Perhaps an enhancement to this plugin would be to some how indicate that the PR was unapproved by the system.
Comments (5)
-
-
Account Deactivated Indeed, this seems like a trivial fix. (I'm not a fan of adding too many options, but one could also make this an option...)
Alternatively the unapprove could be done by a system user (again, optional?) so it's clear that it was not a reviewer that consciously unapproved.
-
Account Deactivated Pull request #6 adds the comment as whatever user updates the pull request. That seems likely to replace the existing confusion ("Why was my approval withdrawn?") with new confusion ("I didn't write this comment; where did it come from?"). Deciding exactly how unapproval should be messaged via the UI is the non-trivial part. Perhaps people who use this app have some ideas?
-
Issue
#43was marked as a duplicate of this issue. -
Please fix this. Thanks.
- Log in to comment
This issue was reported in 2013, and there is a very simple fix for it (pull request #6). It would be nice to have this implemented upstream.