1. Atlassian Avatar Atlassian
  2. Project: Atlassian
  3. stash-auto-unapprove-plugin
  4. Issues

Improve messaging when pull request is unapproved

Issue #2 new
Former user created an issue

Some feedback from our team has come in after starting to use this plugin. The general theme is that it is unclear why it was unapproved. Perhaps an enhancement to this plugin would be to some how indicate that the PR was unapproved by the system.

Comments (5)

  2. Simon Steinbeiss Account Deactivated

    Indeed, this seems like a trivial fix. (I'm not a fan of adding too many options, but one could also make this an option...)

    Alternatively the unapprove could be done by a system user (again, optional?) so it's clear that it was not a reviewer that consciously unapproved.

  3. Bryan Turner Account Deactivated

    Pull request #6 adds the comment as whatever user updates the pull request. That seems likely to replace the existing confusion ("Why was my approval withdrawn?") with new confusion ("I didn't write this comment; where did it come from?"). Deciding exactly how unapproval should be messaged via the UI is the non-trivial part. Perhaps people who use this app have some ideas?

  6. Log in to comment
Assignee
–
Type
enhancement
Priority
trivial
Status
new
Votes
6
Watchers
7