Unhandled exception when running git blame

[Robbin Robbin]

hi,

I'm seeing a number of ERROR statements in the atlassian stash log files like this:

2014-06-18 14:55:47,224 ERROR [http-bio-7990-exec-2149] wapaul 895x43283x5 1cz5f3b 10.12.24.53,10.100.5.155 "GET /rest/suggest-reviewers/1.0/by/ref HTTP/1.1" c.a.s.s.i.ScoringSuggestedReviewerService class com.atlassian.stash.suggestreviewers.internal.suggester.BlameSuggester threw an exception (or returned unexpected data) when suggesting reviewers and was ignored.
com.atlassian.stash.exception.CommandFailedException: /opt/git/prod/bin/git blame --incremental bd3e90a669e8666d1e46fe62edf3decaeee64a81 -- mod/t068_pc_common failed
     at com.atlassian.stash.scm.DefaultCommandExitHandler.onError(DefaultCommandExitHandler.java:42) ~[stash-spi-2.12.1.jar:na]
     at com.atlassian.stash.suggestreviewers.internal.suggester.git.MissingPathIgnoringExitHandler.onError(MissingPathIgnoringExitHandler.java:28) ~[plugin.6937060012830633630.stash-suggest-reviewers-1.2_1398899428000.jar:na]
     at com.atlassian.stash.scm.DefaultCommandExitHandler.onExit(DefaultCommandExitHandler.java:33) ~[stash-spi-2.12.1.jar:na]
     at com.atlassian.stash.scm.BaseCommand.callExitHandler(BaseCommand.java:143) ~[stash-spi-2.12.1.jar:na]
     at com.atlassian.stash.scm.BaseCommand$CommandFuture.internalGet(BaseCommand.java:256) ~[stash-spi-2.12.1.jar:na]
     at com.atlassian.stash.scm.BaseCommand$CommandFuture.get(BaseCommand.java:225) ~[stash-spi-2.12.1.jar:na]
     at com.atlassian.stash.scm.BaseCommand.call(BaseCommand.java:78) ~[stash-spi-2.12.1.jar:na]
     at com.atlassian.stash.suggestreviewers.internal.suggester.BlameSuggester.getBlame(BlameSuggester.java:139) ~[plugin.6937060012830633630.stash-suggest-reviewers-1.2_1398899428000.jar:na]
     at com.atlassian.stash.suggestreviewers.internal.suggester.BlameSuggester.suggestFor(BlameSuggester.java:68) ~[plugin.6937060012830633630.stash-suggest-reviewers-1.2_1398899428000.jar:na]
     at com.atlassian.stash.suggestreviewers.internal.ScoringSuggestedReviewerService.getSuggestedReviewers(ScoringSuggestedReviewerService.java:64) ~[plugin.6937060012830633630.stash-suggest-reviewers-1.2_1398899428000.jar:na]
     at com.atlassian.stash.suggestreviewers.internal.rest.SuggestedReviewersResource.suggestReviewers(SuggestedReviewersResource.java:102) [plugin.6937060012830633630.stash-suggest-reviewers-1.2_1398899428000.jar:na]
     at com.atlassian.stash.suggestreviewers.internal.rest.SuggestedReviewersResource.forRefs(SuggestedReviewersResource.java:82) [plugin.6937060012830633630.stash-suggest-reviewers-1.2_1398899428000.jar:na]
     at com.atlassian.applinks.core.rest.context.ContextFilter.doFilter(ContextFilter.java:25) [applinks-plugin-4.1.1_1393500360000.jar:na]
     at com.atlassian.stash.internal.spring.security.StashAuthenticationFilter.doFilter(StashAuthenticationFilter.java:92) [StashAuthenticationFilter.class:na]
     at com.atlassian.stash.internal.web.auth.BeforeLoginPluginAuthenticationFilter.doInsideSpringSecurityChain(BeforeLoginPluginAuthenticationFilter.java:111) [BeforeLoginPluginAuthenticationFilter.class:na]
     at com.atlassian.stash.internal.web.auth.BeforeLoginPluginAuthenticationFilter.doFilter(BeforeLoginPluginAuthenticationFilter.java:77) [BeforeLoginPluginAuthenticationFilter.class:na]
     at com.atlassian.security.auth.trustedapps.filter.TrustedApplicationsFilter.doFilter(TrustedApplicationsFilter.java:100) [atlassian-trusted-apps-core-3.0.3.jar:na]
     at com.atlassian.oauth.serviceprovider.internal.servlet.OAuthFilter.doFilter(OAuthFilter.java:61) [atlassian-oauth-service-provider-plugin-1.9.1_1393336222000.jar:na]
     at com.atlassian.stash.internal.web.auth.BeforeLoginPluginAuthenticationFilter.doBeforeBeforeLoginFilters(BeforeLoginPluginAuthenticationFilter.java:89) [BeforeLoginPluginAuthenticationFilter.class:na]
     at com.atlassian.stash.internal.web.auth.BeforeLoginPluginAuthenticationFilter.doFilter(BeforeLoginPluginAuthenticationFilter.java:75) [BeforeLoginPluginAuthenticationFilter.class:na]
     at com.atlassian.stash.internal.request.DefaultRequestManager.doAsRequest(DefaultRequestManager.java:73) [stash-service-impl-2.12.1.jar:na]
     at java.lang.Thread.run(Thread.java:662) [na:1.6.0_27]

[Robin Stocker]

Can you reproduce this problem every time? Does it only occur with a certain branch or commits? Does the path mod/t068_pc_common exist in commit bd3e90a669e8666d1e46fe62edf3decaeee64a81?

[Robbin Robbin]

hi, not sure how exactly this error occured, but I do know it's a submodule. We've got a pretty big stash setup (over 3000 repositories) and I'm not sure where to find commit bd3e90a669e8666d1e46fe62edf3decaeee64a81

[Robin Stocker]

Thanks for getting back. I've now looked at the code, and since Stash 3.1.0, the exception should include the exit code and standard error output of the command.

I'm going to close this, but if you encounter this error again, please update the issue with the new error message and I can reopen the issue.