chore: remove default exports and enable tslint rule
Mauri Edo
Branch: no-export-defaults
no-export-defaults
Branch: master
master
Merged
#7 · Created · Last updated
Merged pull request
chore: remove default exports and enable tslint rule
a49c97e·Author: Mauri Edo·Closed by: Mauri Edo·2018-02-21
Description
⚠️ Massive PR alert ⚠️
Turns out tslint has a rule you can enable to prevent export default, so I've enabled it here. What happens after this is a massive broken window fixing to move away from this pattern.
Unsure about how much do you want to dedicate to this, so if you are thinking of not reviewing or just skimming, can I direct you to the builder files (test/unit/support/swagger-builder.ts and its builder dependencies)? There was a pattern here to export builder types in their own files to be imported in the master builder and exported from the master builder as well to be imported in the tests. For clarity and (my) sanity, I've removed exporting the individual types from the master builder, and let the tests import builder types from the individual builder modules. Do you agree?
Update:
I've also taken the chance to add the member-access rule to prevent default visibility in constructors, only three additional files changed ;-)
⚠️ Massive PR alert ⚠️
Turns out tslint has a rule you can enable to prevent
export default
, so I've enabled it here. What happens after this is a massive broken window fixing to move away from this pattern.Unsure about how much do you want to dedicate to this, so if you are thinking of not reviewing or just skimming, can I direct you to the builder files (test/unit/support/swagger-builder.ts and its builder dependencies)? There was a pattern here to export builder types in their own files to be imported in the master builder and exported from the master builder as well to be imported in the tests. For clarity and (my) sanity, I've removed exporting the individual types from the master builder, and let the tests import builder types from the individual builder modules. Do you agree?
Update:
I've also taken the chance to add the member-access rule to prevent default visibility in constructors, only three additional files changed ;-)