1. Atlassian Avatar Atlassian
  2. Tooling and Automation
  3. swagger-request-validator
  4. Issues

Pact Upgrade to latest: 3.5.20

Issue #135 resolved
Kumar Gaurav created an issue

Hi James,

I have almost finished all changes to upgrade pact to latest: 3.5.19. Fixed all deprecated methods and it looks good with tests and with my local testing. However I am not able to push my local branch to remote. Do I need access? If yes, can you pls give me access. I have asked my company to check contributor CLA for review. I don't expect any issue however if they have any, I can push changes as individual contributor. In the meantime, it would be great if you could review the changes.

Thanks, Kumar

Comments (13)

  1. James Navin

    Thanks for the contribution!

    The easiest way to get your change merged is to push it to a fork of the repo, then raise a pull request from the branch on your fork back to this repo. Let me know if you get stuck!

    Cheers.

  5. Kumar Gaurav reporter

    Hi @jnavin, I submitted a PR for pact upgrade. Can you please have a look when have time. Thanks. :)

  7. Kumar Gaurav reporter

    There is a corporate CLA done. Do I need to create another bitbucket account with corporate email address? If yes, I will close above PR and create a new PR from new account (with corporate email address). Thanks. @jnavin

  8. James Navin

    Hi Kumar - thanks a lot for the contribution!

    If you have the link to the corporate CLA (or can let me know the company name so I can look it up) that will be fine.

    I'll try to get time to look at the PR soon.

  9. Kumar Gaurav reporter

    Thanks @jnavin, company name is eBay/eBay Classifieds Group. Pls let me know if you don't find a CLA, I will try to find a link in that case.

  14. Log in to comment
Assignee
–
Type
enhancement
Priority
major
Status
resolved
Votes
0
Watchers
2