Existing messages.properties file collision

Issue #49 resolved
Patrick Bray created an issue

Ran into an issue when implementing a test in a service which had an existing messages.properties file. In this case the existing file was loaded and a warning message was logged during the Message Resolution:

2017-06-09 11:45:18,950 WARN  [main] com.atlassian.oai.validator.report.MessageResolver: {} No message key found for 'validation.request.path.missing'

As the message key was unable to resolve no Message was added to the ValidationReport and hence passed my validation. It might be better to hard code a message in this case? and or use a different name for the resource bundle?

Comments (4)

  1. Tuan Dinh

    I think using a different name is probably better than hard code the messages, especially when considering message localisation.

    In fact, I think we should move these resource bundle files to a more dedicated path, i.e swagger/validation/messages.properties, etc.

    Tuan

  2. Log in to comment