NullPointerException using $ref parameters

I'm using swagger-request-validator-core:1.1.1

Given the document fragment:

    "/user/businesses": {
      "x-swagger-router-controller": "businesses",
      "get": {
        "description": "return user businesses",
        "operationId": "getList",
        "parameters": [
          {
            "$ref": "#/parameters/os"
          },
        ]

  "parameters": {
    "os": {
      "name": "os",
      "in": "query",
      "description": "Operating System ID",
      "required": true,
      "type": "string"
    },
  },

I get a NullPointerException while validating requestHeaders, most probably because the "in" part of the parameter is null before resolving the $ref.

The offending piece of code in RequestValidator:

    @Nonnull
    private ValidationReport validateHeaders(@Nonnull final Request request,
                                             @Nonnull final ApiOperation apiOperation) {
        return apiOperation
                .getOperation()
                .getParameters()
                .stream()
                .filter(p -> p.getIn().equalsIgnoreCase("HEADER"))
                .map(p -> validateParameter(
                        apiOperation, p,
                        request.getHeaderValues(p.getName()),
                        "validation.request.parameter.header.missing")
                )
                .reduce(ValidationReport.empty(), ValidationReport::merge);
    }

p.getIn() is possibly null in this case.

Comments (8)