a warning "Pull Request has no approvals" displayed even if the PR has been approved through the Approve button next to the Merge button
Issue #176
resolved
I have a PR configuration that PR must be approved by at least 1 reviewer.
Now in the plugin, after I clicked “Approve” button, the approval succeeded, both the plugin and web UI show it has been approved, but when I clicked “Merge” button, a warning displayed as follows:
I guess this is a bug?
Thanks.
Comments (6)
-
Account Deactivated -
Account Deactivated - changed component to triaged
-
Account Deactivated @{557058:a1219676-e210-4775-803b-12dbf511a74e} Thanks for the feedback. This is a bug. The extension is filtering out the current user when counting the number of approvals. We will fix it in the next version.
-
- changed status to open
-
Account Deactivated - changed status to resolved
Version 2.0.0 fixes this issue.
-
- removed component
Removing component: triaged (automated comment)
- Log in to comment
linked to:VSCODE-546