Fetching Pull Request Fails

Issue #478 resolved
Dean Penfold created an issue

I get the error when trying to open a repo that has a PR open for it. The PR is shown but when attempting to select it I get

“Error: fetching pull request details failed”

Looking at the output for “Atlassian” under VSCode I see the following error.

”error fetching pull request details TypeError: e.ts.localeCompare is not a function”

The same issue shows itself over multiple repositories in different projects of which they contain submodules.

One git repo which has submodules with PRs that fail to open has it’s own PR which succeeds when opening.

Extension Version: v2.8.0

Version: 1.49.0
Commit: e790b931385d72cf5669fcefc51cdf65990efa5d
Date: 2020-09-10T13:20:50.359Z
Electron: 9.2.1
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: 8.3.110.13-electron.0
OS: Linux x64 5.4.0-48-generic

Comments (5)

  1. Ian Chamberlain Account Deactivated

    Since updating to 2.8.0 I am unable to see several pull requests as well. The repo in question has several submodules as well,.

    • "Created by me" filter returns empty list
    • "to be reviewed" filter returns empty list
    • Any pull requests created by me that are shown in the list show this when expanded: Screen Shot 2020-09-17 at 10.05.21.png

    My console output shows this:

    [2020-09-17 14:01:49:892] Atlassian for VS Code (v2.8.0) activated in 9 ms 
    [2020-09-17 14:01:50:766] Error getting URL: https://bitbucket.128technology.com/rest/mirroring/1.0/mirrorServers?limit=100  [object Object]
    [2020-09-17 14:02:26:756] error fetching pull request details TypeError: e.ts.localeCompare is not a function
    [2020-09-17 14:02:28:088] error getting merge base:  Failed to execute git {
      "exitCode": 128,
      "gitCommand": "merge-base",
      "stdout": "",
      "stderr": "fatal: Not a valid object name origin/jsilvia/test-golang-sets\n"
    }
    [2020-09-17 14:02:28:089] error getting merge base:  Failed to execute git {
      "exitCode": 128,
      "gitCommand": "merge-base",
      "stdout": "",
      "stderr": "fatal: Not a valid object name origin/jsilvia/test-golang-sets\n"
    }
    [2020-09-17 14:04:34:702] error fetching pull request details TypeError: e.ts.localeCompare is not a function
    

    Although the two "error getting merge base" don't seem directly related, since the related PR for that branch seems to work fine.

    Extension details:

    Name: Jira and Bitbucket (Official)
    Id: atlassian.atlascode
    Description: Bringing the power of Jira and Bitbucket to VS Code - With Atlassian for VS Code you can create and view issues, start work on issues, create pull requests, do code reviews, start builds, get build statuses and more!
    Version: 2.8.0
    Publisher: Atlassian
    VS Marketplace Link: https://marketplace.visualstudio.com/items?itemName=Atlassian.atlascode
    

    VSCode details:

    Version: 1.49.0
    Commit: e790b931385d72cf5669fcefc51cdf65990efa5d
    Date: 2020-09-10T17:39:53.251Z
    Electron: 9.2.1
    Chrome: 83.0.4103.122
    Node.js: 12.14.1
    V8: 8.3.110.13-electron.0
    OS: Darwin x64 19.6.0
    
  2. Ian Chamberlain Account Deactivated

    After upgrading, I no longer see "fetching pull request details failed". However, I still do not have any PRs showing in my "pull requests created by me" filter, nor in the "pull requests to be reviewed" filter (both should have at least a few entries).

    The only thing in the logs is this:

    [2020-09-17 19:13:53:868] Atlassian for VS Code (v2.8.1) activated in 37 ms 
    [2020-09-17 19:13:57:034] Error getting URL: https://bitbucket.128technology.com/rest/mirroring/1.0/mirrorServers?limit=100  [object Object]
    [2020-09-17 19:13:58:394] Atlassian for VS Code upgraded from v2.8.0 to v2.8.1 
    

    For what it's worth, that mirroring URL seems to be disabled because my organization does not have a Bitbucket data center license.

    Should I open a separate issue for this, or should this one be reopened?

  3. Log in to comment