PR comments not visible in file

[Vladislav Kosev]

Description

After adding a comment (in VS Code) to a changed file in a PR, the added comment is not visible in the file. The presence of comments is noted in the tree, but not in the editor:

The comment is visible on the Bitbucket website (so it’s successfully added). On file open, the console is reporting the following error:

TypeError: Right-hand side of 'instanceof' is not an object
    at pt (vscode-file://vscode-app/root/.vscode-server/extensions/atlassian.atlascode-2.10.1/build/extension/extension.js:1)
    at ut (vscode-file://vscode-app/root/.vscode-server/extensions/atlassian.atlascode-2.10.1/build/extension/extension.js:1)
    at Zn (vscode-file://vscode-app/root/.vscode-server/extensions/atlassian.atlascode-2.10.1/build/extension/extension.js:1)
    at Zn (vscode-file://vscode-app/root/.vscode-server/extensions/atlassian.atlascode-2.10.1/build/extension/extension.js:1)
    at Jn (vscode-file://vscode-app/root/.vscode-server/extensions/atlassian.atlascode-2.10.1/build/extension/extension.js:1)
    at Ae (vscode-file://vscode-app/root/.vscode-server/extensions/atlassian.atlascode-2.10.1/build/extension/extension.js:1)
    at Fe.insertToken (vscode-file://vscode-app/root/.vscode-server/extensions/atlassian.atlascode-2.10.1/build/extension/extension.js:1)
    at nt (vscode-file://vscode-app/root/.vscode-server/extensions/atlassian.atlascode-2.10.1/build/extension/extension.js:1)
    at on (vscode-file://vscode-app/root/.vscode-server/extensions/atlassian.atlascode-2.10.1/build/extension/extension.js:1)
    at Le (vscode-file://vscode-app/root/.vscode-server/extensions/atlassian.atlascode-2.10.1/build/extension/extension.js:1)
    at Object.parse (vscode-file://vscode-app/root/.vscode-server/extensions/atlassian.atlascode-2.10.1/build/extension/extension.js:1)
    at Object.t.createDocument (vscode-file://vscode-app/root/.vscode-server/extensions/atlassian.atlascode-2.10.1/build/extension/extension.js:1)
    at go.parseFromString (vscode-file://vscode-app/root/.vscode-server/extensions/atlassian.atlascode-2.10.1/build/extension/extension.js:1)
    at new wo (vscode-file://vscode-app/root/.vscode-server/extensions/atlassian.atlascode-2.10.1/build/extension/extension.js:1)
    at Bo.turndown (vscode-file://vscode-app/root/.vscode-server/extensions/atlassian.atlascode-2.10.1/build/extension/extension.js:1)
    at Xp.<anonymous> (vscode-file://vscode-app/root/.vscode-server/extensions/atlassian.atlascode-2.10.1/build/extension/extension.js:1)
    at Generator.next (<anonymous>)
    at vscode-file://vscode-app/root/.vscode-server/extensions/atlassian.atlascode-2.10.1/build/extension/extension.js:1
    at new Promise (<anonymous>)
    at Hp (vscode-file://vscode-app/root/.vscode-server/extensions/atlassian.atlascode-2.10.1/build/extension/extension.js:1)
    at Xp.createVSCodeComment (vscode-file://vscode-app/root/.vscode-server/extensions/atlassian.atlascode-2.10.1/build/extension/extension.js:1)
    at Xp.<anonymous> (vscode-file://vscode-app/root/.vscode-server/extensions/atlassian.atlascode-2.10.1/build/extension/extension.js:1)
    at Generator.next (<anonymous>)
    at vscode-file://vscode-app/root/.vscode-server/extensions/atlassian.atlascode-2.10.1/build/extension/extension.js:1
    at new Promise (<anonymous>)
    at Hp (vscode-file://vscode-app/root/.vscode-server/extensions/atlassian.atlascode-2.10.1/build/extension/extension.js:1)
    at vscode-file://vscode-app/root/.vscode-server/extensions/atlassian.atlascode-2.10.1/build/extension/extension.js:1
    at Array.forEach (<anonymous>)
    at Xp.provideComments (vscode-file://vscode-app/root/.vscode-server/extensions/atlassian.atlascode-2.10.1/build/extension/extension.js:1)
    at vscode-file://vscode-app/root/.vscode-server/extensions/atlassian.atlascode-2.10.1/build/extension/extension.js:1
    at Generator.next (<anonymous>)
    at vscode-file://vscode-app/root/.vscode-server/extensions/atlassian.atlascode-2.10.1/build/extension/extension.js:1
    at new Promise (<anonymous>)
    at qr (vscode-file://vscode-app/root/.vscode-server/extensions/atlassian.atlascode-2.10.1/build/extension/extension.js:1)
    at Array.Hr.qr.diffArgs (vscode-file://vscode-app/root/.vscode-server/extensions/atlassian.atlascode-2.10.1/build/extension/extension.js:1)
    at vscode-file://vscode-app/root/.vscode-server/extensions/atlassian.atlascode-2.10.1/build/extension/extension.js:1
    at Generator.next (<anonymous>)
    at vscode-file://vscode-app/root/.vscode-server/extensions/atlassian.atlascode-2.10.1/build/extension/extension.js:1
    at new Promise (<anonymous>)
    at Ut (vscode-file://vscode-app/root/.vscode-server/extensions/atlassian.atlascode-2.10.1/build/extension/extension.js:1)
    at vscode-file://vscode-app/root/.vscode-server/extensions/atlassian.atlascode-2.10.1/build/extension/extension.js:1
    at r._executeContributedCommand (vscode-file://vscode-app/root/.vscode-server/bin/899d46d82c4c95423fb7e10e68eba52050e30ba3/out/vs/server/remoteExtensionHostProcess.js:95)
    at r._doExecuteCommand (vscode-file://vscode-app/root/.vscode-server/bin/899d46d82c4c95423fb7e10e68eba52050e30ba3/out/vs/server/remoteExtensionHostProcess.js:95)
    at r.executeCommand (vscode-file://vscode-app/root/.vscode-server/bin/899d46d82c4c95423fb7e10e68eba52050e30ba3/out/vs/server/remoteExtensionHostProcess.js:95)
    at g._executeConvertedCommand (vscode-file://vscode-app/root/.vscode-server/bin/899d46d82c4c95423fb7e10e68eba52050e30ba3/out/vs/server/remoteExtensionHostProcess.js:95)
    at r._executeContributedCommand (vscode-file://vscode-app/root/.vscode-server/bin/899d46d82c4c95423fb7e10e68eba52050e30ba3/out/vs/server/remoteExtensionHostProcess.js:95)
    at r.$executeContributedCommand (vscode-file://vscode-app/root/.vscode-server/bin/899d46d82c4c95423fb7e10e68eba52050e30ba3/out/vs/server/remoteExtensionHostProcess.js:95)
    at t._doInvokeHandler (vscode-file://vscode-app/root/.vscode-server/bin/899d46d82c4c95423fb7e10e68eba52050e30ba3/out/vs/server/remoteExtensionHostProcess.js:99)
    at t._invokeHandler (vscode-file://vscode-app/root/.vscode-server/bin/899d46d82c4c95423fb7e10e68eba52050e30ba3/out/vs/server/remoteExtensionHostProcess.js:99)
    at t._receiveRequest (vscode-file://vscode-app/root/.vscode-server/bin/899d46d82c4c95423fb7e10e68eba52050e30ba3/out/vs/server/remoteExtensionHostProcess.js:99)
    at t._receiveOneMessage (vscode-file://vscode-app/root/.vscode-server/bin/899d46d82c4c95423fb7e10e68eba52050e30ba3/out/vs/server/remoteExtensionHostProcess.js:99)
    at vscode-file://vscode-app/root/.vscode-server/bin/899d46d82c4c95423fb7e10e68eba52050e30ba3/out/vs/server/remoteExtensionHostProcess.js:99
    at u.fire (vscode-file://vscode-app/root/.vscode-server/bin/899d46d82c4c95423fb7e10e68eba52050e30ba3/out/vs/server/remoteExtensionHostProcess.js:66)
    at r.fire (vscode-file://vscode-app/root/.vscode-server/bin/899d46d82c4c95423fb7e10e68eba52050e30ba3/out/vs/server/remoteExtensionHostProcess.js:74)
    at vscode-file://vscode-app/root/.vscode-server/bin/899d46d82c4c95423fb7e10e68eba52050e30ba3/out/vs/server/remoteExtensionHostProcess.js:114
    at u.fire (vscode-file://vscode-app/root/.vscode-server/bin/899d46d82c4c95423fb7e10e68eba52050e30ba3/out/vs/server/remoteExtensionHostProcess.js:66)
    at r.fire (vscode-file://vscode-app/root/.vscode-server/bin/899d46d82c4c95423fb7e10e68eba52050e30ba3/out/vs/server/remoteExtensionHostProcess.js:74)
    at n._receiveMessage (vscode-file://vscode-app/root/.vscode-server/bin/899d46d82c4c95423fb7e10e68eba52050e30ba3/out/vs/server/remoteExtensionHostProcess.js:74)
    at vscode-file://vscode-app/root/.vscode-server/bin/899d46d82c4c95423fb7e10e68eba52050e30ba3/out/vs/server/remoteExtensionHostProcess.js:74
    at u.fire (vscode-file://vscode-app/root/.vscode-server/bin/899d46d82c4c95423fb7e10e68eba52050e30ba3/out/vs/server/remoteExtensionHostProcess.js:66)
    at w.acceptChunk (vscode-file://vscode-app/root/.vscode-server/bin/899d46d82c4c95423fb7e10e68eba52050e30ba3/out/vs/server/remoteExtensionHostProcess.js:74)
    at vscode-file://vscode-app/root/.vscode-server/bin/899d46d82c4c95423fb7e10e68eba52050e30ba3/out/vs/server/remoteExtensionHostProcess.js:74
    at u.fire (vscode-file://vscode-app/root/.vscode-server/bin/899d46d82c4c95423fb7e10e68eba52050e30ba3/out/vs/server/remoteExtensionHostProcess.js:66)
    at s._processReadQueue (vscode-file://vscode-app/root/.vscode-server/bin/899d46d82c4c95423fb7e10e68eba52050e30ba3/out/vs/server/remoteExtensionHostProcess.js:114)
    at s.acceptFrame (vscode-file://vscode-app/root/.vscode-server/bin/899d46d82c4c95423fb7e10e68eba52050e30ba3/out/vs/server/remoteExtensionHostProcess.js:114)
    at p._acceptChunk (vscode-file://vscode-app/root/.vscode-server/bin/899d46d82c4c95423fb7e10e68eba52050e30ba3/out/vs/server/remoteExtensionHostProcess.js:114)
    at vscode-file://vscode-app/root/.vscode-server/bin/899d46d82c4c95423fb7e10e68eba52050e30ba3/out/vs/server/remoteExtensionHostProcess.js:114
    at Socket.A (vscode-file://vscode-app/root/.vscode-server/bin/899d46d82c4c95423fb7e10e68eba52050e30ba3/out/vs/server/remoteExtensionHostProcess.js:114)
    at Socket.emit (events.js:315)
    at addChunk (internal/streams/readable.js:309)
    at readableAddChunk (internal/streams/readable.js:284)
    at Socket.Readable.push (internal/streams/readable.js:223)
    at TCP.onStreamRead (internal/stream_base_commons.js:188)

System info

Version: 1.63.2 (user setup) (running in a Docker container)
Commit: 899d46d82c4c95423fb7e10e68eba52050e30ba3
Date: 2021-12-15T09:40:02.816Z
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.22000

Jira and Bitbucket (Atlassian Labs): v2.10.1

[Vladislav Kosev]

Forgot to say: Show/hide comments does not seem to do anything.

[da61]

I’m experiencing the same thing

[Julien LIBERT]

Experiences the same for 2 days.

[Sergio Henrique Sampaio]

Experience the same problem here

[Carl Napier-Cook]

Ahh good. It’s not just me.

[Carl Napier-Cook]

Downgrading to “v2.10.0“ worked for me.

[Fabrizzio Andrioli]

Same here…the only thing that’s why i'm using this plugin is not working now.

[Sergio Henrique Sampaio]

@Carl Napier-Cook how did you downgrade?

‌

[Wasa Choksuwattanasakul]

Rollback to v2.10.0 worked for me as well and confirmed that I experience the issue on v2.10.1

FYI, to rollback to v2.10.0, on the extension page, press dropdown next to uninstall and select “install Another version”

‌

[Max Liu]

Same here, v2.10.0 works for me. Thx @Wasa Choksuwattanasakul

[Nick Rundquist]

Vladislav, I’m trying to reproduce this issue but I’m not able to. Are there no comments at all showing up for the file or only certain comments? Is this happening on all PRs?

[Carl Napier-Cook]

@Nick Rundquist

@Nick Rundquist

For me, zero comments were appearing (for a PR that had active, non-out-of-date comments), for all PRs.

This was on 2.10.1. I notice that a 2.10.3 is available now.

[Carl Napier-Cook]

‌

[Vladislav Kosev]

@Nick Rundquist , yes, it happens all the time on all PRs:

1. If you open a file in a PR with comments, no comments would load although the comment icon is visible in the file list.
2. If you add a comment, the comment itself is added, but it is not displayed back in the file after the form disappears.

It is interesting that you can’t reproduce, that means there is some context we’re missing. Did you test inside a Docker container?

[Pavel Dobrý]

Downgrade to 2.10.0 helped. Really annoying regression bug.

[Joshna]

Issue #680 was marked as a duplicate of this issue.

[Offir]

Version 2.10.3 still having this issue

[Nick Rundquist]

Okay, I’m seeing this now. Apparently it doesn’t happen when running in the debugger. I’m working on tracking down what changed caused this to break.

[Nick Rundquist]

I’ve just released version 2.10.5 which should fix this issue. Let me know if you’re still having problems.

[David Bohan]

@Nick Rundquist

I am unable to view a PR that has a comment on it.

If there are no comments, the PR loads just fine, but if a comment has been added I now get a white screen.

[Geoff Wild]

This is working for me now. Thanks!

[Tony Kirker]

Working again here too. Thanks!

[Carl Napier-Cook]

@Nick Rundquist
Thank you, muchly.

[Mike Bailey]

@Nick Rundquist comments within files does appear to be fixed (thanks!). If there is a comment on the PR itself, the PR details do not display. Could it possibly be a similar fix?

[Nick Rundquist]

For those commenting that they can’t see PR details, it’s likely that you’re encountering issue #612. I’ve released a fix for this but if you’re still having issues follow up there.

[Eilon Cohen]

This issue regressed in version 3.0.4

[John Boone]

This issue is happening for me, all the same symptoms as above.

[高欣平(Justin Kao)]

so fucked up man, why re occur

[高欣平(Justin Kao)]

@Admin Admin

[Maxime Gendreau]

This is still a bug. It was fixed then it started again a couple of month ago.

[Paulo Victor Alvares]

This is still a bug, extension version 3.0.7, vscode version 1.84.2

vscode details:

Version: 1.84.2
Commit: 1a5daa3a0231a0fbba4f14db7ec463cf99d7768e
Date: 2023-11-09T10:50:47.800Z
Electron: 25.9.2
ElectronBuildId: 24603566
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: 11.4.183.29-electron.0
OS: Linux x64 6.2.0-36-generic snap

‌