Regression when parsing git url between 2.X and 3.X

Issue #920 new
Derek Morgan created an issue

It looks like there is a regression in parsing the git url between the 2.X and 3.X versions of the VS Code plugin which is preventing Bitbucket integration. The new version is including the port in the host value which is preventing it from matching with the registered Bitbucket instance.

Version 2.10.12:

Output of Show Bitbucket Sites Info:

{
    "bitbucketSites": [
        {
            "name": "my.bitbucket.selfhosted.url",
            "host": "my.bitbucket.selfhosted.url",
            "type": "server",
            "mirrors": [
                "mymirror"
            ]
        }
    ],
    "vscodeWorkspaceRepositories": [
        {
            "uri": "file:///my/file/path/my.bitbucket.selfhosted.url/<owner>/<repo>",
            "remotes": [
                {
                    "name": "origin",
                    "url": "ssh://git@my.bitbucket.selfhosted.url:7999/<owner>/<repo>.git",
                    "host": "my.bitbucket.selfhosted.url",
                    "matchingBitbucketSite": "my.bitbucket.selfhosted.url"
                }
            ]
        }
    ]
}

Version 3.0.2:

Output of Show Bitbucket Sites Info:

{
    "bitbucketSites": [
        {
            "name": "my.bitbucket.selfhosted.url",
            "host": "my.bitbucket.selfhosted.url",
            "type": "server",
            "mirrors": [
                "mymirror"
            ]
        }
    ],
    "vscodeWorkspaceRepositories": [
        {
            "uri": "file:///my/file/path/my.bitbucket.selfhosted.url/<owner>/<repo>",
            "remotes": [
                {
                    "name": "origin",
                    "url": "ssh://git@my.bitbucket.selfhosted.url:7999/<owner>/<repo>.git",
                    "host": "my.bitbucket.selfhosted.url:7999",
                    "matchingBitbucketSite": "Not found"
                }
            ]
        }
    ]
}

Comments (0)

  1. Log in to comment