Fixes issue #2 - eliminate getAllDeploymentProjects lookup with autocomplete against rest api
- Repository
-
eddiewebb
- Branch
- issue-2-non-admin-performance
- Repository
-
atlassianlabs
- Branch
- master
- Author
- Reviewers
-
- Description
-
Fixes issue
#2by eliminating getAllDeploymentProjects lookup with autocomplete against rest api-
Uses bamboos quicksearch api to dynamically load deployment project as user types
-
removed deploymentProjects list from configurator class, but now passes existing name if set to pre-load dropdown on edit.
-
With these changes I saw no distinction between needs of ..ForEdit and ..ForView, so they both call the same shared methods to populate project ID & Name, and Environment list &ID
(I also updated to bamboo 6.3 so I could use specs to pre-populate large volume of deploys, and eliminated fastdev/cli in favor of new quickreload approach, but neither is important to the functionality at hand)
-
- Security Assistant
-
- #2: Performance degradation for non-admin users resolved
- Checking for dependencies...
- Checking for dependents...
Comments (8)
Pull request updated. Reload
Hi @Eddie Webb , thanks for your contribution. I'm happy to review this submission and get it merged into main repo, but I would need you to sign electronically the Contributor License Agreement (CLA) before I can accept this pull request. Go to https://developer.atlassian.com/opensource/ please, find the "Contributors License Agreement" section and fill appropriate CLA (individual in your case I suppose it would be) please.
CLA signed. Also pushed import change you noted below (intellij automatically uses asterisk is more than a few are declared)
Thank you, I'll ask our legal department to confirm CLA signed before proceeding.
Asterisk import is known issue, we have to change default IntelliJ configuration as part of onboarding process
I'll look at it on Monday, I need to test it locally but it looks like it search on build projects as well
Yes, your right, it will. I can add JS side logic to filter it out while your legal team confirms. It still proved faster to use the lucene index than using the DeploymentProjectDao's string search.
The validation errors when a build is picked (since it can't find environments) and also on save as invalid project ID.
Edit . Fixed, see comment below
HI @Alexey Chystoprudov , I hope you found the additional filtering to eliminate non-deployment results suitable, please let me know if you have additional concerns.
@Eddie Webb , sorry for delay. I'm on vacation till next week. Want to test if pagination works correctly when return back and accept this PR.
@Alexey Chystoprudov there is no pagination as it stands. Because we are using the quicksearch REST api we are limited to the single method exposed by https://docs.atlassian.com/atlassian-bamboo/6.3.1/com/atlassian/bamboo/index/quicksearch/QuickSearchSearcher.html which returns 12 results for the current term matching user permissions. (waits for at least 3 characters, searching every change thereafter)
I took a look at leveraging the https://docs.atlassian.com/atlassian-bamboo/6.3.1/com/atlassian/bamboo/index/IndexerService.html but would end up duplicating so much of the code from quicksearcherimpl. The other option is to use the deploymentProjectDao and query directly against the DB, exposing our own summary results but both seemed to outweigh the benefit of infinite scrolling when the user can just keep modifying their entry to get a more targeted list
Anyway, let me know your thoughts and I can poke down either path as you see fit.