Can't deploy to recent versions of fecru because of a POST request redirect

[Lukasz Pater]

28-Feb-2014 05:22:55    Starting plugin deployment task (v. 2.0.9)
28-Feb-2014 05:22:55    SSL Certificate check: enabled
28-Feb-2014 05:22:56    Product login failed. HTTP Status code 302 was returned.
28-Feb-2014 05:22:56    Product login failed. HTTP Status code 302 was returned.

The login seems to be successful, but the redirect is not followed automatically by httpclient, because DefaultRedirectStrategy only follows redirect for GETs (DefaultRedirectStrategy#isRedirected)

[Lukasz Pater]

@jaysee00 - I want to fix this by bumping httpclient to 4.2 and using LaxRedirectStrategy by default. Does that sound fine to you?

[Joe Clark]

@lpater - Changing the HttpClient behaviour may break the AtlassianIdWebSudoRequestBehaviour - which deliberately does not follow redirects.

Instead you could add an override for the handleResponse method in FeCruLoginRequestBehaviour such that it allows the HTTP 302 status code as an indication of login success.

[Joe Clark]

Fixed in https://bitbucket.org/atlassianlabs/bamboo-continuous-plugin-deployment/commits/12b7fa1671ccb7e537f7add34b30e9ab0a68db2c

[Lukasz Pater]

Works fine now (using the new 'deploy plugin' task). Thanks a lot!