NPE on transformBuildDefinition

[Elias Zeidan (they/them)]

Summary

PriorityConfigurationTransformer.java - The boolean method isCanEdit() can return a NULL value, causing a NullPointerException on transformBuildDefinition()

This is causing some builds to fail.

Expected Results

The build continues as normal.

Actual Results

The below exception is thrown in the atlassian-bamboo.log file:

2017-05-15 17:23:17,505 ERROR [0-BAM::agent-name::Agent:pool-3-thread-1] [BuildAgentControllerImpl] Unknown exception occurred on 'agent-name'. Agent will attempt to recover its normal operation...
com.thoughtworks.xstream.converters.ConversionException: 
---- Debugging information ----
cause-exception     : java.lang.NullPointerException
cause-message       : null
class               : com.atlassian.bamboo.build.DefaultBuildDefinition
required-type       : com.atlassian.bamboo.build.DefaultBuildDefinition
converter-type      : com.atlassian.bamboo.serialization.xstream.BuildDefinitionXStreamConverter
path                : /org.springframework.remoting.support.RemoteInvocationResult/value/parentBuildContext/buildDefinition
line number         : 103
class[1]            : com.atlassian.bamboo.v2.build.BuildContextImpl
converter-type[1]   : com.atlassian.bamboo.serialization.xstream.BuildContextXStreamConverter
class[2]            : org.springframework.remoting.support.RemoteInvocationResult
converter-type[2]   : com.thoughtworks.xstream.converters.reflection.ReflectionConverter
version             : not available
-------------------------------
...
Caused by: java.lang.NullPointerException
    at com.atlassianlab.bamboo.plugins.queuepriority.PriorityConfigurationTransformer.isCanEdit(PriorityConfigurationTransformer.java:35)
    at com.atlassianlab.bamboo.plugins.queuepriority.PriorityConfigurationTransformer.transformBuildDefinition(PriorityConfigurationTransformer.java:25)
    at com.atlassian.bamboo.fieldvalue.BuildDefinitionConverter.copyConfigurationToDefinition(BuildDefinitionConverter.java:201)
    at com.atlassian.bamboo.serialization.xstream.BuildDefinitionXStreamConverter.unmarshal(BuildDefinitionXStreamConverter.java:58)
    at com.thoughtworks.xstream.core.TreeUnmarshaller.convert(TreeUnmarshaller.java:72)
    ... 45 more

Workaround

There is currently no known workaround. Please disable the plugin.

[Abdoulaye Tall]

Ok thank for your response. By uninstalling the plugin, everything is back to normal. Is there any plugin equivalent to "Bamboo Queue Priority" which will set the queue priority without crashing bamboo ? Or maybe a configuration instructions ?

[Alexey Chystoprudov]

fixed in release 0.3