CONTRIBUTING.md not being rendered in pull requests

Issue #2 resolved
Luciano Deriu created an issue

I've installed the add-on to a team account, added the CONTRIBUTING.md to the root of a mercurial repo with the same content as in the example (https://prguidelines.useast.atlassian.io/) and the file is in the default branch as well.

In a pull request the guidlines link is visible but when i click it i get a blank modal. See attached image.

Also i'm using the latest stable version of chrome and there are no errors in the dev tools.

Comments (16)

  1. Abhin Chhabra Account Deactivated

    Hi Luciano,

    I apologize for issues. I'll try to replicate the problem and report back.

    Abhin

  2. Luciano Deriu reporter

    Thank you! It would be great to start using this feature for our teams.

    FYI, i did also try this with a Git repo but didn't work either.

  3. Abhin Chhabra Account Deactivated

    Hi Luciano,

    I've recently updated the way the markdown is parsed. You can probably see that for yourself since I also recently open-sourced the add-on. Can you please try again and let me know if the add-on renders correctly?

    Abhin

  4. Luciano Deriu reporter

    Also, we are using the cloud version of bitbucket. So not sure how we get a new version of the add-on installed. Is it automatically updated?

  5. Abhin Chhabra Account Deactivated

    I haven't seen a traceback in the logs, so that's a bit concerning. You should be able to try reinstalling the add-on by going to the account's settings page (the account onto which the addon was installed) and choosing "Manage add-ons", expanding the "Pull request guidelines" add-on and hitting "remove".

    Once that is done, you should be able to try reinstalling through the "Find new add-ons" or by hitting the install button on https://prguidelines.atlassian.io/

    I also noticed that you were using https://prguidelines.useast.atlassian.io/ in your description, which is different from the official URL (https://prguidelines.atlassian.io/), but also works. Using a different URL could possible mess with the OAuth permissions, so it would be great to try reinstalling as per the above instructions.

    Please let me know the result of the reinstall.

  6. Luciano Deriu reporter
    • changed status to open

    @abhin i've just tried this again but still having no luck in getting it to display anything.

    Is there anything i can do to provide you with more information? Cheers

  7. Bill Bagdon

    Does the CONTRIBUTING.md file need to be on the "main branch"?

    I still see the "Get started with a CONTRIBUTING.md file" on a pull request adding CONTRIBUTING.md

  8. Abhin Chhabra Account Deactivated

    @luciano_cloudpay Sorry for the delayed response. I'll take a look at this issue this week and see what we can do.

  9. Abhin Chhabra Account Deactivated

    @bbagdon: the CONTRIBUTING.md file needs to be on the target branch of the PR. It would not (and should not) be based on the source branch.

  10. Luciano Deriu reporter

    That would be great, thank you. Let me know if there is anything i can do to help. Thanks

  11. Paresh Mayani

    I am experiencing the same, I have included CONTRIBUTING.md in master and developer both branches.

  12. Log in to comment