Use Application Link's Display URL instead of RPC URL in responses

Issue #12 new
Marek Parfianowicz created an issue

See BAM-18291. The StashClient returns URLs for: * projects - StashClient#getAccessibleProjects - Project.getSelfUrl * repositories - StashClient#getRepositories, StashClient#getRepository - Repository.getSelfUrl * pull requests - StashClient#getPullRequestsByRepository - PullRequestStatus.getUrl

These URLs use the RPC URL from the configured application link instead of the Display URL.

Using RPC URL instead of Display URL may cause troubles with SAML authentication as cookies are being registered for a wrong domain.

Steps to reproduce: * set up Bamboo and Bitbucket Server * connect them with an application link, use display URL != RPC URL for BBS * set up SAML for Bamboo and BBS * log into Bamboo, create a plan with BBS repository * try to click "create pull request" link in Bamboo - it redirects to BBS with RPC URL, authentication fails with an error - we would expect seamless authentication here

Note: * the SSH Clone URL and HTTP Clone URL for Repository shall not be modified (the most probably)

Comments (0)

  1. Log in to comment