revid: reduce log severity for ringBuffer write errors

[Alan Noble]

The following warning occurs extremely frequently at times, creating enormous log files.

{"level":"warn","time":"2019-08-07T15:36:07.158+0930","caller":"revid/senders.go:237","message":"revid:mtsSender: ringBuffer write error","error":"ring: write to long for buffer element"}

This kind of output should be “info” not “warn”.

PS Also fix the typo: “to long” → “too long”

[Saxon Milton]

Do you think this should really be Info ? I think it’s quite bad if a frame can’t fit in the ringBuffer. I think if we’re worried about the verbosity we should fix the logger instead (it was supposed to handle things like this).

[Alan Noble]

I agree the logger should handle it, but alas it doesn’t. Until then the client will need to restrict its verbosity because we are creating very large log files.

[Saxon Milton]

The logger has been fixed and now suppresses output so no need to fix log level.