device: add IsRunning method to AVDevice interface
Issue #231
resolved
This proposal has been motivated by Revid’s redundant logs indicating that an input device has been stopped when not running (whether because hasn’t been started yet, or because already stopped). It might be better if we write a non exported method for Revid that wraps the stopping process for devices. It would firstly check if the device is running, and if so, Stop the device, and if not, do nothing and return nil.
To do this we require that the AVDevice interface provides a way to if the device is running or not. Hence the proposal for a new IsRunning() method.
Comments (4)
-
-
reporter Yes maybe IsRunning()
-
reporter - edited description
- changed title to device: add IsRunning method to AVDevice interface
-
reporter - changed status to resolved
Resolved in PR #363
- Log in to comment
SGTM. Should it be called Running() or IsRunning() though?