rtmp: test failing due to short FLV header tag being passed to rtmp.Conn.Write
Issue #39
resolved
No description provided.
Comments (12)
-
-
reporter
Yes, it's the same issue. Yes, the sender should deal with it, not the rtmp package. Ignore the rtmp prefix in the issue title.
There is a specific part of the test that tests this (and that is fine), but it is TestFromFile that is failing and that is not fine. If incorrectly fails during encoder creation.
-
reporter
Please run the rtmp test for yourself to see what I mean.
-
@scruzin yep i'll have a look
-
@scruzin should be on master or another branch? because just tried on master and the test passes.
-
@scruzin ping
-
reporter
I'm on the rtmp-refactoring-4 branch.
-
reporter
You need to set RTMP_TEST_FILE to betterInput.h264 too. The single frame test passes.
-
@scruzin ahh right
-
@scruzin I've pushed to the same branch, is this okay ?
-
reporter
Yes, tested and passing. Will close this issue.
-
reporter
- changed status to resolved
Fixed and working. Tests all pass.
- Log in to comment
@scruzin is this the same issue Dan, you and I were discussing in the email - where we concluded the rtmp sender will deal with the error ? If this is the case, then in this instance, should the test just expect this ?