exp/rvcl: panics and will not run

[Trek Hopton]

rvcl panics when it runs, giving:

[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x323614]

goroutine 1 [running]:
bitbucket.org/ausocean/iot/pi/netsender.(*Sender).Init(0x246aaf0, {0xad5c68c8, 0x246e480}, 0x0, 0x0, 0x0, {0x24a5f88, 0x1, 0x1})
    /home/pi/go/pkg/mod/bitbucket.org/ausocean/iot@v1.4.1/pi/netsender/netsender.go:268 +0x120
bitbucket.org/ausocean/iot/pi/netsender.New(...)
    /home/pi/go/pkg/mod/bitbucket.org/ausocean/iot@v1.4.1/pi/netsender/netsender.go:250
main.main()
    /home/pi/go/src/bitbucket.org/ausocean/av/exp/rvcl/main.go:210 +0x6c4

This is because on line 268 of netsender.go, option functions are called. In rvcl’s main.go a nil option is passed to netsender.New. This is obviously a mistake and since rvcl is experimental, it hasn’t been run in a while and testing doesn’t yet exist to catch bugs like this.

We need to remove that nil option.

[Saxon Milton]

Why is a nil option passed in the first place ?

[Trek Hopton]

My guess would be that whoever implemented options as an argument made a mistake and didn’t test rvcl. It’s clearly not supposed to be there.

[Trek Hopton]

Resolved in PR #521