revid-cli: incorrectly includes V0 query param in /poll request

[Alan Noble]

NetReceiver /poll requests should not include V(video) or S(ound) pins. The latter are only supported by the /recv method.

The following was sent by tagged version v.1.2.3:

GET /poll?vn=141&ma=B8:27:EB:92:77:FE&dk=13533341&V0=-1&X20=52&X21=37

PS NetReceiver ignores such requests, but it results in unnecessary logging.

[Alan Noble]

Related point:

NetReceiver input pins should determine what revid-cli (and other clients) send. This applies to all pins, not just X pins. In other words, if no V0 pin is present, revid-cli should not send on video channel 0 (i.e., the default video channel).

Furthermore, a single revid-cli will eventually support multiple video and sound channels. For example, V0,S0,S1 would represent 1 video channels and 2 sound channels. Removing specific pins from the inputs enables fine-grained control over what is sent. In the above example, removing V0 from the inputs would only stop video streaming; sound streaming would continue. When only one pin is present, such as V0, removing that pin from the inputs, is equivalent to pausing revid-cli.

[Saxon Milton]

Might you know how this is happening Alan ? I can't see where I'm causing this in the code. The only place I mention V0 is in netsender.conf.

[Alan Noble]

I think it is happening inside ns.Run(). We may need to make it smarter.

[Alan Noble]

This is an issue with netsender.Run, not revid-cli.