vs missing in response to video request

Alan Noble

The varsum (vs) is not supposed to be included in video requests, since it is an expensive operation. So this is a client issue, not a NetReceiver issue.

2018-11-30T06:40:19+00:00

Saxon Milton reporter

Apologies if It seemed I implied the problem lies in net-receiver - I actually thought it might be either netreceiver or netsender. From another look, I believe it might be an edit Jack and I made to netsender that was not thought out enough. We didn't consider the following in netsender.go:Send()

// extract var sum, which should be an integer, except when returned with vars
    var vs int
    if requestType == RequestVars {
        var val string
        val, err = extractJsonString(reply, "vs")
        if err != nil {
            return reply, reconfig, errors.New("vs missing")
        }
        vs, err = strconv.Atoi(val)
        if err != nil {
            return reply, reconfig, errors.New("vs not an integer")
        }
    } else {
        vs, err = extractJsonInt(reply, "vs")
        if err != nil {
            return reply, reconfig, errors.New("vs missing")
        }
    }

because we're using "RequestVideo" we're hitting the else, so the vs is wrongly being checked. I can have a go at fixing ?

2018-11-30T07:27:00+00:00

Jack Richardson

We added in a request type called RequestVideo that used the /send URL for video (this might get changed in a PR). In the above mentioned code snippet we could change the else statement to be:

} else {
    if requestType != RequestVideo {
            vs, err = extractJsonInt(reply, "vs")
            if err != nil {
                return reply, reconfig, errors.New("vs missing")
            }
    }
}

This will avoid the check. If you're happy with this I'll make the change.

2018-12-01T04:41:08+00:00

Alan Noble

The fix needs to be more general than that, since it is not just video requests that skip the varsum, but all requests for "vector data" (i.e., data that is more than a single scalar/number).

What I had in mind is that scalar data (A, D, X) continue to use /poll while vector data (V, B, T) use the new /recv.

Vidgrind already implements /recv, but I need to back port it to NetReceiver.

So: - Generalize RequestVideo to RecquestRecv - And use /recv for V, B, and T data