netsender: error from pin read fail not handled

[Emily Braggs]

On line 252 an error is generated but the pin read error is ignored.

for i, pin := range pins {
    pins[i].Value, err = ns.read(pin.Name)
}

Could we either return this or log the error?

[kortschak]

Thanks for filing this. I noticed it the other day when I was helping Jack through the errors he was seeing with the tests, but then proceeded to forget.

[Alan Noble]

Logging is preferable. We don't want to return an error just because one pin read failed (out of possibly several pins which were fine). The pin read function must return -1 in the event of an error though.

[Alan Noble]

Fixed in https://bitbucket.org/ausocean/iot/commits/51db7a4886ff5831dce9fe4198654ee22846f969