Isolate electrolyte model calculations into subfunction(s)
Issue #8
resolved
The calculation of the dxvec
, dxd1
, dxd2
length vectors, the porosvec
and poros_edges
vectors should all be moved to separate functions (within a geometry module).
The ("optional" -- if it's not a single-volume simulation) application of the c
/phi
boundary conditions should be placed within the main DeclareEquations
function.
Then, the actual calculation of the RHS for the species and charge conservation equations should be its own function as well which should be called from plot_data.py
(so it should take parameters as input and not refer to self.ndD
).
Comments (2)
-
reporter -
reporter - changed status to resolved
Merged in elyte-refactor-and-generalize (pull request #37)
Plot script now uses elyte flux functions. Finish fixing issue
#8.→ <<cset adf8a030b6ee>>
- Log in to comment
Merged in elyte-refactor-and-generalize (pull request #36)
Elyte refactor and generalize, Fix issue
#33, see issue#8→ <<cset b216172bf214>>