(sifrah) crash with beta sifrah water ceremony

[Adam Lang]

Not sure if I should be avoiding mods until you’re out of beta or something, but I have the current beta (App ID: 333640, Build ID: 14551658, updated May 30 2024 at 3:29 PM). When I do a water ceremony with Sifrah (tried it with the Mayor of Joppa and the joppa farmer dude), the game plays out until I’m finished, and then it just stops. It isn’t obvious what’s going on… it doesn’t seem like an infinite loop, the CPU usage doesn’t trend up or anything. It just doesn’t respond to any keypresses aside from command-q. Says ‘Press space or enter to continue’ but they don’t do anything.

Mods active:

Sifrah

Im attaching a copy of the process sample, though I don’t immediately see anything obvious.

[Brian Bucklew]

sifrah is no longer maintained

[Adam Lang]

Noooo! That’s like a third of the fun of the whole game. :-P

I assume that it is twined too far into the source for someone else (e.g. me) to take over maintaining it?

[John Snail]

If it’s no longer maintained, does that mean it’s getting removed from the source in the future? I always found it strange that Chaos' mods were baked into the game instead of just using Harmony patches, especially with their bugs surfacing in vanilla.

I assume that it is twined too far into the source for someone else (e.g. me) to take over maintaining it?

It could be ported to an actual mod but you’d need a little knowledge of Intermediate Language to inject code in the right places.

[Adam Lang]

I have 25 years of experience in software engineering and I have never heard of ‘Intermediate Language’. It sounds dreadful, but I could probably figure it out. What in the world is it doing in my Mac app? :-P

[Ray]

Issue #12166 was marked as a duplicate of this issue.

[Gokudera ElPsyCongroo]

@Adam Lang The Intermediate Language method John is evoking is effectively akin to patching the game with ASM. Harmony provides such patching capabilities: https://harmony.pardeike.net/articles/patching-transpiler.html

But I think that in theory, you could patch Sifrah even it being base game code by outright replacing its entire bugged methods with Harmony Prefixes, though I haven’t looked into it much https://harmony.pardeike.net/articles/patching-prefix.html

If you want to try, the Qud modding tutorial in the wiki is a solid start https://wiki.cavesofqud.com/wiki/Modding:C_Sharp_Scripting

[Adam Lang]

Thanks for the info. When I have some time on my hands I’ll look into it. If anyone else wants to play with it first, obviously, by all means, go for it.