[#modding] also, there should be some indication in the build_log.txt when applying harmony...

Issue #4010 resolved
Freehold Games Bot Account created an issue

Marked for crossposting by: autumn, waveform worm

Message (jump):

<Apollo (they) | Kizby> also, there should be some indication in the build_log.txt when applying harmony patches fails and the mod overall should fail to load, rather than the current behavior of adding the non-harmony parts of the mod with no indication anything is wrong

Comments (5)

  1. Armithaig

    Harmony doesn't expose its logging or errors for us to stream into the build log or otherwise react to.

    Use the HarmonyDebug attribute or HARMONY_DEBUG environment variable and consult harmony.log.txt in the save directory when developing.

    Don't think many people'd be happy with a blanket failed load either, if you need that much control then'd recommend manual patches with Harmony.Patch in a ModSensitiveCacheInit at which point you can set ModInfo.Settings.Failed yourself to prevent a load.

  2. Athena Washington

    The only errors I care about here are the ones that trigger ApplyHarmonyPatches throwing the “Exception applying harmony patches” error, which y’all do have enough information to report, even if it’s just a “Failed to apply Harmony patches.” or similar in the build log. Without that being reported, the build log just shows successes, which is misleading.

  3. Log in to comment