[#bugs] Stun gas doesn't pass `ParentObject.GetPart<Gas>()` to `GetRespiratoryAgentPerfo...

[Freehold Games Bot Account]

Marked for crossposting by: Noelle Lavenza (transgendeer)

Message (jump):

<Noelle Lavenza (transgendeer)> Stun gas doesn't pass ParentObject.GetPart<Gas>() to GetRespiratoryAgentPerformanceEvent.GetFor() in ApplyStun(), meaning stun gas always has an effective density of zero. Fixing this makes stun gas stun enemies properly.

[Noelle Lavenza]

Supersedes #5342, #3438, #3263.

[Jason Grinblat]

test this out then toss back to me?

[chaos]

Diagnosis is made up. The first thing GetRespiratoryAgentPerformanceEvent.GetFor() does if the Gas part isn’t provided is obtain it from its parent object, which is being provided in this call. Debug logging confirms that the Performance value coming back from the event call is non-zero and varies by gas density.

[Noelle Lavenza]

I forgot to undo a change to stun gas grenade gas density when I was testing this and didn’t remember it was still in, so what I thought was the change was actually just a massively-inflated density, i.e. 1200 instead of 120 for StunGasGrenade3. Oops.

[Ashe]

I’m not sure if stun gas was broken in this specific way, but it definitely was nonfunctional previously: however it now seems to work semifine: it works for stunning, I haven’t been able to trigger QN loss. I have no idea what changed or if this was intentional. Figured it was worth mentioning.

[Jason Grinblat]

Issue #2678 was marked as a duplicate of this issue.

[Jason Grinblat]

Issue #5342 was marked as a duplicate of this issue.

[Jason Grinblat]

Issue #3438 was marked as a duplicate of this issue.

[Jason Grinblat]

Issue #3263 was marked as a duplicate of this issue.