Georg Brandl avatar Georg Brandl committed ce7a3d9

#341: Always generate UNIX newlines in the quickstart Makefile.

Comments (0)

Files changed (2)

 Release 0.6.5 (in development)
 ==============================
 
+* #341: Always generate UNIX newlines in the quickstart Makefile.
+
 * #338: Fix running with ``-C`` under Windows.
 
 * In autodoc, allow customizing the signature of an object where

sphinx/quickstart.py

     if d['makefile']:
         d['rsrcdir'] = d['sep'] and 'source' or '.'
         d['rbuilddir'] = d['sep'] and 'build' or d['dot'] + 'build'
-        f = open(path.join(d['path'], 'Makefile'), 'w')
+        # use binary mode, to avoid writing \r\n on Windows
+        f = open(path.join(d['path'], 'Makefile'), 'wb')
         f.write((MAKEFILE % d).encode('utf-8'))
         f.close()
 
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.