1. Benoit Chesneau
  2. django-authopenid
  3. Issues
Issue #23 resolved

Why on_success and on_failure callbacks?

Anonymous created an issue

Why in views.py those callback functions are used? It seems to me that a simple return in case of success and raising an error in case of failure do the job better. It's hard to pass additional arguments to callbacks (via kwargs), that causes errors like [1]. And control flow gets cluttered.

[1] http://code.google.com/p/django-authopenid/issues/detail?id=54

Sorry, I did not notice that the project moved and posted the bug there. Please make it invalid or so.

Comments (5)

  1. Log in to comment