Commits

Mike Bayer committed f644a6f

- get 100% lint/pep8 happening for test_compiler; next we will begin
cutting up tests and removing old ones
- move test_in() to test_operators
- slice up migrated operator tests into TOT

Comments (0)

Files changed (4)

lib/sqlalchemy/dialects/sybase/__init__.py

 
 from sqlalchemy.dialects.sybase import base, pysybase, pyodbc
 
+# default dialect
+base.dialect = pyodbc.dialect
 
 from base import CHAR, VARCHAR, TIME, NCHAR, NVARCHAR,\
                             TEXT,DATE,DATETIME, FLOAT, NUMERIC,\
                             BIGINT,INT, INTEGER, SMALLINT, BINARY,\
                             VARBINARY,UNITEXT,UNICHAR,UNIVARCHAR,\
-                           IMAGE,BIT,MONEY,SMALLMONEY,TINYINT
+                           IMAGE,BIT,MONEY,SMALLMONEY,TINYINT,\
+                           dialect
 
-# default dialect
-base.dialect = pyodbc.dialect
 
 __all__ = (
      'CHAR', 'VARCHAR', 'TIME', 'NCHAR', 'NVARCHAR',

test/sql/test_compiler.py

 from sqlalchemy.testing import eq_, is_, assert_raises, assert_raises_message
 from sqlalchemy import testing
 from sqlalchemy.testing import fixtures, AssertsCompiledSQL
-import datetime, re, operator, decimal
-from sqlalchemy import *
+from sqlalchemy import Integer, String, MetaData, Table, Column, select, \
+    func, not_, cast, text, tuple_, exists, delete, update, bindparam,\
+    insert, literal, and_, null, type_coerce, alias, or_, literal_column,\
+    Float, TIMESTAMP, Numeric, Date, Text, collate, union, except_,\
+    intersect, union_all, Boolean, distinct, join, outerjoin, asc, desc,\
+    over, subquery
+import datetime
+import operator
+import decimal
 from sqlalchemy import exc, sql, util, types, schema
-from sqlalchemy.sql import table, column, label, compiler
+from sqlalchemy.sql import table, column, label
 from sqlalchemy.sql.expression import ClauseList, _literal_as_text, HasPrefixes
 from sqlalchemy.engine import default
-from sqlalchemy.databases import *
+from sqlalchemy.dialects import mysql, mssql, postgresql, oracle, \
+            sqlite, sybase
 from sqlalchemy.ext.compiler import compiles
 
 table1 = table('mytable',
     Column('rem_id', Integer, primary_key=True),
     Column('datatype_id', Integer),
     Column('value', String(20)),
-    schema = 'remote_owner'
+    schema='remote_owner'
 )
 
 # table with a 'multipart' schema
     Column('rem_id', Integer, primary_key=True),
     Column('datatype_id', Integer),
     Column('value', String(20)),
-    schema = 'dbo.remote_owner'
+    schema='dbo.remote_owner'
 )
 
 users = table('users',
                 'Scalar Select expression has no '
                 'columns; use this object directly within a '
                 'column-level expression.',
-                lambda: hasattr(select([table1.c.myid]).as_scalar().self_group(), 'columns'))
+                lambda: hasattr(
+                        select([table1.c.myid]).as_scalar().self_group(),
+                        'columns'))
             assert_raises_message(
                 exc.InvalidRequestError,
                 'Scalar Select expression has no '
                 'columns; use this object directly within a '
                 'column-level expression.',
-                lambda: hasattr(select([table1.c.myid]).as_scalar(), 'columns'))
+                lambda: hasattr(select([table1.c.myid]).as_scalar(),
+                            'columns'))
         else:
-            assert not hasattr(select([table1.c.myid]).as_scalar().self_group(), 'columns')
+            assert not hasattr(
+                    select([table1.c.myid]).as_scalar().self_group(),
+                            'columns')
             assert not hasattr(select([table1.c.myid]).as_scalar(), 'columns')
 
     def test_prefix_constructor(self):
                             "mytable.description FROM mytable")
 
         self.assert_compile(select([table1, table2]),
-                            "SELECT mytable.myid, mytable.name, mytable.description, "
-                            "myothertable.otherid, myothertable.othername FROM mytable, "
-                            "myothertable")
+                "SELECT mytable.myid, mytable.name, mytable.description, "
+                "myothertable.otherid, myothertable.othername FROM mytable, "
+                "myothertable")
 
     def test_invalid_col_argument(self):
         assert_raises(exc.ArgumentError, select, table1)
             self.assert_compile(
                 select([1]).limit(lim).offset(offset),
                 "SELECT 1 " + exp,
-                checkparams =params
+                checkparams=params
             )
 
     def test_from_subquery(self):
-        """tests placing select statements in the column clause of another select, for the
+        """tests placing select statements in the column clause of
+        another select, for the
         purposes of selecting from the exported columns of that select."""
 
         s = select([table1], table1.c.name == 'jack')
             select(
                 [s],
                 s.c.myid == 7
-            )
-            ,
+            ),
         "SELECT myid, name, description FROM (SELECT mytable.myid AS myid, "
-        "mytable.name AS name, mytable.description AS description FROM mytable "
+        "mytable.name AS name, mytable.description AS description "
+        "FROM mytable "
         "WHERE mytable.name = :name_1) WHERE myid = :myid_1")
 
         sq = select([table1])
         self.assert_compile(
             sq.select(),
-            "SELECT myid, name, description FROM (SELECT mytable.myid AS myid, "
-            "mytable.name AS name, mytable.description AS description FROM mytable)"
+            "SELECT myid, name, description FROM "
+            "(SELECT mytable.myid AS myid, "
+            "mytable.name AS name, mytable.description "
+            "AS description FROM mytable)"
         )
 
         sq = select(
             sq.select(sq.c.myid == 7),
             "SELECT sq.myid, sq.name, sq.description FROM "
             "(SELECT mytable.myid AS myid, mytable.name AS name, "
-            "mytable.description AS description FROM mytable) AS sq WHERE sq.myid = :myid_1"
+            "mytable.description AS description FROM mytable) AS sq "
+            "WHERE sq.myid = :myid_1"
         )
 
         sq = select(
             [table1, table2],
-            and_(table1.c.myid ==7, table2.c.otherid==table1.c.myid),
-            use_labels = True
+            and_(table1.c.myid == 7, table2.c.otherid == table1.c.myid),
+            use_labels=True
         ).alias('sq')
 
         sqstring = "SELECT mytable.myid AS mytable_myid, mytable.name AS "\
 
         sq2 = select(
             [sq],
-            use_labels = True
+            use_labels=True
         ).alias('sq2')
 
         self.assert_compile(
                 sq2.select(),
                 "SELECT sq2.sq_mytable_myid, sq2.sq_mytable_name, "
                 "sq2.sq_mytable_description, sq2.sq_myothertable_otherid, "
-                "sq2.sq_myothertable_othername FROM (SELECT sq.mytable_myid AS "
+                "sq2.sq_myothertable_othername FROM "
+                "(SELECT sq.mytable_myid AS "
                 "sq_mytable_myid, sq.mytable_name AS sq_mytable_name, "
                 "sq.mytable_description AS sq_mytable_description, "
                 "sq.myothertable_otherid AS sq_myothertable_otherid, "
 
     def test_select_from_clauselist(self):
         self.assert_compile(
-            select([ClauseList(column('a'), column('b'))]).select_from('sometable'),
+            select([ClauseList(column('a'), column('b'))]
+                    ).select_from('sometable'),
             'SELECT a, b FROM sometable'
         )
 
     def test_use_labels(self):
         self.assert_compile(
-            select([table1.c.myid==5], use_labels=True),
+            select([table1.c.myid == 5], use_labels=True),
             "SELECT mytable.myid = :myid_1 AS anon_1 FROM mytable"
         )
 
 
         self.assert_compile(
             select([not_(True)], use_labels=True),
-            "SELECT NOT :param_1"       # TODO: should this make an anon label ??
+            "SELECT NOT :param_1"
         )
 
         self.assert_compile(
         )
 
         self.assert_compile(
-            select([func.sum(func.lala(table1.c.myid).label('foo')).label('bar')]),
+            select([func.sum(
+                    func.lala(table1.c.myid).label('foo')).label('bar')]),
             "SELECT sum(lala(mytable.myid)) AS bar FROM mytable"
         )
 
 
         self.assert_compile(
             stmt,
-            "select ?, ?, ? from sometable"
-            , dialect=default.DefaultDialect(paramstyle='qmark')
+            "select ?, ?, ? from sometable",
+            dialect=default.DefaultDialect(paramstyle='qmark')
         )
         self.assert_compile(
             stmt,
-            "select :foo, :bar, :bat from sometable"
-            , dialect=default.DefaultDialect(paramstyle='named')
+            "select :foo, :bar, :bat from sometable",
+            dialect=default.DefaultDialect(paramstyle='named')
         )
         self.assert_compile(
             stmt,
-            "select %s, %s, %s from sometable"
-            , dialect=default.DefaultDialect(paramstyle='format')
+            "select %s, %s, %s from sometable",
+            dialect=default.DefaultDialect(paramstyle='format')
         )
         self.assert_compile(
             stmt,
-            "select :1, :2, :3 from sometable"
-            , dialect=default.DefaultDialect(paramstyle='numeric')
+            "select :1, :2, :3 from sometable",
+            dialect=default.DefaultDialect(paramstyle='numeric')
         )
         self.assert_compile(
             stmt,
-            "select %(foo)s, %(bar)s, %(bat)s from sometable"
-            , dialect=default.DefaultDialect(paramstyle='pyformat')
+            "select %(foo)s, %(bar)s, %(bat)s from sometable",
+            dialect=default.DefaultDialect(paramstyle='pyformat')
         )
 
     def test_dupe_columns(self):
 
         self.assert_compile(
             select([column('a'), column('a'), column('a')]),
-            "SELECT a, a, a"
-            , dialect=default.DefaultDialect()
+            "SELECT a, a, a", dialect=default.DefaultDialect()
         )
 
         c = column('a')
         self.assert_compile(
             select([c, c, c]),
-            "SELECT a"
-            , dialect=default.DefaultDialect()
+            "SELECT a", dialect=default.DefaultDialect()
         )
 
         a, b = column('a'), column('b')
         self.assert_compile(
             select([a, b, b, b, a, a]),
-            "SELECT a, b"
-            , dialect=default.DefaultDialect()
+            "SELECT a, b", dialect=default.DefaultDialect()
         )
 
         # using alternate keys.
                     Column('c', Integer, key='a')
         self.assert_compile(
             select([a, b, c, a, b, c]),
-            "SELECT a, b, c"
-            , dialect=default.DefaultDialect()
+            "SELECT a, b, c", dialect=default.DefaultDialect()
         )
 
         self.assert_compile(
             select([bindparam('a'), bindparam('b'), bindparam('c')]),
-            "SELECT :a AS anon_1, :b AS anon_2, :c AS anon_3"
-            , dialect=default.DefaultDialect(paramstyle='named')
+            "SELECT :a AS anon_1, :b AS anon_2, :c AS anon_3",
+                dialect=default.DefaultDialect(paramstyle='named')
         )
 
         self.assert_compile(
             select([bindparam('a'), bindparam('b'), bindparam('c')]),
-            "SELECT ? AS anon_1, ? AS anon_2, ? AS anon_3"
-            , dialect=default.DefaultDialect(paramstyle='qmark'),
+            "SELECT ? AS anon_1, ? AS anon_2, ? AS anon_3",
+                dialect=default.DefaultDialect(paramstyle='qmark'),
         )
 
         self.assert_compile(
                     "SELECT anon_1.anon_2_x AS anon_1_anon_2_x, "
                     "anon_1.anon_2_y AS anon_1_anon_2_y, "
                     "anon_1.anon_2_z AS anon_1_anon_2_z "
-                    "FROM (SELECT anon_2.x AS anon_2_x, anon_2.y AS anon_2_y, "
+                    "FROM (SELECT anon_2.x AS anon_2_x, "
+                        "anon_2.y AS anon_2_y, "
                     "anon_2.z AS anon_2_z FROM "
                     "(SELECT keyed.x AS x, keyed.y AS y, keyed.z "
                     "AS z FROM keyed) AS anon_2) AS anon_1"
     def test_full_correlate(self):
         # intentional
         t = table('t', column('a'), column('b'))
-        s = select([t.c.a]).where(t.c.a==1).correlate(t).as_scalar()
+        s = select([t.c.a]).where(t.c.a == 1).correlate(t).as_scalar()
 
         s2 = select([t.c.a, s])
-        self.assert_compile(s2, """SELECT t.a, (SELECT t.a WHERE t.a = :a_1) AS anon_1 FROM t""")
+        self.assert_compile(s2,
+                "SELECT t.a, (SELECT t.a WHERE t.a = :a_1) AS anon_1 FROM t")
 
         # unintentional
         t2 = table('t2', column('c'), column('d'))
-        s = select([t.c.a]).where(t.c.a==t2.c.d).as_scalar()
-        s2 =select([t, t2, s])
+        s = select([t.c.a]).where(t.c.a == t2.c.d).as_scalar()
+        s2 = select([t, t2, s])
         assert_raises(exc.InvalidRequestError, str, s2)
 
         # intentional again
         s = s.correlate(t, t2)
-        s2 =select([t, t2, s])
+        s2 = select([t, t2, s])
         self.assert_compile(s, "SELECT t.a WHERE t.a = t2.d")
 
     def test_exists(self):
-        s = select([table1.c.myid]).where(table1.c.myid==5)
+        s = select([table1.c.myid]).where(table1.c.myid == 5)
 
         self.assert_compile(exists(s),
-                    "EXISTS (SELECT mytable.myid FROM mytable WHERE mytable.myid = :myid_1)"
+                    "EXISTS (SELECT mytable.myid FROM mytable "
+                        "WHERE mytable.myid = :myid_1)"
                 )
 
         self.assert_compile(exists(s.as_scalar()),
-                    "EXISTS (SELECT mytable.myid FROM mytable WHERE mytable.myid = :myid_1)"
+                    "EXISTS (SELECT mytable.myid FROM mytable "
+                        "WHERE mytable.myid = :myid_1)"
                 )
 
         self.assert_compile(exists([table1.c.myid], table1.c.myid
                             'EXISTS (SELECT * FROM myothertable WHERE '
                             'myothertable.otherid = mytable.myid)')
         self.assert_compile(table1.select(exists().where(table2.c.otherid
-                            == table1.c.myid).correlate(table1)).replace_selectable(table2,
+                            == table1.c.myid).correlate(table1)
+                            ).replace_selectable(table2,
                             table2.alias()),
                             'SELECT mytable.myid, mytable.name, '
                             'mytable.description FROM mytable WHERE '
                             'myothertable_1 WHERE myothertable_1.otheri'
                             'd = mytable.myid)')
         self.assert_compile(table1.select(exists().where(table2.c.otherid
-                            == table1.c.myid).correlate(table1)).select_from(table1.join(table2,
+                            == table1.c.myid).correlate(table1)).select_from(
+                            table1.join(table2,
                             table1.c.myid
                             == table2.c.otherid)).replace_selectable(table2,
                             table2.alias()),
         self.assert_compile(
             select([
                 or_(
-                    exists().where(table2.c.otherid=='foo'),
-                    exists().where(table2.c.otherid=='bar')
+                    exists().where(table2.c.otherid == 'foo'),
+                    exists().where(table2.c.otherid == 'bar')
                 )
             ]),
             "SELECT (EXISTS (SELECT * FROM myothertable "
                             '(SELECT myothertable.otherid FROM '
                             'myothertable WHERE mytable.myid = '
                             'myothertable.otherid)')
-        self.assert_compile(table1.select(order_by=[desc(select([table2.c.otherid],
+        self.assert_compile(table1.select(order_by=[
+                            desc(select([table2.c.otherid],
                             table1.c.myid == table2.c.otherid))]),
                             'SELECT mytable.myid, mytable.name, '
                             'mytable.description FROM mytable ORDER BY '
                             'myothertable WHERE mytable.myid = '
                             'myothertable.otherid) DESC')
 
-    @testing.uses_deprecated('scalar option')
     def test_scalar_select(self):
         assert_raises_message(
             exc.InvalidRequestError,
             r"Select objects don't have a type\.  Call as_scalar\(\) "
-            "on this Select object to return a 'scalar' version of this Select\.",
+            "on this Select object to return a 'scalar' "
+            "version of this Select\.",
             func.coalesce, select([table1.c.myid])
         )
 
         s = select([table1.c.myid]).as_scalar()
         s2 = s.where(table1.c.myid == 5)
         self.assert_compile(
-            s2, "(SELECT mytable.myid FROM mytable WHERE mytable.myid = :myid_1)"
+            s2,
+            "(SELECT mytable.myid FROM mytable WHERE mytable.myid = :myid_1)"
         )
         self.assert_compile(
             s, "(SELECT mytable.myid FROM mytable)"
             column('nm')
         )
         zip = '12345'
-        qlat = select([zips.c.latitude], zips.c.zipcode == zip).correlate(None).as_scalar()
-        qlng = select([zips.c.longitude], zips.c.zipcode == zip).correlate(None).as_scalar()
-
-        q = select([places.c.id, places.c.nm, zips.c.zipcode, func.latlondist(qlat, qlng).label('dist')],
-                         zips.c.zipcode==zip,
-                         order_by = ['dist', places.c.nm]
+        qlat = select([zips.c.latitude], zips.c.zipcode == zip).\
+                        correlate(None).as_scalar()
+        qlng = select([zips.c.longitude], zips.c.zipcode == zip).\
+                        correlate(None).as_scalar()
+
+        q = select([places.c.id, places.c.nm, zips.c.zipcode,
+                        func.latlondist(qlat, qlng).label('dist')],
+                         zips.c.zipcode == zip,
+                         order_by=['dist', places.c.nm]
                          )
 
         self.assert_compile(q,
                             ':zipcode_3 ORDER BY dist, places.nm')
 
         zalias = zips.alias('main_zip')
-        qlat = select([zips.c.latitude], zips.c.zipcode == zalias.c.zipcode).as_scalar()
-        qlng = select([zips.c.longitude], zips.c.zipcode == zalias.c.zipcode).as_scalar()
+        qlat = select([zips.c.latitude], zips.c.zipcode == zalias.c.zipcode).\
+                    as_scalar()
+        qlng = select([zips.c.longitude], zips.c.zipcode == zalias.c.zipcode).\
+                    as_scalar()
         q = select([places.c.id, places.c.nm, zalias.c.zipcode,
                    func.latlondist(qlat, qlng).label('dist')],
                    order_by=['dist', places.c.nm])
                             'dist, places.nm')
 
         a1 = table2.alias('t2alias')
-        s1 = select([a1.c.otherid], table1.c.myid==a1.c.otherid).as_scalar()
-        j1 = table1.join(table2, table1.c.myid==table2.c.otherid)
+        s1 = select([a1.c.otherid], table1.c.myid == a1.c.otherid).as_scalar()
+        j1 = table1.join(table2, table1.c.myid == table2.c.otherid)
         s2 = select([table1, s1], from_obj=j1)
         self.assert_compile(s2,
                             'SELECT mytable.myid, mytable.name, '
                             ':param_1')
 
         self.assert_compile(
-                label('bar', column('foo', type_=String))+ 'foo',
+                label('bar', column('foo', type_=String)) + 'foo',
                 'foo || :param_1')
 
 
         )
 
         self.assert_compile(
-            and_(table1.c.myid == 12, table1.c.name=='asdf',
+            and_(table1.c.myid == 12, table1.c.name == 'asdf',
                 table2.c.othername == 'foo', "sysdate() = today()"),
             "mytable.myid = :myid_1 AND mytable.name = :name_1 "\
-            "AND myothertable.othername = :othername_1 AND sysdate() = today()"
+            "AND myothertable.othername = "
+            ":othername_1 AND sysdate() = today()"
         )
 
         self.assert_compile(
             and_(
                 table1.c.myid == 12,
-                or_(table2.c.othername=='asdf',
+                or_(table2.c.othername == 'asdf',
                     table2.c.othername == 'foo', table2.c.otherid == 9),
                 "sysdate() = today()",
             ),
              ':othername_1 OR myothertable.othername = :othername_2 OR '
              'myothertable.otherid = :otherid_1) AND sysdate() = '
              'today()',
-            checkparams = {'othername_1': 'asdf', 'othername_2':'foo', 'otherid_1': 9, 'myid_1': 12}
+            checkparams={'othername_1': 'asdf', 'othername_2': 'foo',
+                            'otherid_1': 9, 'myid_1': 12}
         )
 
     def test_nested_conjunctions_short_circuit(self):
         t = table('t', column('x'))
 
         self.assert_compile(
-            select([t]).where(and_(t.c.x==5,
-                or_(and_(or_(t.c.x==7))))),
+            select([t]).where(and_(t.c.x == 5,
+                or_(and_(or_(t.c.x == 7))))),
             "SELECT t.x FROM t WHERE t.x = :x_1 AND t.x = :x_2"
         )
         self.assert_compile(
-            select([t]).where(and_(or_(t.c.x==12,
-                and_(or_(t.c.x==8))))),
+            select([t]).where(and_(or_(t.c.x == 12,
+                and_(or_(t.c.x == 8))))),
             "SELECT t.x FROM t WHERE t.x = :x_1 OR t.x = :x_2"
         )
         self.assert_compile(
-            select([t]).where(and_(or_(or_(t.c.x==12),
-                and_(or_(), or_(and_(t.c.x==8)), and_())))),
+            select([t]).where(and_(or_(or_(t.c.x == 12),
+                and_(or_(), or_(and_(t.c.x == 8)), and_())))),
             "SELECT t.x FROM t WHERE t.x = :x_1 OR t.x = :x_2"
         )
 
                                         (operator.ge, '>=', '<=')):
             for (lhs, rhs, l_sql, r_sql) in (
                 ('a', table1.c.myid, ':myid_1', 'mytable.myid'),
-                ('a', literal('b'), ':param_2', ':param_1'), # note swap!
+                ('a', literal('b'), ':param_2', ':param_1'),  # note swap!
                 (table1.c.myid, 'b', 'mytable.myid', ':myid_1'),
                 (table1.c.myid, literal('b'), 'mytable.myid', ':param_1'),
                 (table1.c.myid, table1.c.myid, 'mytable.myid', 'mytable.myid'),
             (operator.neg, '-'),
             (operator.inv, 'NOT '),
         ):
-            for expr, sql in (
+            for expr, expected in (
                 (table1.c.myid, "mytable.myid"),
                 (literal("foo"), ":param_1"),
             ):
-
-                compiled = str(py_op(expr))
-                sql = "%s%s" % (op, sql)
-                eq_(compiled, sql)
+                self.assert_compile(py_op(expr), "%s%s" % (op, expected))
 
     def test_negate_operators_2(self):
         self.assert_compile(
-         table1.select((table1.c.myid != 12) & ~(table1.c.name=='john')),
+         table1.select((table1.c.myid != 12) & ~(table1.c.name == 'john')),
          "SELECT mytable.myid, mytable.name, mytable.description FROM "
             "mytable WHERE mytable.myid != :myid_1 AND mytable.name != :name_1"
         )
     def test_negate_operators_3(self):
         self.assert_compile(
          table1.select((table1.c.myid != 12) &
-                ~(table1.c.name.between('jack','john'))),
+                ~(table1.c.name.between('jack', 'john'))),
          "SELECT mytable.myid, mytable.name, mytable.description FROM "
              "mytable WHERE mytable.myid != :myid_1 AND "\
              "NOT (mytable.name BETWEEN :name_1 AND :name_2)"
     def test_negate_operators_4(self):
         self.assert_compile(
          table1.select((table1.c.myid != 12) &
-                ~and_(table1.c.name=='john', table1.c.name=='ed', table1.c.name=='fred')),
+                ~and_(table1.c.name == 'john',
+                        table1.c.name == 'ed',
+                        table1.c.name == 'fred')),
          "SELECT mytable.myid, mytable.name, mytable.description FROM "
          "mytable WHERE mytable.myid != :myid_1 AND "\
          "NOT (mytable.name = :name_1 AND mytable.name = :name_2 "
 
     def test_commutative_operators(self):
         self.assert_compile(
-         literal("a") + literal("b") * literal("c"), ":param_1 || :param_2 * :param_3"
+         literal("a") + literal("b") * literal("c"),
+                ":param_1 || :param_2 * :param_3"
         )
 
     def test_op_operators(self):
             (
                 table1.c.myid.ilike('somstr', escape='\\'),
                     "mytable.myid ILIKE %(myid_1)s ESCAPE '\\\\'",
-                    postgresql.PGDialect()),
+                    postgresql.dialect()),
             (
                 ~table1.c.myid.ilike('somstr', escape='\\'),
                 "mytable.myid NOT ILIKE %(myid_1)s ESCAPE '\\\\'",
-                postgresql.PGDialect()),
+                postgresql.dialect()),
             (
                 table1.c.name.ilike('%something%'),
                 "lower(mytable.name) LIKE lower(:name_1)", None),
             (
                 table1.c.name.ilike('%something%'),
-                "mytable.name ILIKE %(name_1)s", postgresql.PGDialect()),
+                "mytable.name ILIKE %(name_1)s", postgresql.dialect()),
             (
                 ~table1.c.name.ilike('%something%'),
                 "lower(mytable.name) NOT LIKE lower(:name_1)", None),
             (
                 ~table1.c.name.ilike('%something%'),
                 "mytable.name NOT ILIKE %(name_1)s",
-                postgresql.PGDialect()),
+                postgresql.dialect()),
         ]:
             self.assert_compile(expr, check, dialect=dialect)
 
     def test_match(self):
         for expr, check, dialect in [
             (table1.c.myid.match('somstr'),
-                        "mytable.myid MATCH ?", sqlite.SQLiteDialect()),
+                        "mytable.myid MATCH ?", sqlite.dialect()),
             (table1.c.myid.match('somstr'),
                         "MATCH (mytable.myid) AGAINST (%s IN BOOLEAN MODE)",
                         mysql.dialect()),
 
     def test_multiple_col_binds(self):
         self.assert_compile(
-            select(["*"], or_(table1.c.myid == 12, table1.c.myid=='asdf',
+            select(["*"], or_(table1.c.myid == 12, table1.c.myid == 'asdf',
                             table1.c.myid == 'foo')),
             "SELECT * FROM mytable WHERE mytable.myid = :myid_1 "
             "OR mytable.myid = :myid_2 OR mytable.myid = :myid_3"
 
     def test_order_by_nulls(self):
         self.assert_compile(
-            table2.select(order_by = [table2.c.otherid, table2.c.othername.desc().nullsfirst()]),
+            table2.select(order_by=[table2.c.otherid,
+                                    table2.c.othername.desc().nullsfirst()]),
             "SELECT myothertable.otherid, myothertable.othername FROM "
-            "myothertable ORDER BY myothertable.otherid, myothertable.othername DESC NULLS FIRST"
+            "myothertable ORDER BY myothertable.otherid, "
+            "myothertable.othername DESC NULLS FIRST"
         )
 
         self.assert_compile(
-            table2.select(order_by = [table2.c.otherid, table2.c.othername.desc().nullslast()]),
+            table2.select(order_by=[
+                    table2.c.otherid, table2.c.othername.desc().nullslast()]),
             "SELECT myothertable.otherid, myothertable.othername FROM "
-            "myothertable ORDER BY myothertable.otherid, myothertable.othername DESC NULLS LAST"
+            "myothertable ORDER BY myothertable.otherid, "
+            "myothertable.othername DESC NULLS LAST"
         )
 
         self.assert_compile(
-            table2.select(order_by = [table2.c.otherid.nullslast(), table2.c.othername.desc().nullsfirst()]),
+            table2.select(order_by=[
+                        table2.c.otherid.nullslast(),
+                        table2.c.othername.desc().nullsfirst()]),
             "SELECT myothertable.otherid, myothertable.othername FROM "
-            "myothertable ORDER BY myothertable.otherid NULLS LAST, myothertable.othername DESC NULLS FIRST"
+            "myothertable ORDER BY myothertable.otherid NULLS LAST, "
+            "myothertable.othername DESC NULLS FIRST"
         )
 
         self.assert_compile(
-            table2.select(order_by = [table2.c.otherid.nullsfirst(), table2.c.othername.desc()]),
+            table2.select(order_by=[table2.c.otherid.nullsfirst(),
+                                                table2.c.othername.desc()]),
             "SELECT myothertable.otherid, myothertable.othername FROM "
-            "myothertable ORDER BY myothertable.otherid NULLS FIRST, myothertable.othername DESC"
+            "myothertable ORDER BY myothertable.otherid NULLS FIRST, "
+            "myothertable.othername DESC"
         )
 
         self.assert_compile(
-            table2.select(order_by = [table2.c.otherid.nullsfirst(), table2.c.othername.desc().nullslast()]),
+            table2.select(order_by=[table2.c.otherid.nullsfirst(),
+                                table2.c.othername.desc().nullslast()]),
             "SELECT myothertable.otherid, myothertable.othername FROM "
-            "myothertable ORDER BY myothertable.otherid NULLS FIRST, myothertable.othername DESC NULLS LAST"
+            "myothertable ORDER BY myothertable.otherid NULLS FIRST, "
+            "myothertable.othername DESC NULLS LAST"
         )
 
     def test_orderby_groupby(self):
         self.assert_compile(
-            table2.select(order_by = [table2.c.otherid, asc(table2.c.othername)]),
+            table2.select(order_by=[table2.c.otherid,
+                                asc(table2.c.othername)]),
             "SELECT myothertable.otherid, myothertable.othername FROM "
-            "myothertable ORDER BY myothertable.otherid, myothertable.othername ASC"
+            "myothertable ORDER BY myothertable.otherid, "
+            "myothertable.othername ASC"
         )
 
         self.assert_compile(
-            table2.select(order_by = [table2.c.otherid, table2.c.othername.desc()]),
+            table2.select(order_by=[table2.c.otherid,
+                                    table2.c.othername.desc()]),
             "SELECT myothertable.otherid, myothertable.othername FROM "
-            "myothertable ORDER BY myothertable.otherid, myothertable.othername DESC"
+            "myothertable ORDER BY myothertable.otherid, "
+            "myothertable.othername DESC"
         )
 
         # generative order_by
         self.assert_compile(
-            table2.select().order_by(table2.c.otherid).order_by(table2.c.othername.desc()),
+            table2.select().order_by(table2.c.otherid).\
+                    order_by(table2.c.othername.desc()),
             "SELECT myothertable.otherid, myothertable.othername FROM "
-            "myothertable ORDER BY myothertable.otherid, myothertable.othername DESC"
+            "myothertable ORDER BY myothertable.otherid, "
+            "myothertable.othername DESC"
         )
 
         self.assert_compile(
             table2.select().order_by(table2.c.otherid).
-                                order_by(table2.c.othername.desc()).order_by(None),
-            "SELECT myothertable.otherid, myothertable.othername FROM myothertable"
+                                order_by(table2.c.othername.desc()
+                                ).order_by(None),
+            "SELECT myothertable.otherid, myothertable.othername "
+            "FROM myothertable"
         )
 
         self.assert_compile(
             select(
                     [table2.c.othername, func.count(table2.c.otherid)],
-                    group_by = [table2.c.othername]),
-            "SELECT myothertable.othername, count(myothertable.otherid) AS count_1 "
+                    group_by=[table2.c.othername]),
+            "SELECT myothertable.othername, "
+            "count(myothertable.otherid) AS count_1 "
             "FROM myothertable GROUP BY myothertable.othername"
         )
 
         self.assert_compile(
             select([table2.c.othername, func.count(table2.c.otherid)]).
                         group_by(table2.c.othername),
-            "SELECT myothertable.othername, count(myothertable.otherid) AS count_1 "
+            "SELECT myothertable.othername, "
+            "count(myothertable.otherid) AS count_1 "
             "FROM myothertable GROUP BY myothertable.othername"
         )
 
         self.assert_compile(
             select([table2.c.othername, func.count(table2.c.otherid)]).
                         group_by(table2.c.othername).group_by(None),
-            "SELECT myothertable.othername, count(myothertable.otherid) AS count_1 "
+            "SELECT myothertable.othername, "
+            "count(myothertable.otherid) AS count_1 "
             "FROM myothertable"
         )
 
         self.assert_compile(
             select([table2.c.othername, func.count(table2.c.otherid)],
-                        group_by = [table2.c.othername],
-                        order_by = [table2.c.othername]),
-            "SELECT myothertable.othername, count(myothertable.otherid) AS count_1 "
-            "FROM myothertable GROUP BY myothertable.othername ORDER BY myothertable.othername"
+                        group_by=[table2.c.othername],
+                        order_by=[table2.c.othername]),
+            "SELECT myothertable.othername, "
+            "count(myothertable.otherid) AS count_1 "
+            "FROM myothertable "
+            "GROUP BY myothertable.othername ORDER BY myothertable.othername"
         )
 
     def test_for_update(self):
         self.assert_compile(
-            table1.select(table1.c.myid==7, for_update=True),
+            table1.select(table1.c.myid == 7, for_update=True),
             "SELECT mytable.myid, mytable.name, mytable.description "
             "FROM mytable WHERE mytable.myid = :myid_1 FOR UPDATE")
 
         self.assert_compile(
-            table1.select(table1.c.myid==7, for_update=False),
+            table1.select(table1.c.myid == 7, for_update=False),
             "SELECT mytable.myid, mytable.name, mytable.description "
             "FROM mytable WHERE mytable.myid = :myid_1")
 
         # not supported by dialect, should just use update
         self.assert_compile(
-            table1.select(table1.c.myid==7, for_update='nowait'),
+            table1.select(table1.c.myid == 7, for_update='nowait'),
             "SELECT mytable.myid, mytable.name, mytable.description "
             "FROM mytable WHERE mytable.myid = :myid_1 FOR UPDATE")
 
         # unknown lock mode
         self.assert_compile(
-            table1.select(table1.c.myid==7, for_update='unknown_mode'),
+            table1.select(table1.c.myid == 7, for_update='unknown_mode'),
             "SELECT mytable.myid, mytable.name, mytable.description "
             "FROM mytable WHERE mytable.myid = :myid_1 FOR UPDATE")
 
         # ----- mysql
 
         self.assert_compile(
-            table1.select(table1.c.myid==7, for_update=True),
+            table1.select(table1.c.myid == 7, for_update=True),
             "SELECT mytable.myid, mytable.name, mytable.description "
             "FROM mytable WHERE mytable.myid = %s FOR UPDATE",
             dialect=mysql.dialect())
 
         self.assert_compile(
-            table1.select(table1.c.myid==7, for_update="read"),
+            table1.select(table1.c.myid == 7, for_update="read"),
             "SELECT mytable.myid, mytable.name, mytable.description "
             "FROM mytable WHERE mytable.myid = %s LOCK IN SHARE MODE",
             dialect=mysql.dialect())
         # ----- oracle
 
         self.assert_compile(
-            table1.select(table1.c.myid==7, for_update=True),
+            table1.select(table1.c.myid == 7, for_update=True),
             "SELECT mytable.myid, mytable.name, mytable.description "
             "FROM mytable WHERE mytable.myid = :myid_1 FOR UPDATE",
             dialect=oracle.dialect())
 
         self.assert_compile(
-            table1.select(table1.c.myid==7, for_update="nowait"),
+            table1.select(table1.c.myid == 7, for_update="nowait"),
             "SELECT mytable.myid, mytable.name, mytable.description "
             "FROM mytable WHERE mytable.myid = :myid_1 FOR UPDATE NOWAIT",
             dialect=oracle.dialect())
         # ----- postgresql
 
         self.assert_compile(
-            table1.select(table1.c.myid==7, for_update=True),
+            table1.select(table1.c.myid == 7, for_update=True),
             "SELECT mytable.myid, mytable.name, mytable.description "
             "FROM mytable WHERE mytable.myid = %(myid_1)s FOR UPDATE",
             dialect=postgresql.dialect())
 
         self.assert_compile(
-            table1.select(table1.c.myid==7, for_update="nowait"),
+            table1.select(table1.c.myid == 7, for_update="nowait"),
             "SELECT mytable.myid, mytable.name, mytable.description "
             "FROM mytable WHERE mytable.myid = %(myid_1)s FOR UPDATE NOWAIT",
             dialect=postgresql.dialect())
 
         self.assert_compile(
-            table1.select(table1.c.myid==7, for_update="read"),
+            table1.select(table1.c.myid == 7, for_update="read"),
             "SELECT mytable.myid, mytable.name, mytable.description "
             "FROM mytable WHERE mytable.myid = %(myid_1)s FOR SHARE",
             dialect=postgresql.dialect())
 
         self.assert_compile(
-            table1.select(table1.c.myid==7, for_update="read_nowait"),
+            table1.select(table1.c.myid == 7, for_update="read_nowait"),
             "SELECT mytable.myid, mytable.name, mytable.description "
             "FROM mytable WHERE mytable.myid = %(myid_1)s FOR SHARE NOWAIT",
             dialect=postgresql.dialect())
 
     def test_alias(self):
-        # test the alias for a table1.  column names stay the same, table name "changes" to "foo".
+        # test the alias for a table1.  column names stay the same,
+        # table name "changes" to "foo".
         self.assert_compile(
-            select([table1.alias('foo')])
-            ,"SELECT foo.myid, foo.name, foo.description FROM mytable AS foo")
+            select([table1.alias('foo')]),
+            "SELECT foo.myid, foo.name, foo.description FROM mytable AS foo")
 
         for dialect in (oracle.dialect(),):
             self.assert_compile(
-                select([table1.alias('foo')])
-                ,"SELECT foo.myid, foo.name, foo.description FROM mytable foo"
-                ,dialect=dialect)
+                select([table1.alias('foo')]),
+                "SELECT foo.myid, foo.name, foo.description FROM mytable foo",
+                dialect=dialect)
 
         self.assert_compile(
             select([table1.alias()]),
         # from the first table1.
         q = select(
                         [table1, table2.c.otherid],
-                        table1.c.myid == table2.c.otherid, use_labels = True
+                        table1.c.myid == table2.c.otherid, use_labels=True
                     )
 
         # make an alias of the "selectable".  column names
         # stay the same (i.e. the labels), table name "changes" to "t2view".
         a = alias(q, 't2view')
 
-        # select from that alias, also using labels.  two levels of labels should produce two underscores.
+        # select from that alias, also using labels.  two levels of labels
+        # should produce two underscores.
         # also, reference the column "mytable_myid" off of the t2view alias.
         self.assert_compile(
-            a.select(a.c.mytable_myid == 9, use_labels = True),
-            "SELECT t2view.mytable_myid AS t2view_mytable_myid, t2view.mytable_name "
-            "AS t2view_mytable_name, t2view.mytable_description AS t2view_mytable_description, "
+            a.select(a.c.mytable_myid == 9, use_labels=True),
+            "SELECT t2view.mytable_myid AS t2view_mytable_myid, "
+            "t2view.mytable_name "
+            "AS t2view_mytable_name, "
+            "t2view.mytable_description AS t2view_mytable_description, "
             "t2view.myothertable_otherid AS t2view_myothertable_otherid FROM "
-            "(SELECT mytable.myid AS mytable_myid, mytable.name AS mytable_name, "
-            "mytable.description AS mytable_description, myothertable.otherid AS "
-            "myothertable_otherid FROM mytable, myothertable WHERE mytable.myid = "
-            "myothertable.otherid) AS t2view WHERE t2view.mytable_myid = :mytable_myid_1"
+            "(SELECT mytable.myid AS mytable_myid, "
+                "mytable.name AS mytable_name, "
+            "mytable.description AS mytable_description, "
+                "myothertable.otherid AS "
+            "myothertable_otherid FROM mytable, myothertable "
+                "WHERE mytable.myid = "
+            "myothertable.otherid) AS t2view "
+                "WHERE t2view.mytable_myid = :mytable_myid_1"
         )
 
 
 
     def test_prefix_dialect_specific(self):
         self.assert_compile(
-            table1.select().prefix_with("SQL_CALC_FOUND_ROWS", dialect='sqlite').\
+            table1.select().prefix_with("SQL_CALC_FOUND_ROWS",
+                                dialect='sqlite').\
                                 prefix_with("SQL_SOME_WEIRD_MYSQL_THING",
                                         dialect='mysql'),
             "SELECT SQL_SOME_WEIRD_MYSQL_THING "
 
     def test_text(self):
         self.assert_compile(
-            text("select * from foo where lala = bar") ,
+            text("select * from foo where lala = bar"),
             "select * from foo where lala = bar"
         )
 
         self.assert_compile(select(
             ["foobar(a)", "pk_foo_bar(syslaal)"],
             "a = 12",
-            from_obj = ["foobar left outer join lala on foobar.foo = lala.foo"]
+            from_obj=["foobar left outer join lala on foobar.foo = lala.foo"]
             ),
             "SELECT foobar(a), pk_foo_bar(syslaal) FROM foobar "
             "left outer join lala on foobar.foo = lala.foo WHERE a = 12"
         self.assert_compile(select(
             [u"foobar(a)", u"pk_foo_bar(syslaal)"],
             u"a = 12",
-            from_obj = [u"foobar left outer join lala on foobar.foo = lala.foo"]
+            from_obj=[u"foobar left outer join lala on foobar.foo = lala.foo"]
             ),
             "SELECT foobar(a), pk_foo_bar(syslaal) FROM foobar "
             "left outer join lala on foobar.foo = lala.foo WHERE a = 12"
                                 "column1=12 AND column2=19 ORDER BY column1")
 
         self.assert_compile(
-            select(["column1", "column2"], from_obj=table1).alias('somealias').select(),
+            select(["column1", "column2"],
+                            from_obj=table1).alias('somealias').select(),
             "SELECT somealias.column1, somealias.column2 FROM "
             "(SELECT column1, column2 FROM mytable) AS somealias"
         )
 
         # test that use_labels doesnt interfere with literal columns
         self.assert_compile(
-            select(["column1", "column2", table1.c.myid], from_obj=table1, use_labels=True),
-            "SELECT column1, column2, mytable.myid AS mytable_myid FROM mytable"
+            select(["column1", "column2", table1.c.myid], from_obj=table1,
+                        use_labels=True),
+            "SELECT column1, column2, mytable.myid AS mytable_myid "
+            "FROM mytable"
         )
 
-        # test that use_labels doesnt interfere with literal columns that have textual labels
+        # test that use_labels doesnt interfere
+        # with literal columns that have textual labels
         self.assert_compile(
-            select(["column1 AS foobar", "column2 AS hoho", table1.c.myid], from_obj=table1, use_labels=True),
-            "SELECT column1 AS foobar, column2 AS hoho, mytable.myid AS mytable_myid FROM mytable"
+            select(["column1 AS foobar", "column2 AS hoho", table1.c.myid],
+                        from_obj=table1, use_labels=True),
+            "SELECT column1 AS foobar, column2 AS hoho, "
+            "mytable.myid AS mytable_myid FROM mytable"
         )
 
-        s1 = select(["column1 AS foobar", "column2 AS hoho", table1.c.myid], from_obj=[table1])
-        # test that "auto-labeling of subquery columns" doesnt interfere with literal columns,
+        # test that "auto-labeling of subquery columns"
+        # doesnt interfere with literal columns,
         # exported columns dont get quoted
         self.assert_compile(
-            select(["column1 AS foobar", "column2 AS hoho", table1.c.myid], from_obj=[table1]).select(),
+            select(["column1 AS foobar", "column2 AS hoho", table1.c.myid],
+                            from_obj=[table1]).select(),
             "SELECT column1 AS foobar, column2 AS hoho, myid FROM "
-            "(SELECT column1 AS foobar, column2 AS hoho, mytable.myid AS myid FROM mytable)"
+            "(SELECT column1 AS foobar, column2 AS hoho, "
+                "mytable.myid AS myid FROM mytable)"
         )
 
         self.assert_compile(
-            select(['col1','col2'], from_obj='tablename').alias('myalias'),
+            select(['col1', 'col2'], from_obj='tablename').alias('myalias'),
             "SELECT col1, col2 FROM tablename"
         )
 
             text("select * from foo where lala=:bar and hoho=:whee",
                 bindparams=[bindparam('bar', 4), bindparam('whee', 7)]),
                 "select * from foo where lala=:bar and hoho=:whee",
-                checkparams={'bar':4, 'whee': 7},
+                checkparams={'bar': 4, 'whee': 7},
         )
 
         self.assert_compile(
         dialect = postgresql.dialect()
         self.assert_compile(
             text("select * from foo where lala=:bar and hoho=:whee",
-                bindparams=[bindparam('bar',4), bindparam('whee',7)]),
+                bindparams=[bindparam('bar', 4), bindparam('whee', 7)]),
                 "select * from foo where lala=%(bar)s and hoho=%(whee)s",
-                checkparams={'bar':4, 'whee': 7},
+                checkparams={'bar': 4, 'whee': 7},
                 dialect=dialect
         )
 
         # test escaping out text() params with a backslash
         self.assert_compile(
-            text("select * from foo where clock='05:06:07' and mork='\:mindy'"),
+            text("select * from foo where clock='05:06:07' "
+                    "and mork='\:mindy'"),
             "select * from foo where clock='05:06:07' and mork=':mindy'",
             checkparams={},
             params={},
         dialect = sqlite.dialect()
         self.assert_compile(
             text("select * from foo where lala=:bar and hoho=:whee",
-                bindparams=[bindparam('bar',4), bindparam('whee',7)]),
+                bindparams=[bindparam('bar', 4), bindparam('whee', 7)]),
                 "select * from foo where lala=? and hoho=?",
-                checkparams={'bar':4, 'whee':7},
+                checkparams={'bar': 4, 'whee': 7},
                 dialect=dialect
         )
 
         self.assert_compile(select(
             [alias(table1, 't'), "foo.f"],
             "foo.f = t.id",
-            from_obj = ["(select f from bar where lala=heyhey) foo"]
+            from_obj=["(select f from bar where lala=heyhey) foo"]
         ),
         "SELECT t.myid, t.name, t.description, foo.f FROM mytable AS t, "
         "(select f from bar where lala=heyhey) foo WHERE foo.f = t.id")
                         )
 
         s = select([
-                    (func.current_date() + literal_column("s.a")).label("dates")
+                    (func.current_date() +
+                            literal_column("s.a")).label("dates")
                 ]).select_from(generate_series)
         self.assert_compile(
                     s,
 
     def test_literal(self):
 
-        self.assert_compile(select([literal('foo')]), "SELECT :param_1 AS anon_1")
-
-        self.assert_compile(select([literal("foo") + literal("bar")], from_obj=[table1]),
+        self.assert_compile(select([literal('foo')]),
+                "SELECT :param_1 AS anon_1")
+
+        self.assert_compile(select([literal("foo") + literal("bar")],
+                        from_obj=[table1]),
             "SELECT :param_1 || :param_2 AS anon_1 FROM mytable")
 
     def test_calculated_columns(self):
-         value_tbl = table('values',
+        value_tbl = table('values',
              column('id', Integer),
              column('val1', Float),
              column('val2', Float),
          )
 
-         self.assert_compile(
+        self.assert_compile(
              select([value_tbl.c.id, (value_tbl.c.val2 -
-     value_tbl.c.val1)/value_tbl.c.val1]),
-             "SELECT values.id, (values.val2 - values.val1) / values.val1 AS anon_1 FROM values"
+                        value_tbl.c.val1) / value_tbl.c.val1]),
+             "SELECT values.id, (values.val2 - values.val1) "
+             "/ values.val1 AS anon_1 FROM values"
          )
 
-         self.assert_compile(
+        self.assert_compile(
              select([value_tbl.c.id], (value_tbl.c.val2 -
-     value_tbl.c.val1)/value_tbl.c.val1 > 2.0),
-             "SELECT values.id FROM values WHERE (values.val2 - values.val1) / values.val1 > :param_1"
+                    value_tbl.c.val1) / value_tbl.c.val1 > 2.0),
+             "SELECT values.id FROM values WHERE "
+             "(values.val2 - values.val1) / values.val1 > :param_1"
          )
 
-         self.assert_compile(
-             select([value_tbl.c.id], value_tbl.c.val1 / (value_tbl.c.val2 - value_tbl.c.val1) /value_tbl.c.val1 > 2.0),
-             "SELECT values.id FROM values WHERE (values.val1 / (values.val2 - values.val1)) / values.val1 > :param_1"
+        self.assert_compile(
+             select([value_tbl.c.id], value_tbl.c.val1 /
+                (value_tbl.c.val2 - value_tbl.c.val1) /
+                    value_tbl.c.val1 > 2.0),
+             "SELECT values.id FROM values WHERE "
+                "(values.val1 / (values.val2 - values.val1)) "
+                "/ values.val1 > :param_1"
          )
 
     def test_collate(self):
         for expr in (select([table1.c.name.collate('latin1_german2_ci')]),
                      select([collate(table1.c.name, 'latin1_german2_ci')])):
             self.assert_compile(
-                expr, "SELECT mytable.name COLLATE latin1_german2_ci AS anon_1 FROM mytable")
-
-        assert table1.c.name.collate('latin1_german2_ci').type is table1.c.name.type
-
-        expr = select([table1.c.name.collate('latin1_german2_ci').label('k1')]).order_by('k1')
-        self.assert_compile(expr,"SELECT mytable.name COLLATE latin1_german2_ci AS k1 FROM mytable ORDER BY k1")
+                expr, "SELECT mytable.name COLLATE latin1_german2_ci "
+                "AS anon_1 FROM mytable")
+
+        assert table1.c.name.collate('latin1_german2_ci').type is \
+            table1.c.name.type
+
+        expr = select([table1.c.name.collate('latin1_german2_ci').\
+                    label('k1')]).order_by('k1')
+        self.assert_compile(expr,
+            "SELECT mytable.name "
+            "COLLATE latin1_german2_ci AS k1 FROM mytable ORDER BY k1")
 
         expr = select([collate('foo', 'latin1_german2_ci').label('k1')])
-        self.assert_compile(expr,"SELECT :param_1 COLLATE latin1_german2_ci AS k1")
+        self.assert_compile(expr,
+                    "SELECT :param_1 COLLATE latin1_german2_ci AS k1")
 
         expr = select([table1.c.name.collate('latin1_german2_ci').like('%x%')])
         self.assert_compile(expr,
                             "SELECT mytable.name COLLATE latin1_german2_ci "
                             "LIKE :param_1 AS anon_1 FROM mytable")
 
-        expr = select([table1.c.name.like(collate('%x%', 'latin1_german2_ci'))])
+        expr = select([table1.c.name.like(collate('%x%',
+                                'latin1_german2_ci'))])
         self.assert_compile(expr,
-                            "SELECT mytable.name "
-                            "LIKE :param_1 COLLATE latin1_german2_ci AS anon_1 "
-                            "FROM mytable")
+                        "SELECT mytable.name "
+                        "LIKE :param_1 COLLATE latin1_german2_ci AS anon_1 "
+                        "FROM mytable")
 
         expr = select([table1.c.name.collate('col1').like(
             collate('%x%', 'col2'))])
                             "LIKE :param_1 COLLATE col2 AS anon_1 "
                             "FROM mytable")
 
-        expr = select([func.concat('a', 'b').collate('latin1_german2_ci').label('x')])
+        expr = select([func.concat('a', 'b').\
+                collate('latin1_german2_ci').label('x')])
         self.assert_compile(expr,
                             "SELECT concat(:param_1, :param_2) "
                             "COLLATE latin1_german2_ci AS x")
         self.assert_compile(
             t.select(use_labels=True),
             '''SELECT "table%name"."percent%" AS "table%name_percent%", '''\
-            '''"table%name"."%(oneofthese)s" AS "table%name_%(oneofthese)s", '''\
-            '''"table%name"."spaces % more spaces" AS "table%name_spaces % '''\
+            '''"table%name"."%(oneofthese)s" AS '''\
+            '''"table%name_%(oneofthese)s", '''\
+            '''"table%name"."spaces % more spaces" AS '''\
+            '''"table%name_spaces % '''\
             '''more spaces" FROM "table%name"'''
         )
 
         self.assert_compile(
             select(
              [table1],
-                from_obj = [join(table1, table2, table1.c.myid == table2.c.otherid)]
+                from_obj=[join(table1, table2, table1.c.myid
+                                    == table2.c.otherid)]
             ),
         "SELECT mytable.myid, mytable.name, mytable.description FROM "
         "mytable JOIN myothertable ON mytable.myid = myothertable.otherid")
                 table3, table1.c.myid == table3.c.userid)]
             ),
             "SELECT mytable.myid, mytable.name, mytable.description, "
-            "myothertable.otherid, myothertable.othername, thirdtable.userid, "
-            "thirdtable.otherstuff FROM mytable JOIN myothertable ON mytable.myid ="
-            " myothertable.otherid JOIN thirdtable ON mytable.myid = thirdtable.userid"
+            "myothertable.otherid, myothertable.othername, "
+            "thirdtable.userid, "
+            "thirdtable.otherstuff FROM mytable JOIN myothertable "
+            "ON mytable.myid ="
+            " myothertable.otherid JOIN thirdtable ON "
+            "mytable.myid = thirdtable.userid"
         )
 
         self.assert_compile(
-            join(users, addresses, users.c.user_id==addresses.c.user_id).select(),
+            join(users, addresses, users.c.user_id ==
+                    addresses.c.user_id).select(),
             "SELECT users.user_id, users.user_name, users.password, "
             "addresses.address_id, addresses.user_id, addresses.street, "
-            "addresses.city, addresses.state, addresses.zip FROM users JOIN addresses "
+            "addresses.city, addresses.state, addresses.zip "
+            "FROM users JOIN addresses "
             "ON users.user_id = addresses.user_id"
         )
 
         self.assert_compile(
                 select([table1, table2, table3],
 
-                from_obj = [join(table1, table2, table1.c.myid == table2.c.otherid).
-                                    outerjoin(table3, table1.c.myid==table3.c.userid)]
-                )
-                ,"SELECT mytable.myid, mytable.name, mytable.description, "
-                "myothertable.otherid, myothertable.othername, thirdtable.userid,"
-                " thirdtable.otherstuff FROM mytable JOIN myothertable ON mytable.myid "
-                "= myothertable.otherid LEFT OUTER JOIN thirdtable ON mytable.myid ="
+                from_obj=[join(table1, table2,
+                                    table1.c.myid == table2.c.otherid).
+                                    outerjoin(table3,
+                                            table1.c.myid == table3.c.userid)]
+                ),
+                "SELECT mytable.myid, mytable.name, mytable.description, "
+                "myothertable.otherid, myothertable.othername, "
+                "thirdtable.userid,"
+                " thirdtable.otherstuff FROM mytable "
+                "JOIN myothertable ON mytable.myid "
+                "= myothertable.otherid LEFT OUTER JOIN thirdtable "
+                "ON mytable.myid ="
                 " thirdtable.userid"
             )
         self.assert_compile(
                 select([table1, table2, table3],
-                from_obj = [outerjoin(table1,
-                                join(table2, table3, table2.c.otherid == table3.c.userid),
-                                table1.c.myid==table2.c.otherid)]
-                )
-                ,"SELECT mytable.myid, mytable.name, mytable.description, "
-                "myothertable.otherid, myothertable.othername, thirdtable.userid,"
-                " thirdtable.otherstuff FROM mytable LEFT OUTER JOIN (myothertable "
-                "JOIN thirdtable ON myothertable.otherid = thirdtable.userid) ON "
+                from_obj=[outerjoin(table1,
+                                join(table2, table3, table2.c.otherid
+                                        == table3.c.userid),
+                                table1.c.myid == table2.c.otherid)]
+                ),
+                "SELECT mytable.myid, mytable.name, mytable.description, "
+                "myothertable.otherid, myothertable.othername, "
+                "thirdtable.userid,"
+                " thirdtable.otherstuff FROM mytable LEFT OUTER JOIN "
+                "(myothertable "
+                "JOIN thirdtable ON myothertable.otherid = "
+                "thirdtable.userid) ON "
                 "mytable.myid = myothertable.otherid"
             )
 
                     table2.c.othername != 'jack',
                     "EXISTS (select yay from foo where boo = lar)"
                 ),
-                from_obj = [ outerjoin(table1, table2, table1.c.myid == table2.c.otherid) ]
+                from_obj=[outerjoin(table1, table2,
+                                table1.c.myid == table2.c.otherid)]
                 )
         self.assert_compile(query,
             "SELECT mytable.myid, mytable.name, mytable.description, "
         x = union(
               select([table1], table1.c.myid == 5),
               select([table1], table1.c.myid == 12),
-              order_by = [table1.c.myid],
+              order_by=[table1.c.myid],
         )
 
-        self.assert_compile(x, "SELECT mytable.myid, mytable.name, mytable.description "\
-                                "FROM mytable WHERE mytable.myid = :myid_1 UNION "\
-                                "SELECT mytable.myid, mytable.name, mytable.description "\
-                                "FROM mytable WHERE mytable.myid = :myid_2 ORDER BY mytable.myid")
+        self.assert_compile(x,
+                    "SELECT mytable.myid, mytable.name, "
+                    "mytable.description "
+                    "FROM mytable WHERE "
+                    "mytable.myid = :myid_1 UNION "
+                    "SELECT mytable.myid, mytable.name, mytable.description "
+                    "FROM mytable WHERE mytable.myid = :myid_2 "
+                    "ORDER BY mytable.myid")
 
         x = union(
               select([table1]),
               select([table1])
         )
         x = union(x, select([table1]))
-        self.assert_compile(x, "(SELECT mytable.myid, mytable.name, mytable.description "
-                                "FROM mytable UNION SELECT mytable.myid, mytable.name, "
-                                "mytable.description FROM mytable) UNION SELECT mytable.myid,"
-                                " mytable.name, mytable.description FROM mytable")
+        self.assert_compile(x,
+                "(SELECT mytable.myid, mytable.name, mytable.description "
+                "FROM mytable UNION SELECT mytable.myid, mytable.name, "
+                "mytable.description FROM mytable) UNION SELECT mytable.myid,"
+                " mytable.name, mytable.description FROM mytable")
 
         u1 = union(
             select([table1.c.myid, table1.c.name]),
             select([table2]),
             select([table3])
         )
-        self.assert_compile(u1, "SELECT mytable.myid, mytable.name "
-                                "FROM mytable UNION SELECT myothertable.otherid, "
-                                "myothertable.othername FROM myothertable "
-                                "UNION SELECT thirdtable.userid, thirdtable.otherstuff "
-                                "FROM thirdtable")
+        self.assert_compile(u1,
+                "SELECT mytable.myid, mytable.name "
+                "FROM mytable UNION SELECT myothertable.otherid, "
+                "myothertable.othername FROM myothertable "
+                "UNION SELECT thirdtable.userid, thirdtable.otherstuff "
+                "FROM thirdtable")
 
         assert u1.corresponding_column(table2.c.otherid) is u1.c.myid
 
                 limit=5
             ),
             "SELECT mytable.myid, mytable.name "
-            "FROM mytable UNION SELECT myothertable.otherid, myothertable.othername "
+            "FROM mytable UNION SELECT myothertable.otherid, "
+            "myothertable.othername "
             "FROM myothertable ORDER BY myid LIMIT :param_1 OFFSET :param_2",
-            {'param_1':5, 'param_2':10}
+            {'param_1': 5, 'param_2': 10}
         )
 
         self.assert_compile(
             union(
-                select([table1.c.myid, table1.c.name, func.max(table1.c.description)],
-                            table1.c.name=='name2',
+                select([table1.c.myid, table1.c.name,
+                            func.max(table1.c.description)],
+                            table1.c.name == 'name2',
                             group_by=[table1.c.myid, table1.c.name]),
-                table1.select(table1.c.name=='name1')
+                table1.select(table1.c.name == 'name1')
             ),
-            "SELECT mytable.myid, mytable.name, max(mytable.description) AS max_1 "
-            "FROM mytable WHERE mytable.name = :name_1 GROUP BY mytable.myid, "
-            "mytable.name UNION SELECT mytable.myid, mytable.name, mytable.description "
+            "SELECT mytable.myid, mytable.name, "
+            "max(mytable.description) AS max_1 "
+            "FROM mytable WHERE mytable.name = :name_1 "
+            "GROUP BY mytable.myid, "
+            "mytable.name UNION SELECT mytable.myid, mytable.name, "
+            "mytable.description "
             "FROM mytable WHERE mytable.name = :name_2"
         )
 
                     select([table2.c.otherid]),
                     select([table3.c.userid]),
                 )
-            )
-            ,
+            ),
+
             "SELECT mytable.myid FROM mytable UNION ALL "
             "(SELECT myothertable.otherid FROM myothertable UNION "
             "SELECT thirdtable.userid FROM thirdtable)"
 
         s = select([column('foo'), column('bar')])
 
-        # ORDER BY's even though not supported by all DB's, are rendered if requested
+        # ORDER BY's even though not supported by
+        # all DB's, are rendered if requested
         self.assert_compile(union(s.order_by("foo"), s.order_by("bar")),
             "SELECT foo, bar ORDER BY foo UNION SELECT foo, bar ORDER BY bar"
         )
         # self_group() is honored
         self.assert_compile(
-            union(s.order_by("foo").self_group(), s.order_by("bar").limit(10).self_group()),
-            "(SELECT foo, bar ORDER BY foo) UNION (SELECT foo, bar ORDER BY bar LIMIT :param_1)",
-            {'param_1':10}
+            union(s.order_by("foo").self_group(),
+                        s.order_by("bar").limit(10).self_group()),
+            "(SELECT foo, bar ORDER BY foo) UNION (SELECT foo, "
+                "bar ORDER BY bar LIMIT :param_1)",
+            {'param_1': 10}
 
         )
 
         self.assert_compile(
             union(s, s, s, s),
             "SELECT foo, bar FROM bat UNION SELECT foo, bar "
-            "FROM bat UNION SELECT foo, bar FROM bat UNION SELECT foo, bar FROM bat"
+            "FROM bat UNION SELECT foo, bar FROM bat "
+            "UNION SELECT foo, bar FROM bat"
         )
 
         self.assert_compile(
             union(s, union(s, union(s, s))),
             "SELECT foo, bar FROM bat UNION (SELECT foo, bar FROM bat "
-            "UNION (SELECT foo, bar FROM bat UNION SELECT foo, bar FROM bat))"
+            "UNION (SELECT foo, bar FROM bat "
+                "UNION SELECT foo, bar FROM bat))"
         )
 
         self.assert_compile(
             select([s.alias()]),
-            'SELECT anon_1.foo, anon_1.bar FROM (SELECT foo, bar FROM bat) AS anon_1'
+            'SELECT anon_1.foo, anon_1.bar FROM '
+            '(SELECT foo, bar FROM bat) AS anon_1'
         )
 
         self.assert_compile(
             select([union(s, s).alias()]),
             'SELECT anon_1.foo, anon_1.bar FROM '
-            '(SELECT foo, bar FROM bat UNION SELECT foo, bar FROM bat) AS anon_1'
+            '(SELECT foo, bar FROM bat UNION '
+                'SELECT foo, bar FROM bat) AS anon_1'
         )
 
         self.assert_compile(
             select([except_(s, s).alias()]),
             'SELECT anon_1.foo, anon_1.bar FROM '
-            '(SELECT foo, bar FROM bat EXCEPT SELECT foo, bar FROM bat) AS anon_1'
+            '(SELECT foo, bar FROM bat EXCEPT '
+                'SELECT foo, bar FROM bat) AS anon_1'
         )
 
         # this query sqlite specifically chokes on
                 s
             ),
             "SELECT anon_1.foo, anon_1.bar FROM "
-            "(SELECT foo, bar FROM bat EXCEPT SELECT foo, bar FROM bat) AS anon_1 "
+            "(SELECT foo, bar FROM bat EXCEPT "
+                "SELECT foo, bar FROM bat) AS anon_1 "
             "UNION SELECT foo, bar FROM bat"
         )
 
                 intersect(s, s)
             ),
             "(SELECT foo, bar FROM bat INTERSECT SELECT foo, bar FROM bat) "
-            "UNION (SELECT foo, bar FROM bat INTERSECT SELECT foo, bar FROM bat)"
+            "UNION (SELECT foo, bar FROM bat INTERSECT "
+                "SELECT foo, bar FROM bat)"
         )
 
     def test_binds(self):
                  {'mytablename':5}, {'mytablename':5}, [5]
              ),
              (
-                 select([table1], or_(table1.c.myid==bindparam('myid'),
-                                        table2.c.otherid==bindparam('myid'))),
+                 select([table1], or_(table1.c.myid == bindparam('myid'),
+                                        table2.c.otherid == bindparam('myid'))),
                  "SELECT mytable.myid, mytable.name, mytable.description "
                         "FROM mytable, myothertable WHERE mytable.myid = :myid "
                         "OR myothertable.otherid = :myid",
                  "SELECT mytable.myid, mytable.name, mytable.description "
                         "FROM mytable, myothertable WHERE mytable.myid = ? "
                         "OR myothertable.otherid = ?",
-                 {'myid':None}, [None, None],
-                 {'myid':5}, {'myid':5}, [5,5]
+                 {'myid': None}, [None, None],
+                 {'myid': 5}, {'myid': 5}, [5, 5]
              ),
              (
                  text("SELECT mytable.myid, mytable.name, mytable.description FROM "
-                                "mytable, myothertable WHERE mytable.myid = :myid OR "
-                                "myothertable.otherid = :myid"),
+                            "mytable, myothertable WHERE mytable.myid = :myid OR "
+                            "myothertable.otherid = :myid"),
                  "SELECT mytable.myid, mytable.name, mytable.description FROM "
-                                "mytable, myothertable WHERE mytable.myid = :myid OR "
-                                "myothertable.otherid = :myid",
+                            "mytable, myothertable WHERE mytable.myid = :myid OR "
+                            "myothertable.otherid = :myid",
                  "SELECT mytable.myid, mytable.name, mytable.description FROM "
-                                "mytable, myothertable WHERE mytable.myid = ? OR "
-                                "myothertable.otherid = ?",
+                            "mytable, myothertable WHERE mytable.myid = ? OR "
+                            "myothertable.otherid = ?",
                  {'myid':None}, [None, None],
-                 {'myid':5}, {'myid':5}, [5,5]
+                 {'myid': 5}, {'myid': 5}, [5, 5]
              ),
              (
-                 select([table1], or_(table1.c.myid==bindparam('myid', unique=True),
-                                    table2.c.otherid==bindparam('myid', unique=True))),
+                 select([table1], or_(table1.c.myid ==
+                                    bindparam('myid', unique=True),
+                                    table2.c.otherid ==
+                                    bindparam('myid', unique=True))),
                  "SELECT mytable.myid, mytable.name, mytable.description FROM "
                                 "mytable, myothertable WHERE mytable.myid = "
                                 ":myid_1 OR myothertable.otherid = :myid_2",
                                 "mytable, myothertable WHERE mytable.myid = ? "
                                 "OR myothertable.otherid = ?",
                  {'myid_1':None, 'myid_2':None}, [None, None],
-                 {'myid_1':5, 'myid_2': 6}, {'myid_1':5, 'myid_2':6}, [5,6]
+                 {'myid_1': 5, 'myid_2': 6}, {'myid_1': 5, 'myid_2': 6}, [5, 6]
              ),
              (
                 bindparam('test', type_=String, required=False) + text("'hi'"),
              (
                 # testing select.params() here - bindparam() objects
                 # must get required flag set to False
-                 select([table1], or_(table1.c.myid==bindparam('myid'),
-                                    table2.c.otherid==bindparam('myotherid'))).\
+                 select([table1], or_(table1.c.myid == bindparam('myid'),
+                                    table2.c.otherid == bindparam('myotherid'))).\
                                         params({'myid':8, 'myotherid':7}),
                  "SELECT mytable.myid, mytable.name, mytable.description FROM "
                                     "mytable, myothertable WHERE mytable.myid = "
                  "SELECT mytable.myid, mytable.name, mytable.description FROM "
                                     "mytable, myothertable WHERE mytable.myid = "
                                     "? OR myothertable.otherid = ?",
-                 {'myid':8, 'myotherid':7}, [8, 7],
-                 {'myid':5}, {'myid':5, 'myotherid':7}, [5,7]
+                 {'myid': 8, 'myotherid': 7}, [8, 7],
+                 {'myid': 5}, {'myid': 5, 'myotherid': 7}, [5, 7]
              ),
              (
-                 select([table1], or_(table1.c.myid==bindparam('myid', value=7, unique=True),
-                                    table2.c.otherid==bindparam('myid', value=8, unique=True))),
+                 select([table1], or_(table1.c.myid ==
+                                    bindparam('myid', value=7, unique=True),
+                                    table2.c.otherid ==
+                                    bindparam('myid', value=8, unique=True))),
                  "SELECT mytable.myid, mytable.name, mytable.description FROM "
                                     "mytable, myothertable WHERE mytable.myid = "
                                     ":myid_1 OR myothertable.otherid = :myid_2",
                  "SELECT mytable.myid, mytable.name, mytable.description FROM "
                                     "mytable, myothertable WHERE mytable.myid = "
                                     "? OR myothertable.otherid = ?",
-                 {'myid_1':7, 'myid_2':8}, [7,8],
-                 {'myid_1':5, 'myid_2':6}, {'myid_1':5, 'myid_2':6}, [5,6]
+                 {'myid_1': 7, 'myid_2': 8}, [7, 8],
+                 {'myid_1': 5, 'myid_2': 6}, {'myid_1': 5, 'myid_2': 6}, [5, 6]
              ),
              ]:
 
-                self.assert_compile(stmt, expected_named_stmt, params=expected_default_params_dict)
-                self.assert_compile(stmt, expected_positional_stmt, dialect=sqlite.dialect())
+                self.assert_compile(stmt, expected_named_stmt,
+                            params=expected_default_params_dict)
+                self.assert_compile(stmt, expected_positional_stmt,
+                            dialect=sqlite.dialect())
                 nonpositional = stmt.compile()
                 positional = stmt.compile(dialect=sqlite.dialect())
                 pp = positional.params
-                assert [pp[k] for k in positional.positiontup] == expected_default_params_list
-                assert nonpositional.construct_params(test_param_dict) == expected_test_params_dict, \
-                                    "expected :%s got %s" % (str(expected_test_params_dict), \
-                                    str(nonpositional.get_params(**test_param_dict)))
+                eq_([pp[k] for k in positional.positiontup],
+                                    expected_default_params_list)
+
+                eq_(nonpositional.construct_params(test_param_dict),
+                                    expected_test_params_dict)
                 pp = positional.construct_params(test_param_dict)
-                assert [pp[k] for k in positional.positiontup] == expected_test_params_list
+                eq_(
+                        [pp[k] for k in positional.positiontup],
+                        expected_test_params_list
+                )
 
         # check that params() doesnt modify original statement
-        s = select([table1], or_(table1.c.myid==bindparam('myid'),
-                                    table2.c.otherid==bindparam('myotherid')))
-        s2 = s.params({'myid':8, 'myotherid':7})
-        s3 = s2.params({'myid':9})
-        assert s.compile().params == {'myid':None, 'myotherid':None}
-        assert s2.compile().params == {'myid':8, 'myotherid':7}
-        assert s3.compile().params == {'myid':9, 'myotherid':7}
+        s = select([table1], or_(table1.c.myid == bindparam('myid'),
+                                    table2.c.otherid ==
+                                        bindparam('myotherid')))
+        s2 = s.params({'myid': 8, 'myotherid': 7})
+        s3 = s2.params({'myid': 9})
+        assert s.compile().params == {'myid': None, 'myotherid': None}
+        assert s2.compile().params == {'myid': 8, 'myotherid': 7}
+        assert s3.compile().params == {'myid': 9, 'myotherid': 7}
 
         # test using same 'unique' param object twice in one compile
-        s = select([table1.c.myid]).where(table1.c.myid==12).as_scalar()
-        s2 = select([table1, s], table1.c.myid==s)
+        s = select([table1.c.myid]).where(table1.c.myid == 12).as_scalar()
+        s2 = select([table1, s], table1.c.myid == s)
         self.assert_compile(s2,
             "SELECT mytable.myid, mytable.name, mytable.description, "
             "(SELECT mytable.myid FROM mytable WHERE mytable.myid = "\
         assert [pp[k] for k in positional.positiontup] == [12, 12]
 
         # check that conflicts with "unique" params are caught
-        s = select([table1], or_(table1.c.myid==7,
-                                        table1.c.myid==bindparam('myid_1')))
+        s = select([table1], or_(table1.c.myid == 7,
+                                        table1.c.myid == bindparam('myid_1')))
         assert_raises_message(exc.CompileError,
                                 "conflicts with unique bind parameter "
                                 "of the same name",
                                 str, s)
 
-        s = select([table1], or_(table1.c.myid==7, table1.c.myid==8,
-                                        table1.c.myid==bindparam('myid_1')))
+        s = select([table1], or_(table1.c.myid == 7, table1.c.myid == 8,
+                                        table1.c.myid == bindparam('myid_1')))
         assert_raises_message(exc.CompileError,
                                 "conflicts with unique bind parameter "
                                 "of the same name",
                                 str, s)
 
-    def test_binds_no_hash_collision(self):
-        """test that construct_params doesn't corrupt dict due to hash collisions"""
+    def _test_binds_no_hash_collision(self):
+        """test that construct_params doesn't corrupt dict
+            due to hash collisions"""
 
         total_params = 100000
 
         in_clause = [':in%d' % i for i in range(total_params)]
         params = dict(('in%d' % i, i) for i in range(total_params))
-        sql = 'text clause %s' % ', '.join(in_clause)
-        t = text(sql)
+        t = text('text clause %s' % ', '.join(in_clause))
         eq_(len(t.bindparams), total_params)
         c = t.compile()
         pp = c.construct_params(params)
             r"A value is required for bind parameter 'x'",
             select([table1]).where(
                     and_(
-                        table1.c.myid==bindparam("x", required=True),
-                        table1.c.name==bindparam("y", required=True)
+                        table1.c.myid == bindparam("x", required=True),
+                        table1.c.name == bindparam("y", required=True)
                     )
                 ).compile().construct_params,
             params=dict(y=5)
         assert_raises_message(exc.InvalidRequestError,
             r"A value is required for bind parameter 'x'",
             select([table1]).where(
-                    table1.c.myid==bindparam("x", required=True)
+                    table1.c.myid == bindparam("x", required=True)
                 ).compile().construct_params
         )
 
                 "in parameter group 2",
             select([table1]).where(
                     and_(
-                        table1.c.myid==bindparam("x", required=True),
-                        table1.c.name==bindparam("y", required=True)
+                        table1.c.myid == bindparam("x", required=True),
+                        table1.c.name == bindparam("y", required=True)
                     )
                 ).compile().construct_params,
             params=dict(y=5),
             r"A value is required for bind parameter 'x', "
                 "in parameter group 2",
             select([table1]).where(
-                    table1.c.myid==bindparam("x", required=True)
+                    table1.c.myid == bindparam("x", required=True)
                 ).compile().construct_params,
             _group_number=2
         )
 
 
 
-    @testing.emits_warning('.*empty sequence.*')
-    def test_in(self):
-        self.assert_compile(table1.c.myid.in_(['a']),
-        "mytable.myid IN (:myid_1)")
-
-        self.assert_compile(~table1.c.myid.in_(['a']),
-        "mytable.myid NOT IN (:myid_1)")
-
-        self.assert_compile(table1.c.myid.in_(['a', 'b']),
-        "mytable.myid IN (:myid_1, :myid_2)")
-
-        self.assert_compile(table1.c.myid.in_(iter(['a', 'b'])),
-        "mytable.myid IN (:myid_1, :myid_2)")
-
-        self.assert_compile(table1.c.myid.in_([literal('a')]),
-        "mytable.myid IN (:param_1)")
-
-        self.assert_compile(table1.c.myid.in_([literal('a'), 'b']),
-        "mytable.myid IN (:param_1, :myid_1)")
-
-        self.assert_compile(table1.c.myid.in_([literal('a'), literal('b')]),
-        "mytable.myid IN (:param_1, :param_2)")
-
-        self.assert_compile(table1.c.myid.in_(['a', literal('b')]),
-        "mytable.myid IN (:myid_1, :param_1)")
-
-        self.assert_compile(table1.c.myid.in_([literal(1) + 'a']),
-        "mytable.myid IN (:param_1 + :param_2)")
-
-        self.assert_compile(table1.c.myid.in_([literal('a') +'a', 'b']),
-        "mytable.myid IN (:param_1 || :param_2, :myid_1)")
-
-        self.assert_compile(table1.c.myid.in_([literal('a') + literal('a'), literal('b')]),
-        "mytable.myid IN (:param_1 || :param_2, :param_3)")
-
-        self.assert_compile(table1.c.myid.in_([1, literal(3) + 4]),
-        "mytable.myid IN (:myid_1, :param_1 + :param_2)")
-
-        self.assert_compile(table1.c.myid.in_([literal('a') < 'b']),
-        "mytable.myid IN (:param_1 < :param_2)")
-
-        self.assert_compile(table1.c.myid.in_([table1.c.myid]),
-        "mytable.myid IN (mytable.myid)")
-
-        self.assert_compile(table1.c.myid.in_(['a', table1.c.myid]),
-        "mytable.myid IN (:myid_1, mytable.myid)")
-
-        self.assert_compile(table1.c.myid.in_([literal('a'), table1.c.myid]),
-        "mytable.myid IN (:param_1, mytable.myid)")
-
-        self.assert_compile(table1.c.myid.in_([literal('a'), table1.c.myid + 'a']),
-        "mytable.myid IN (:param_1, mytable.myid + :myid_1)")
-
-        self.assert_compile(table1.c.myid.in_([literal(1), 'a' + table1.c.myid]),
-        "mytable.myid IN (:param_1, :myid_1 + mytable.myid)")
-
-        self.assert_compile(table1.c.myid.in_([1, 2, 3]),
-        "mytable.myid IN (:myid_1, :myid_2, :myid_3)")
-
-        self.assert_compile(table1.c.myid.in_(select([table2.c.otherid])),
-        "mytable.myid IN (SELECT myothertable.otherid FROM myothertable)")
-
-        self.assert_compile(~table1.c.myid.in_(select([table2.c.otherid])),
-        "mytable.myid NOT IN (SELECT myothertable.otherid FROM myothertable)")
-
-        # text
+
+    def test_tuple(self):
         self.assert_compile(
-                table1.c.myid.in_(
-                        text("SELECT myothertable.otherid FROM myothertable")
-                    ),
-                    "mytable.myid IN (SELECT myothertable.otherid "
-                    "FROM myothertable)"
-        )
-
-        # test empty in clause
-        self.assert_compile(table1.c.myid.in_([]),
-        "mytable.myid != mytable.myid")
-
-        self.assert_compile(
-            select([table1.c.myid.in_(select([table2.c.otherid]))]),
-            "SELECT mytable.myid IN (SELECT myothertable.otherid "
-                "FROM myothertable) AS anon_1 FROM mytable"
-        )
-        self.assert_compile(
-            select([table1.c.myid.in_(select([table2.c.otherid]).as_scalar())]),
-            "SELECT mytable.myid IN (SELECT myothertable.otherid "
-                "FROM myothertable) AS anon_1 FROM mytable"
-        )
-
-        self.assert_compile(table1.c.myid.in_(
-            union(
-                  select([table1.c.myid], table1.c.myid == 5),
-                  select([table1.c.myid], table1.c.myid == 12),
-            )
-        ), "mytable.myid IN ("\
-        "SELECT mytable.myid FROM mytable WHERE mytable.myid = :myid_1 "\
-        "UNION SELECT mytable.myid FROM mytable WHERE mytable.myid = :myid_2)")
-
-        # test that putting a select in an IN clause does not
-        # blow away its ORDER BY clause
-        self.assert_compile(
-            select([table1, table2],
-                table2.c.otherid.in_(
-                    select([table2.c.otherid], order_by=[table2.c.othername],
-                                        limit=10, correlate=False)
-                ),
-                from_obj=[table1.join(table2,
-                            table1.c.myid == table2.c.otherid)],
-                order_by=[table1.c.myid]
-            ),
-            "SELECT mytable.myid, mytable.name, mytable.description, "
-            "myothertable.otherid, myothertable.othername FROM mytable "\
-            "JOIN myothertable ON mytable.myid = myothertable.otherid "
-            "WHERE myothertable.otherid IN (SELECT myothertable.otherid "\
-            "FROM myothertable ORDER BY myothertable.othername "
-            "LIMIT :param_1) ORDER BY mytable.myid",
-            {'param_1':10}
-        )
-
-    def test_tuple(self):
-        self.assert_compile(tuple_(table1.c.myid, table1.c.name).in_([(1, 'foo'), (5, 'bar')]),
-            "(mytable.myid, mytable.name) IN ((:param_1, :param_2), (:param_3, :param_4))"
+            tuple_(table1.c.myid, table1.c.name).in_(
+                    [(1, 'foo'), (5, 'bar')]),
+            "(mytable.myid, mytable.name) IN "
+            "((:param_1, :param_2), (:param_3, :param_4))"
         )
 
         self.assert_compile(
             tuple_(table1.c.myid, table1.c.name).in_(
                         [tuple_(table2.c.otherid, table2.c.othername)]
                     ),
-            "(mytable.myid, mytable.name) IN ((myothertable.otherid, myothertable.othername))"
+            "(mytable.myid, mytable.name) IN "
+            "((myothertable.otherid, myothertable.othername))"
         )
 
         self.assert_compile(
             eq_(str(cast(1234, Text).compile(dialect=dialect)),
                             'CAST(%s AS %s)' % (literal, expected_results[3]))
             eq_(str(cast('test', String(20)).compile(dialect=dialect)),
-                            'CAST(%s AS %s)' %(literal, expected_results[4]))
+                            'CAST(%s AS %s)' % (literal, expected_results[4]))
+
             # fixme: shoving all of this dialect-specific stuff in one test
             # is now officialy completely ridiculous AND non-obviously omits
             # coverage on other dialects.
                         "anon_1 \nFROM casttest")
 
         # first test with PostgreSQL engine
-        check_results(postgresql.dialect(), ['NUMERIC', 'NUMERIC(12, 9)'
-                      , 'DATE', 'TEXT', 'VARCHAR(20)'], '%(param_1)s')
+        check_results(postgresql.dialect(), ['NUMERIC', 'NUMERIC(12, 9)',
+                       'DATE', 'TEXT', 'VARCHAR(20)'], '%(param_1)s')
 
         # then the Oracle engine
         check_results(oracle.dialect(), ['NUMERIC', 'NUMERIC(12, 9)',
         table = Table('dt', metadata,
             Column('date', Date))
         self.assert_compile(
-            table.select(table.c.date.between(datetime.date(2006,6,1),
-                                            datetime.date(2006,6,5))),
+            table.select(table.c.date.between(datetime.date(2006, 6, 1),
+                                            datetime.date(2006, 6, 5))),
             "SELECT dt.date FROM dt WHERE dt.date BETWEEN :date_1 AND :date_2",
-            checkparams={'date_1':datetime.date(2006,6,1),
-                            'date_2':datetime.date(2006,6,5)})
+            checkparams={'date_1': datetime.date(2006, 6, 1),
+                            'date_2': datetime.date(2006, 6, 5)})
 
         self.assert_compile(
-            table.select(sql.between(table.c.date, datetime.date(2006,6,1),
-                                        datetime.date(2006,6,5))),
+            table.select(sql.between(table.c.date, datetime.date(2006, 6, 1),
+                                        datetime.date(2006, 6, 5))),
             "SELECT dt.date FROM dt WHERE dt.date BETWEEN :date_1 AND :date_2",
-            checkparams={'date_1':datetime.date(2006,6,1),
-                            'date_2':datetime.date(2006,6,5)})
+            checkparams={'date_1': datetime.date(2006, 6, 1),
+                            'date_2': datetime.date(2006, 6, 5)})
 
 
     def test_delayed_col_naming(self):
         t1 = Table('mytable', meta, Column('col1', Integer))
 
         exprs = (
-            table1.c.myid==12,
+            table1.c.myid == 12,
             func.hoho(table1.c.myid),
             cast(table1.c.name, Numeric)
         )
             (table1.c.name, 'name', 'mytable.name', None),
             (exprs[0], str(exprs[0]), 'mytable.myid = :myid_1', 'anon_1'),
             (exprs[1], str(exprs[1]), 'hoho(mytable.myid)', 'hoho_1'),
-            (exprs[2], str(exprs[2]), 'CAST(mytable.name AS NUMERIC)', 'anon_1'),
+            (exprs[2], str(exprs[2]),
+                        'CAST(mytable.name AS NUMERIC)', 'anon_1'),
             (t1.c.col1, 'col1', 'mytable.col1', None),
-            (column('some wacky thing'), 'some wacky thing', '"some wacky thing"', '')
+            (column('some wacky thing'), 'some wacky thing',
+                '"some wacky thing"', '')
         ):
             if getattr(col, 'table', None) is not None:
                 t = col.table
             assert s1.c.keys() == [key], s1.c.keys()
 
             if label:
-                self.assert_compile(s1, "SELECT %s AS %s FROM mytable" % (expr, label))
+                self.assert_compile(s1,
+                        "SELECT %s AS %s FROM mytable" % (expr, label))
             else:
                 self.assert_compile(s1, "SELECT %s FROM mytable" % (expr,))
 
                 # sqlite rule labels subquery columns
                 self.assert_compile(s1,
                             "SELECT %s FROM (SELECT %s AS %s FROM mytable)" %
-                            (key,expr, key))
+                            (key, expr, key))
             else:
                 self.assert_compile(s1,
                             "SELECT %s FROM (SELECT %s FROM mytable)" %
-                            (expr,expr))
+                            (expr, expr))
 
     def test_hints(self):
         s = select([table1.c.myid]).with_hint(table1, "test hint %(name)s")
 
         subs4 = select([
             table1, table2
-        ]).select_from(table1.join(table2, table1.c.myid==table2.c.otherid)).\
+        ]).select_from(table1.join(table2, table1.c.myid == table2.c.otherid)).\
             with_hint(table1, 'hint1')
 
         s4 = select([table3]).select_from(
                         table3.join(
                                 subs4,
-                                subs4.c.othername==table3.c.otherstuff
+                                subs4.c.othername == table3.c.otherstuff
                             )
                     ).\
                     with_hint(table3, 'hint3')
 
-        subs5 = select([
-            table1, table2
-        ]).select_from(table1.join(table2, table1.c.myid==table2.c.otherid))
-        s5 = select([table3]).select_from(
-                        table3.join(
-                                subs5,
-                                subs5.c.othername==table3.c.otherstuff
-                            )
-                    ).\
-                    with_hint(table3, 'hint3').\
-                    with_hint(table1, 'hint1')
 
         t1 = table('QuotedName', column('col1'))
-        s6 = select([t1.c.col1]).where(t1.c.col1>10).with_hint(t1, '%(name)s idx1')
+        s6 = select([t1.c.col1]).where(t1.c.col1 > 10).\
+                    with_hint(t1, '%(name)s idx1')
         a2 = t1.alias('SomeName')
-        s7 = select([a2.c.col1]).where(a2.c.col1>10).with_hint(a2, '%(name)s idx1')
+        s7 = select([a2.c.col1]).where(a2.c.col1 > 10).\
+                    with_hint(a2, '%(name)s idx1')
 
         mysql_d, oracle_d, sybase_d = \
                             mysql.dialect(), \
         # cols provided literally
         self.assert_compile(
             insert(table1, {
-                            table1.c.myid : bindparam('userid'),
-                            table1.c.name : bindparam('username')}),
+                            table1.c.myid: bindparam('userid'),
+                            table1.c.name: bindparam('username')}),
             "INSERT INTO mytable (myid, name) VALUES (:userid, :username)")
 
         # insert with user-supplied bind params for specific columns, cols
         # provided as strings
         self.assert_compile(
-            insert(table1, dict(myid = 3, name = 'jack')),
+            insert(table1, dict(myid=3, name='jack')),
             "INSERT INTO mytable (myid, name) VALUES (:myid, :name)"
         )
 
         # test with a tuple of params instead of named
         self.assert_compile(
             insert(table1, (3, 'jack', 'mydescription')),
-            "INSERT INTO mytable (myid, name, description) VALUES (:myid, :name, :description)",
-            checkparams = {'myid':3, 'name':'jack', 'description':'mydescription'}
+            "INSERT INTO mytable (myid, name, description) VALUES "
+            "(:myid, :name, :description)",
+            checkparams={
+                'myid': 3, 'name': 'jack', 'description': 'mydescription'}
         )