15aa4a0·Author: Paul Hargrove·Closed by: Paul Hargrove·2018-05-15
Description
coll: remove unreachable } added just for editor
This commit removes a '}' guarded by #if 0 (which appears to have been added simply to satisfy smart editors) while eliminating the duplication of the corresponding '{'.
coll: remove cloned "default" entry points
This commit removes #if 0-guarded instances of the default collective entry points. These appear to have been preserved as a fall-back if the autotuner logic was removed. However, the corresponding algorithm selection is also preserved within the autotuner as the defaults.
Attempts to enable and compile these clones was successfully, but the resulting builds hang in testcoll/testcollperf, indicating that something (not worth tracking down) had fallen into disrepair.
coll: repair all-threads-poll case
This commit makes minor modifications to the "ALL_THREADS_POLL" logic in gasnet_refcoll.c (which is disabled by default). These changes are sufficient to allow the alternate code paths to compile and pass tests.
coll: remove unreachable } added just for editor
This commit removes a '}' guarded by
#if 0(which appears to have been added simply to satisfy smart editors) while eliminating the duplication of the corresponding '{'.coll: remove cloned "default" entry points
This commit removes
#if 0-guarded instances of the default collective entry points. These appear to have been preserved as a fall-back if the autotuner logic was removed. However, the corresponding algorithm selection is also preserved within the autotuner as the defaults.Attempts to enable and compile these clones was successfully, but the resulting builds hang in testcoll/testcollperf, indicating that something (not worth tracking down) had fallen into disrepair.
coll: repair all-threads-poll case
This commit makes minor modifications to the "ALL_THREADS_POLL" logic in gasnet_refcoll.c (which is disabled by default). These changes are sufficient to allow the alternate code paths to compile and pass tests.
tests: fix thread race in testcollperf