Typos in computational collectives spec

Issue #114 resolved
Former user created an issue

Originally reported on Google Code with ID 114

From Steve via email (entering a ticket for the record):

There are a few typos in the synopsis for the computational collectives (7.4.3) in
the required library spec.  
First, 'upc_all_reduce_<<T>>' should be 'upc_all_reduce<<T>>' (no '_' between reduce
and type suffix).  
Second, the 'src' argument for both upc_all_reduce<<T>> and upc_all_prefix_reduce<<T>>
should be typed 'shared const void * restrict' rather than 'void shared const void
* restrict'.  
Similarly, the 'blk_size' argument for both should be typed 'size_t' rather than 'void
size_t'.

Reported by danbonachea on 2013-08-03 03:59:51

Comments (1)

  1. Former user Account Deleted
    It appears these typos were all introduced in the reformatting document split performed
    at the start of the 1.3 process. The signatures were correct in the 1.2 spec, so no
    change annotation or ratification process is required to revert the accidental regression.
    
    Below committed as SVN 221
    
    --- upc-lib-collectives.tex     (revision 219)
    +++ upc-lib-collectives.tex     (working copy)
    @@ -593,20 +593,20 @@
     \npf
     \begin{verbatim}
     #include <upc_collective.h>
    -void upc_all_reduce_<<T>>(
    +void upc_all_reduce<<T>>(
             shared void * restrict dst,
    -        void shared const void * restrict src,
    +        shared const void * restrict src,
             upc_op_t op,
             size_t nelems,
    -        void size_t blk_size,
    +        size_t blk_size,
             <<TYPE>>(*func)(<<TYPE>>, <<TYPE>>),
             upc_flag_t flags);
     void upc_all_prefix_reduce<<T>>(
             shared void * restrict dst,
    -        void  shared const void * restrict src,
    +        shared const void * restrict src,
             upc_op_t op,
             size_t nelems,
    -        void size_t blk_size,
    +        size_t blk_size,
             <<TYPE>>(*func)(<<TYPE>>, <<TYPE>>),
             upc_flag_t flags);
     \end{verbatim}
    

    Reported by danbonachea on 2013-08-03 04:09:58 - Status changed: Fixed

  2. Log in to comment