sys_info output is outdated and incomplete

[Dan Bonachea]

From utils/system-checks.sh:sys_info() @ 52d6a0d :

/bin/sh local SETTINGS= for var in CC CXX GASNET GASNET_CONFIGURE_ARGS CROSS OPTLEV DBGSYM \ UPCXX_BACKEND GASNET_INSTALL_TO \ UPCXX_CODEMODE UPCXX_THREADMODE \ UPCXX_CUDA \ ; do if test "${!var:+set}" = set; then SETTINGS="$SETTINGS $var='${!var}'" fi done echo "Settings:$SETTINGS" echo " " fpy=${UPCXX_PYTHON:-$(type -p python)} echo "$fpy: " $($fpy --version 2>&1)

The variable list is woefully out-of-date, resulting in build-logs that are incomplete or print irrelevant values.

I believe all of the following have no effect (any longer) when set by the caller of configure: GASNET_INSTALL_TO, UPCXX_BACKEND, UPCXX_CODEMODE UPCXX_THREADMODE OPTLEV DBGSYM

On the other hand, important vars such as the following should probably be included: CXXFLAGS CFLAGS CPPFLAGS LDFLAGS LIBS GMAKE UPCXX_PYTHON

Next regarding placement: the idea is to document the user inputs, because the GASNet configure line echoed later already shows munged values. sys_info() call should be moved earlier in configure, or at least echo the original inputs before all the processing we do.

In particular, this affects the values of at least:

• UPCXX_PYTHON
• GASNET
• GASNET_CONFIGURE_ARGS

Finally I'd like to see us capture and output the literal, unprocessed configure args that the user provided. This is to help reproducibility via user support channels, where we may have only the console log (which is what we ask users to report), and the file system build logs may already be deleted or otherwise inaccessible to support personnel.

[Paul Hargrove]

proposed resolution in pull request 198

[Paul Hargrove]

configure: updated configure output

This commit resolves issue 351 by making numerous changes to the shell function sys_info as well as to the context in which it is called. The main user-visible changes include:

1. The full configure command line is included in the output
2. "Settings" is now "Configure environment" and one var per line
3. Env vars no longer used have been removed from output
4. Influential env vars previously missing have been added

Additional changes:

1. The call to sys_info now precedes the probe for a usable Python interpreter and the user-facing version reporting has consequently moved from sys_info to the probe itself. It still honors the setting UPCXX_INSTALL_QUIET.
2. The last instance of legacy variable $install_to has been replaced by $PREFIX.

→ <<cset a2e4fb589963>>