improve default network selection
Currently, only the case of cross-compilation for the Cray XC has a proper default network.
All other cases have upcxx
and make check
defaulting to smp.
Since the use of upcxxx
(and thus the "real work" of make check
) cannot precede the build of GASNet, it seems reasonable that we interrogate the GASNet configure outputs (meaning generated files, not stdout) for a default network.
Comments (7)
-
-
-
assigned issue to
-
assigned issue to
-
- changed milestone to 2021.3.0 release
Mass roll-over of open issues to next release milestone
-
- changed milestone to 2021.9.0 release
Mass roll-over of open issues to next release milestone
-
reporter I went to attempt this work today and ran into an unexpected hurdle:
Currently
configure
encodes the default network into thebin/upcxx-meta
it generates. So, either the generation of that wrapper needs to be deferred until after GASNet is configured or some level of indirection is needed. Either one faces a "chicken and egg" problem if the wrapper runs before GASNet is configured (currently a valid/supported scenario). This will require more thought some other time. -
reporter - changed status to open
Proposed resolution now in pull request #350
-
reporter - changed status to resolved
Move default network selection to post-configure
This commit resolves issue 354 (improve default network selection) by deferring selection of a default network conduit in most cases.
Now only cross-compilation for Cray systems, and the use of
--with-default-network=...
establish a default network at configure time. For all other cases, the default network is established after GASNet is configured, by taking the "best" network which is officially supported by UPC++ and located by GASNet's configure.The original plan was to use a script in
utils/config/gasnet
, but that turns out to have a circular dependency: those scripts are to be run with the environment mirroring the settings in the makefile fragment of the (not yet determined) default network. So, the approach taken in this commit is to inline the selection logic intobld/Makefile
to run between GASNet'sconfigure
and the runs of the scripts inutils/config/gasnet
.→ <<cset e7b16b3fd308>>
- Log in to comment
Now that we have pull request #242: