install --single installs incomplete/broken GASNet headers

Issue #54 resolved
Dan Bonachea created an issue

New install --single in a0d6e07 is still installing a broken version of the gasnet headers into "$root/include".

Here is an example with an external GASNet build tree:

{pcp-d-5 ~/UPC/upcxx} rm -Rf .nobs/ ; env GASNET=/home/pcp1/bonachea/UPC/bupcr-ex/dbg/gasnet DBGSYM=1 OPTLEV=0 ./install --single test7
./install: line 17: [: --single: integer expression expected
UPCXX revision: a0d6e07
System: Linux pcp-d-5 3.10.0-693.1.1.el7.x86_64 #1 SMP Tue Aug 15 08:36:44 CDT 2017 x86_64 x86_64 x86_64 GNU/Linux
LSB Version:    :core-4.1-amd64:core-4.1-noarch
Distributor ID: Scientific
Description:    Scientific Linux release 7.3 (Nitrogen)
Release:        7.3
Codename:       Nitrogen

Date: Fri Sep 22 14:49:42 PDT 2017
Current directory: /home/pcp1/bonachea/UPC/upcxx
Install directory:
Settings: GASNET='/home/pcp1/bonachea/UPC/bupcr-ex/dbg/gasnet' OPTLEV='0' DBGSYM='1'

/usr/local/pkg/gcc/7.2.0/bin/g++
g++ (GCC) 7.2.0
Copyright (C) 2017 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

/usr/local/pkg/gcc/7.2.0/bin/gcc
gcc (GCC) 7.2.0
Copyright (C) 2017 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.


Building GASNet (conduit=smp, threading=seq)...
(in /home/pcp1/bonachea/UPC/bupcr-ex/dbg/gasnet/smp-conduit)
make seq

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
make seq

../other/Makefile-conduit.mak:270: warning: overriding recipe for target 'Makefile'
Makefile:597: warning: ignoring old recipe for target 'Makefile'
make[1]: Entering directory '/home/pcp1/bonachea/UPC/bupcr-ex/dbg/gasnet/smp-conduit'
../other/Makefile-conduit.mak:270: warning: overriding recipe for target 'Makefile'
Makefile:597: warning: ignoring old recipe for target 'Makefile'
make[1]: 'gasnet-smp-seq.pc' is up to date.
make[1]: 'libgasnet-smp-seq.a' is up to date.
make[1]: Leaving directory '/home/pcp1/bonachea/UPC/bupcr-ex/dbg/gasnet/smp-conduit'
g++ -std=c++11 -D_GNU_SOURCE=1 -I/home/pcp1/bonachea/UPC/upcxx/.nobs/art/0a7ba1ef0158d03f0d7127ade4a98b19e09f7572 -DUPCXX_BACKEND=gasnet1_seq -D_GNU_SOURCE=1 -DGASNET_SEQ -I/home/pcp1/bonachea/UPC/upcr-ex/gasnet -I/home/pcp1/bonachea/UPC/upcr-ex/gasnet/smp-conduit -I/home/pcp1/bonachea/UPC/upcr-ex/gasnet/other -I/home/pcp1/bonachea/UPC/upcr-ex/gasnet/extended-ref -I/home/pcp1/bonachea/UPC/bupcr-ex/dbg/gasnet -MM -MT x /home/pcp1/bonachea/UPC/upcxx/src/upcxx.cpp

g++ -std=c++11 -D_GNU_SOURCE=1 -I/home/pcp1/bonachea/UPC/upcxx/.nobs/art/0a7ba1ef0158d03f0d7127ade4a98b19e09f7572 -DUPCXX_BACKEND=gasnet1_seq -D_GNU_SOURCE=1 -DGASNET_SEQ -I/home/pcp1/bonachea/UPC/upcr-ex/gasnet -I/home/pcp1/bonachea/UPC/upcr-ex/gasnet/smp-conduit -I/home/pcp1/bonachea/UPC/upcr-ex/gasnet/other -I/home/pcp1/bonachea/UPC/upcr-ex/gasnet/extended-ref -I/home/pcp1/bonachea/UPC/bupcr-ex/dbg/gasnet -O0 -g -Wall -g3 -Wall -Wpointer-arith -Wwrite-strings -Wmissing-format-attribute -Wno-unused -Wno-unused-parameter -Wno-address -c /home/pcp1/bonachea/UPC/upcxx/src/upcxx.cpp -o /home/pcp1/bonachea/UPC/upcxx/.nobs/art/ebb215779cecbc141a5ceffba2e89af74d51c944.upcxx.cpp.o

g++ -std=c++11 -D_GNU_SOURCE=1 -I/home/pcp1/bonachea/UPC/upcxx/.nobs/art/0a7ba1ef0158d03f0d7127ade4a98b19e09f7572 -MM -MT x /home/pcp1/bonachea/UPC/upcxx/src/diagnostic.cpp

g++ -std=c++11 -D_GNU_SOURCE=1 -I/home/pcp1/bonachea/UPC/upcxx/.nobs/art/0a7ba1ef0158d03f0d7127ade4a98b19e09f7572 -MM -MT x /home/pcp1/bonachea/UPC/upcxx/src/future/core.cpp

g++ -std=c++11 -D_GNU_SOURCE=1 -I/home/pcp1/bonachea/UPC/upcxx/.nobs/art/0a7ba1ef0158d03f0d7127ade4a98b19e09f7572 -MM -MT x /home/pcp1/bonachea/UPC/upcxx/src/persona.cpp

g++ -std=c++11 -D_GNU_SOURCE=1 -I/home/pcp1/bonachea/UPC/upcxx/.nobs/art/0a7ba1ef0158d03f0d7127ade4a98b19e09f7572 -MM -MT x /home/pcp1/bonachea/UPC/upcxx/src/lpc_inbox.cpp

g++ -std=c++11 -D_GNU_SOURCE=1 -I/home/pcp1/bonachea/UPC/upcxx/.nobs/art/0a7ba1ef0158d03f0d7127ade4a98b19e09f7572 -MM -MT x /home/pcp1/bonachea/UPC/upcxx/src/packing.cpp

g++ -std=c++11 -D_GNU_SOURCE=1 -I/home/pcp1/bonachea/UPC/upcxx/.nobs/art/0a7ba1ef0158d03f0d7127ade4a98b19e09f7572 -MM -MT x /home/pcp1/bonachea/UPC/upcxx/src/digest.cpp

g++ -std=c++11 -D_GNU_SOURCE=1 -I/home/pcp1/bonachea/UPC/upcxx/.nobs/art/0a7ba1ef0158d03f0d7127ade4a98b19e09f7572 -DUPCXX_BACKEND=gasnet1_seq -D_GNU_SOURCE=1 -DGASNET_SEQ -I/home/pcp1/bonachea/UPC/upcr-ex/gasnet -I/home/pcp1/bonachea/UPC/upcr-ex/gasnet/smp-conduit -I/home/pcp1/bonachea/UPC/upcr-ex/gasnet/other -I/home/pcp1/bonachea/UPC/upcr-ex/gasnet/extended-ref -I/home/pcp1/bonachea/UPC/bupcr-ex/dbg/gasnet -MM -MT x /home/pcp1/bonachea/UPC/upcxx/src/backend/gasnet/runtime.cpp

g++ -std=c++11 -D_GNU_SOURCE=1 -I/home/pcp1/bonachea/UPC/upcxx/.nobs/art/0a7ba1ef0158d03f0d7127ade4a98b19e09f7572 -DUPCXX_BACKEND=gasnet1_seq -D_GNU_SOURCE=1 -DGASNET_SEQ -I/home/pcp1/bonachea/UPC/upcr-ex/gasnet -I/home/pcp1/bonachea/UPC/upcr-ex/gasnet/smp-conduit -I/home/pcp1/bonachea/UPC/upcr-ex/gasnet/other -I/home/pcp1/bonachea/UPC/upcr-ex/gasnet/extended-ref -I/home/pcp1/bonachea/UPC/bupcr-ex/dbg/gasnet -MM -MT x /home/pcp1/bonachea/UPC/upcxx/src/backend/gasnet/handle_cb.cpp

g++ -std=c++11 -D_GNU_SOURCE=1 -I/home/pcp1/bonachea/UPC/upcxx/.nobs/art/0a7ba1ef0158d03f0d7127ade4a98b19e09f7572 -DUPCXX_BACKEND=gasnet1_seq -D_GNU_SOURCE=1 -DGASNET_SEQ -I/home/pcp1/bonachea/UPC/upcr-ex/gasnet -I/home/pcp1/bonachea/UPC/upcr-ex/gasnet/smp-conduit -I/home/pcp1/bonachea/UPC/upcr-ex/gasnet/other -I/home/pcp1/bonachea/UPC/upcr-ex/gasnet/extended-ref -I/home/pcp1/bonachea/UPC/bupcr-ex/dbg/gasnet -MM -MT x /home/pcp1/bonachea/UPC/upcxx/src/dist_object.cpp

g++ -std=c++11 -D_GNU_SOURCE=1 -I/home/pcp1/bonachea/UPC/upcxx/.nobs/art/0a7ba1ef0158d03f0d7127ade4a98b19e09f7572 -O0 -g -Wall -c /home/pcp1/bonachea/UPC/upcxx/src/future/core.cpp -o /home/pcp1/bonachea/UPC/upcxx/.nobs/art/e9b9a5a576b3aa812dce3a14cc40dd9896715736.core.cpp.o

g++ -std=c++11 -D_GNU_SOURCE=1 -I/home/pcp1/bonachea/UPC/upcxx/.nobs/art/0a7ba1ef0158d03f0d7127ade4a98b19e09f7572 -O0 -g -Wall -c /home/pcp1/bonachea/UPC/upcxx/src/diagnostic.cpp -o /home/pcp1/bonachea/UPC/upcxx/.nobs/art/514da67fad0efea41f650dc6d6b7a4d315a71c94.diagnostic.cpp.o

g++ -std=c++11 -D_GNU_SOURCE=1 -I/home/pcp1/bonachea/UPC/upcxx/.nobs/art/0a7ba1ef0158d03f0d7127ade4a98b19e09f7572 -O0 -g -Wall -c /home/pcp1/bonachea/UPC/upcxx/src/lpc_inbox.cpp -o /home/pcp1/bonachea/UPC/upcxx/.nobs/art/a6c19cf2bedc0ac36ff1d15d35cafde01703b578.lpc_inbox.cpp.o

g++ -std=c++11 -D_GNU_SOURCE=1 -I/home/pcp1/bonachea/UPC/upcxx/.nobs/art/0a7ba1ef0158d03f0d7127ade4a98b19e09f7572 -O0 -g -Wall -c /home/pcp1/bonachea/UPC/upcxx/src/persona.cpp -o /home/pcp1/bonachea/UPC/upcxx/.nobs/art/1af045a5e1b01dfedc8e17485d23d1bab515ba21.persona.cpp.o

g++ -std=c++11 -D_GNU_SOURCE=1 -I/home/pcp1/bonachea/UPC/upcxx/.nobs/art/0a7ba1ef0158d03f0d7127ade4a98b19e09f7572 -O0 -g -Wall -c /home/pcp1/bonachea/UPC/upcxx/src/packing.cpp -o /home/pcp1/bonachea/UPC/upcxx/.nobs/art/bc64cae0d34829abcf9b82359ad7fe3acbca4a11.packing.cpp.o

g++ -std=c++11 -D_GNU_SOURCE=1 -I/home/pcp1/bonachea/UPC/upcxx/.nobs/art/0a7ba1ef0158d03f0d7127ade4a98b19e09f7572 -O0 -g -Wall -c /home/pcp1/bonachea/UPC/upcxx/src/digest.cpp -o /home/pcp1/bonachea/UPC/upcxx/.nobs/art/9499f845723083af141117abcb7b00a7987cd68e.digest.cpp.o

g++ -std=c++11 -D_GNU_SOURCE=1 -I/home/pcp1/bonachea/UPC/upcxx/.nobs/art/0a7ba1ef0158d03f0d7127ade4a98b19e09f7572 -DUPCXX_BACKEND=gasnet1_seq -D_GNU_SOURCE=1 -DGASNET_SEQ -I/home/pcp1/bonachea/UPC/upcr-ex/gasnet -I/home/pcp1/bonachea/UPC/upcr-ex/gasnet/smp-conduit -I/home/pcp1/bonachea/UPC/upcr-ex/gasnet/other -I/home/pcp1/bonachea/UPC/upcr-ex/gasnet/extended-ref -I/home/pcp1/bonachea/UPC/bupcr-ex/dbg/gasnet -O0 -g -Wall -g3 -Wall -Wpointer-arith -Wwrite-strings -Wmissing-format-attribute -Wno-unused -Wno-unused-parameter -Wno-address -c /home/pcp1/bonachea/UPC/upcxx/src/backend/gasnet/handle_cb.cpp -o /home/pcp1/bonachea/UPC/upcxx/.nobs/art/74b6c98bdc6a5440f82230bea4b3077fb972acda.handle_cb.cpp.o

g++ -std=c++11 -D_GNU_SOURCE=1 -I/home/pcp1/bonachea/UPC/upcxx/.nobs/art/0a7ba1ef0158d03f0d7127ade4a98b19e09f7572 -DUPCXX_BACKEND=gasnet1_seq -D_GNU_SOURCE=1 -DGASNET_SEQ -I/home/pcp1/bonachea/UPC/upcr-ex/gasnet -I/home/pcp1/bonachea/UPC/upcr-ex/gasnet/smp-conduit -I/home/pcp1/bonachea/UPC/upcr-ex/gasnet/other -I/home/pcp1/bonachea/UPC/upcr-ex/gasnet/extended-ref -I/home/pcp1/bonachea/UPC/bupcr-ex/dbg/gasnet -O0 -g -Wall -g3 -Wall -Wpointer-arith -Wwrite-strings -Wmissing-format-attribute -Wno-unused -Wno-unused-parameter -Wno-address -c /home/pcp1/bonachea/UPC/upcxx/src/dist_object.cpp -o /home/pcp1/bonachea/UPC/upcxx/.nobs/art/7a29b8c5ef61f1d6db18cbd3d4e2a06fe370cdf2.dist_object.cpp.o

g++ -std=c++11 -D_GNU_SOURCE=1 -I/home/pcp1/bonachea/UPC/upcxx/.nobs/art/0a7ba1ef0158d03f0d7127ade4a98b19e09f7572 -DUPCXX_BACKEND=gasnet1_seq -D_GNU_SOURCE=1 -DGASNET_SEQ -I/home/pcp1/bonachea/UPC/upcr-ex/gasnet -I/home/pcp1/bonachea/UPC/upcr-ex/gasnet/smp-conduit -I/home/pcp1/bonachea/UPC/upcr-ex/gasnet/other -I/home/pcp1/bonachea/UPC/upcr-ex/gasnet/extended-ref -I/home/pcp1/bonachea/UPC/bupcr-ex/dbg/gasnet -O0 -g -Wall -g3 -Wall -Wpointer-arith -Wwrite-strings -Wmissing-format-attribute -Wno-unused -Wno-unused-parameter -Wno-address -c /home/pcp1/bonachea/UPC/upcxx/src/backend/gasnet/runtime.cpp -o /home/pcp1/bonachea/UPC/upcxx/.nobs/art/eaf99ce2fa3f228f9de3675d266c9b177553ba67.runtime.cpp.o

g++ -std=c++11 -D_GNU_SOURCE=1 -I/home/pcp1/bonachea/UPC/upcxx/.nobs/art/0a7ba1ef0158d03f0d7127ade4a98b19e09f7572 -MM -MT x /home/pcp1/bonachea/UPC/upcxx/src/backend/gasnet/rpc_inbox.cpp

gcc -std=c11 -D_GNU_SOURCE=1 -I/home/pcp1/bonachea/UPC/upcxx/.nobs/art/0a7ba1ef0158d03f0d7127ade4a98b19e09f7572 -MM -MT x /home/pcp1/bonachea/UPC/upcxx/src/dl_malloc.c

gcc -std=c11 -D_GNU_SOURCE=1 -I/home/pcp1/bonachea/UPC/upcxx/.nobs/art/0a7ba1ef0158d03f0d7127ade4a98b19e09f7572 -O0 -g -Wall -c /home/pcp1/bonachea/UPC/upcxx/src/dl_malloc.c -o /home/pcp1/bonachea/UPC/upcxx/.nobs/art/a0993f216196b1f62888c44e9f24bbce6d97b5b7.dl_malloc.c.o

g++ -std=c++11 -D_GNU_SOURCE=1 -I/home/pcp1/bonachea/UPC/upcxx/.nobs/art/0a7ba1ef0158d03f0d7127ade4a98b19e09f7572 -O0 -g -Wall -c /home/pcp1/bonachea/UPC/upcxx/src/backend/gasnet/rpc_inbox.cpp -o /home/pcp1/bonachea/UPC/upcxx/.nobs/art/301f8b6d8b956a861aaf62b557a37fc65fc388c7.rpc_inbox.cpp.o

ar rcs /home/pcp1/bonachea/UPC/upcxx/.nobs/art/7c40018c97d76b6df3238bdc9822a4d70f75ed00/libupcxx.a /home/pcp1/bonachea/UPC/upcxx/.nobs/art/514da67fad0efea41f650dc6d6b7a4d315a71c94.diagnostic.cpp.o /home/pcp1/bonachea/UPC/upcxx/.nobs/art/e9b9a5a576b3aa812dce3a14cc40dd9896715736.core.cpp.o /home/pcp1/bonachea/UPC/upcxx/.nobs/art/a6c19cf2bedc0ac36ff1d15d35cafde01703b578.lpc_inbox.cpp.o /home/pcp1/bonachea/UPC/upcxx/.nobs/art/bc64cae0d34829abcf9b82359ad7fe3acbca4a11.packing.cpp.o /home/pcp1/bonachea/UPC/upcxx/.nobs/art/1af045a5e1b01dfedc8e17485d23d1bab515ba21.persona.cpp.o /home/pcp1/bonachea/UPC/upcxx/.nobs/art/74b6c98bdc6a5440f82230bea4b3077fb972acda.handle_cb.cpp.o /home/pcp1/bonachea/UPC/upcxx/.nobs/art/9499f845723083af141117abcb7b00a7987cd68e.digest.cpp.o /home/pcp1/bonachea/UPC/upcxx/.nobs/art/ebb215779cecbc141a5ceffba2e89af74d51c944.upcxx.cpp.o /home/pcp1/bonachea/UPC/upcxx/.nobs/art/ebb215779cecbc141a5ceffba2e89af74d51c944.upcxx.cpp.o /home/pcp1/bonachea/UPC/upcxx/.nobs/art/a0993f216196b1f62888c44e9f24bbce6d97b5b7.dl_malloc.c.o /home/pcp1/bonachea/UPC/upcxx/.nobs/art/7a29b8c5ef61f1d6db18cbd3d4e2a06fe370cdf2.dist_object.cpp.o /home/pcp1/bonachea/UPC/upcxx/.nobs/art/301f8b6d8b956a861aaf62b557a37fc65fc388c7.rpc_inbox.cpp.o /home/pcp1/bonachea/UPC/upcxx/.nobs/art/eaf99ce2fa3f228f9de3675d266c9b177553ba67.runtime.cpp.o

UPC++ successfully installed
{pcp-d-5 ~/UPC/upcxx} ls -R test7
test7:
total 12
4 bin/  4 include/  4 lib/

test7/bin:
total 4
4 upcxx-meta*

test7/include:
total 772
 48 gasnet.h           156 gasnet_atomic_bits.h   36 gasnet_coll.h               24 gasnet_membar.h     32 gasnet_tools.h   32 gasnetex.h
 72 gasnet_ammacros.h   76 gasnet_atomicops.h     12 gasnet_handler_internal.h   28 gasnet_timer.h      60 gasnet_trace.h    4 upcxx/
 12 gasnet_asm.h        36 gasnet_basic.h         56 gasnet_help.h               44 gasnet_toolhelp.h   44 gasnet_vis.h

test7/include/upcxx:
total 180
 8 allocate.hpp    4 backend/         12 bind.hpp        4 completion.hpp   8 dist_object.hpp   8 global_ptr.hpp  12 persona.hpp      8 rpc.hpp    16 utility.hpp
 4 allreduce.hpp   4 backend.hpp       4 broadcast.hpp   4 diagnostic.hpp   4 future/           4 lpc_inbox.hpp    8 reflection.hpp   8 rput.hpp
 4 atomic.hpp      4 backend_fwd.hpp   4 command.hpp     4 digest.hpp       4 future.hpp       28 packing.hpp      8 rget.hpp         4 upcxx.hpp

test7/include/upcxx/backend:
total 4
4 gasnet/

test7/include/upcxx/backend/gasnet:
total 12
4 handle_cb.hpp  8 runtime.hpp

test7/include/upcxx/future:
total 96
 4 apply.hpp      24 core.hpp      8 impl_mapped.hpp  12 impl_shref.hpp      4 make_future.hpp  12 then.hpp
 4 body_pure.hpp   8 future1.hpp   4 impl_result.hpp   8 impl_when_all.hpp   4 promise.hpp       4 when_all.hpp

test7/lib:
total 19188
15468 libgasnet-smp-seq.a   3720 libupcxx.a

Note that an incomplete set of the GASNet headers have been copied into $root/include, and they would not function if any code tried to use them.

With a default, downloaded GASNet, the trace is longer but the result is the same:

{pcp-d-5 ~/UPC/upcxx} rm -Rf .nobs/ ; env DBGSYM=1 OPTLEV=0 ./install --single test8                                                   
./install: line 17: [: --single: integer expression expected
UPCXX revision: a0d6e07
System: Linux pcp-d-5 3.10.0-693.1.1.el7.x86_64 #1 SMP Tue Aug 15 08:36:44 CDT 2017 x86_64 x86_64 x86_64 GNU/Linux
LSB Version:    :core-4.1-amd64:core-4.1-noarch
Distributor ID: Scientific
Description:    Scientific Linux release 7.3 (Nitrogen)
Release:        7.3
Codename:       Nitrogen

Date: Fri Sep 22 14:51:57 PDT 2017
Current directory: /home/pcp1/bonachea/UPC/upcxx
Install directory:
Settings: OPTLEV='0' DBGSYM='1'

/usr/local/pkg/gcc/7.2.0/bin/g++
g++ (GCC) 7.2.0
Copyright (C) 2017 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

/usr/local/pkg/gcc/7.2.0/bin/gcc
gcc (GCC) 7.2.0
Copyright (C) 2017 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.


Downloading http://mantis.lbl.gov/nightly/unlisted/GASNet-EX-collaborator-snapshot.tar.gz
Finished    http://mantis.lbl.gov/nightly/unlisted/GASNet-EX-collaborator-snapshot.tar.gz
Configuring GASNet...
(in /home/pcp1/bonachea/UPC/upcxx/.nobs/art/de4365f8e4d94a45e1f2cba39c727d8c13b1033c)
/home/pcp1/bonachea/UPC/upcxx/.nobs/art/e38e53790f72611dba0e8918231afbff4faf6961/GASNet-EX-collaborator-snapshot/configure --enable-debug --disable-psm --disable-mxm --disable-portals4 --disable-ofi --disable-dev-warnings

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/pcp1/bonachea/UPC/upcxx/.nobs/art/e38e53790f72611dba0e8918231afbff4faf6961/GASNet-EX-collaborator-snapshot/configure --enable-debug --disable-psm --disable-mxm --disable-portals4 --disable-ofi --disable-dev-warnings

...

{pcp-d-5 ~/UPC/upcxx} ls -R test8
test8:
total 12
4 bin/  4 include/  4 lib/

test8/bin:
total 4
4 upcxx-meta*

test8/include:
total 772
 48 gasnet.h           156 gasnet_atomic_bits.h   36 gasnet_coll.h               24 gasnet_membar.h     32 gasnet_tools.h   32 gasnetex.h
 72 gasnet_ammacros.h   76 gasnet_atomicops.h     12 gasnet_handler_internal.h   28 gasnet_timer.h      60 gasnet_trace.h    4 upcxx/
 12 gasnet_asm.h        36 gasnet_basic.h         56 gasnet_help.h               44 gasnet_toolhelp.h   44 gasnet_vis.h

test8/include/upcxx:
total 180
 8 allocate.hpp    4 backend/         12 bind.hpp        4 completion.hpp   8 dist_object.hpp   8 global_ptr.hpp  12 persona.hpp      8 rpc.hpp    16 utility.hpp
 4 allreduce.hpp   4 backend.hpp       4 broadcast.hpp   4 diagnostic.hpp   4 future/           4 lpc_inbox.hpp    8 reflection.hpp   8 rput.hpp
 4 atomic.hpp      4 backend_fwd.hpp   4 command.hpp     4 digest.hpp       4 future.hpp       28 packing.hpp      8 rget.hpp         4 upcxx.hpp

test8/include/upcxx/backend:
total 4
4 gasnet/

test8/include/upcxx/backend/gasnet:
total 12
4 handle_cb.hpp  8 runtime.hpp

test8/include/upcxx/future:
total 96
 4 apply.hpp      24 core.hpp      8 impl_mapped.hpp  12 impl_shref.hpp      4 make_future.hpp  12 then.hpp
 4 body_pure.hpp   8 future1.hpp   4 impl_result.hpp   8 impl_when_all.hpp   4 promise.hpp       4 when_all.hpp

test8/lib:
total 19192
15468 libgasnet-smp-seq.a   3724 libupcxx.a

Please fix nobs to never copy GASNet header files. It always does it wrong.

Comments (5)

  1. Former user Account Deleted

    I think this should be marked low priority as it does not occur when GASNET is an installed tree. The assumption is that only an installed tree is guaranteed by the user to survive at least as long as the upcxx install. I could extend that assumption to build trees and block the header copy there too, but, given that the speed of "--single" is important for our development I have no choice but to hack around gasnet's installer and do the header copies myself.

  2. Dan Bonachea reporter

    I have no choice but to hack around gasnet's installer and do the header copies myself.

    John - I don't understand this statement. As far as I can tell, the random handful of gasnet headers being installed into $root/include by install --single are truly "dead" in the sense that the UPCXX install is not using them:

    {pcp-d-5 ~/UPC/upcxx/test8} grep -r include include/upcxx/ | grep -e 'gasnet\.h' -e 'gasnet_'
    <no results>
    

    I'm fairly confident they are in fact dead, because several crucial files are missing which make the set of gasnet headers that nobs is installing completely unusable:

    {pcp-d-5 ~/UPC/upcxx/test8} cat > test.c
    #include <gasnet.h>
    {pcp-d-5 ~/UPC/upcxx/test8} gcc -I include test.c
    In file included from include/gasnet.h:11:0,
                     from test.c:1:
    include/gasnetex.h:29:10: fatal error: gasnet_config.h: No such file or directory
     #include <gasnet_config.h>
              ^~~~~~~~~~~~~~~~~
    compilation terminated.
    

    Again, I really think the solution here is for nobs to never install any gasnet headers. It's already doing it wrong (the resulting headers are unusable) and it appears the upcxx install doesn't need them anyhow.

  3. Log in to comment